| # 00:09:26 | diorcety | quits : Quit: Leaving. |
| # 05:59:15 | trigg | joins #crosstool-ng |
| # 06:02:17 | trigg | quits : Quit: ZNC 1.7.x-git-538-5b29bb7 - http://znc.in |
| # 06:03:03 | trigg | joins #crosstool-ng |
| # 06:03:43 | trigg | quits : Client Quit |
| # 06:04:45 | trigg | joins #crosstool-ng |
| # 07:50:39 | diorcety | joins #crosstool-ng |
| # 08:14:36 | diorcety | quits : Quit: Leaving. |
| # 08:55:46 | diorcety | joins #crosstool-ng |
| # 09:37:15 | bhundven | quits : Ping timeout: 240 seconds |
| # 09:51:26 | diorcety | quits : Ping timeout: 255 seconds |
| # 09:51:33 | bhundven | joins #crosstool-ng |
| # 10:13:49 | diorcety | joins #crosstool-ng |
| # 11:47:27 | bhundven | quits : Remote host closed the connection |
| # 12:03:44 | bhundven | joins #crosstool-ng |
| # 15:52:39 | stefanct | quits : Ping timeout: 245 seconds |
| # 15:54:41 | stefanct | joins #crosstool-ng |
| # 16:09:11 | stefanct | quits : Ping timeout: 264 seconds |
| # 17:01:48 | stefanct | joins #crosstool-ng |
| # 17:18:51 | y_morin | joins #crosstool-ng |
| # 18:19:26 | diorcety | quits : Ping timeout: 276 seconds |
| # 18:22:50 | bhundven | waves at y_morin |
| # 18:23:23 | bhundven | roolebo: do you have a chance to try the latest master of ct-ng, wrt issue #290? |
| # 18:23:44 | y_morin | waves back |
| # 18:30:52 | bhundven | y_morin: one quick question for ya |
| # 18:31:56 | bhundven | y_morin: shouldn't these make calls also pass ${extra_user_env}: https://github.com/crosstool-ng/crosstool-ng/blob/master/scripts/build/cc/100-gcc.sh#L456 |
| # 18:32:39 | bhundven | from 457 to 473? |
| # 18:34:45 | bhundven | as they do further down from 491 to 525 |
| # 18:37:08 | y_morin | looks |
| # 18:39:04 | roolebo | bhundven: sure I will try tomorrow or tonight |
| # 18:39:21 | bhundven | roolebo: thanks! |
| # 18:41:31 | y_morin | bhundven: Hmm.. This extra_user_env seems dubious to start with... |
| # 18:42:12 | bhundven | y_morin: hows that? |
| # 18:42:13 | y_morin | First: if [ "x${var}" != "x" ] should really been written as: if [ -n "${var}" ] |
| # 18:42:43 | bhundven | hehehe |
| # 18:42:45 | bhundven | I see |
| # 18:43:05 | y_morin | Second, if there is a need to specify extra option, I think it would have been better done with an actual configuration knob. |
| # 18:43:29 | y_morin | bhundven: Allowing to pass arbitrary variables to make looks really dubious... |
| # 18:44:12 | bhundven | hm, I think I can agree with that. |
| # 18:44:32 | y_morin | bhundven: The commit log does not explain why this is needed. |
| # 18:45:19 | bhundven | notes another line to nuke |
| # 18:45:22 | y_morin | The help text has more info, but what it explains really looks like it is tricky and should be hnadled explicitly by a boolean (or a choice) rather than a free-form string. |
| # 18:45:22 | bhundven | :) |
| # 18:46:06 | bhundven | y_morin: thanks again. I kind of wasn't sure why that was there. |
| # 18:46:22 | bhundven | and it was inconsistent |
| # 18:48:12 | y_morin | bhundven: Well, to answer your initial question: from the looks of it, it seems it should be in all calls to make, yes. |
| # 18:48:32 | y_morin | bhundven: However, since I don;t see why it was added, I can't say for sure. |
| # 18:49:15 | y_morin | bhundven: The help text mentions INHIBIT_LIBC_CFLAGS='-DUSE_TM_CLONE_REGISTRY=0' which may well not be used by those early steps, but only by the later ones. |
| # 18:50:21 | bhundven | y_morin: true, but I agree with your assertion that if it is needed, then it should be a specific kconfig option. That option looks like future support trouble. |
| # 18:50:50 | y_morin | bhundven: Yes, that is the problem. |
| # 18:51:14 | y_morin | bhundven: We can provide generic strings to set non-critical options (like number of jobs...) |
| # 18:51:28 | y_morin | bhundven: but as soone as it touches the build process, booleans are better. |
| # 18:51:34 | bhundven | yup |
| # 18:51:53 | bhundven | y_morin: thanks for the second pair of eyes on that! |
| # 18:52:02 | y_morin | Cheers! |
| # 18:52:27 | y_morin | bhundven: One case where strings/ints could be needed would be if it would be impractical to provide an option, like 100 possible values of an integer... |
| # 18:52:48 | y_morin | Otherwise, all that can be booleans (or tristates) should be. |
| # 18:53:41 | bhundven | right |
| # 18:54:07 | y_morin | bhundven: Also, beware of the option creep. ;-) |
| # 18:55:23 | bhundven | yea, I'm currently trying to sync core-backend and backend |
| # 18:55:42 | bhundven | eventually to merge them into one backend |
| # 18:56:07 | bhundven | 100-gcc.sh is unwieldy |
| # 18:56:24 | y_morin | goes dinner... :-) |
| # 18:58:07 | bhundven | enjoy! |
| # 19:19:16 | diorcety | joins #crosstool-ng |
| # 20:54:00 | mingwandroid | joins #crosstool-ng |
| # 21:56:35 | Net147_ | joins #crosstool-ng |
| # 21:58:59 | Net147 | quits : Ping timeout: 264 seconds |
| # 22:25:08 | Net147_ | quits : Ping timeout: 276 seconds |
| # 22:29:28 | Net147 | joins #crosstool-ng |
| # 23:22:14 | y_morin | quits : Quit: Nighty Night! |