# 01:59:28 |
bhundven |
joins #crosstool-ng |
# 02:37:07 |
blueness |
quits : Quit: blueness |
# 02:59:16 |
bhundven |
aneyman__: one comment I have on the entire patch series |
# 02:59:48 |
bhundven |
aneyman__: we use 4 space tabs, but I've found lots of 8 space hard tabs in lots of the patches |
# 03:00:19 |
bhundven |
some might have been there before, and I'm working on determining which patches have them |
# 03:00:29 |
bhundven |
so I can comment on those directly |
# 03:02:28 |
bhundven |
your patch series introduces 508 lines that contain hard tabs |
# 03:03:00 |
bhundven |
while 30231 lines already have hard tabs, and shoudl be fixed in future commits |
# 03:05:01 |
bhundven |
(excluding the patches directory) |
# 03:06:32 |
bhundven |
the sad part is that I thought that I had done a whitespace cleanup a little while ago (around 1.22), so since then we've introduced 30231 lines of hard tabs?!? *sigh* |
# 03:09:26 |
bhundven |
yes, It may sound like nitpicking, but then again, you should have been commiting when Yann was maintaining. I'm a little more lenient :) |
# 03:10:18 |
bhundven |
nothing against yann at all. I still look to him for guidence! |
# 03:14:17 |
alan_o |
quits : Ping timeout: 265 seconds |
# 03:34:04 |
blueness |
joins #crosstool-ng |
# 03:35:03 |
blueness |
quits : Client Quit |
# 08:12:24 |
y_morin |
joins #crosstool-ng |
# 08:18:43 |
diorcety |
joins #crosstool-ng |
# 08:32:21 |
blueness |
joins #crosstool-ng |
# 08:43:35 |
blueness_ |
joins #crosstool-ng |
# 08:45:17 |
bhundven |
quits : Quit: Lost terminal |
# 08:46:12 |
blueness |
quits : Read error: No route to host |
# 08:47:02 |
blueness |
joins #crosstool-ng |
# 09:01:48 |
y_morin |
quits : Quit: Back in a moment... |
# 09:03:20 |
bhundven |
joins #crosstool-ng |
# 09:03:23 |
y_morin |
joins #crosstool-ng |
# 09:03:32 |
bhundven |
y_morin: hello! |
# 09:03:45 |
y_morin |
bhundven: Hey! :-) |
# 09:04:11 |
bhundven |
y_morin: I hope you've been well! |
# 09:04:28 |
y_morin |
bhundven: Yes! And you? |
# 09:04:36 |
bhundven |
y_morin: much better. |
# 09:04:53 |
y_morin |
Oh, you've been ill? |
# 09:05:17 |
bhundven |
was out of work for about 7 months. start a new job on the 23rd |
# 09:05:25 |
bhundven |
:) |
# 09:05:30 |
y_morin |
Good news! :-) |
# 09:06:53 |
bhundven |
I know you're usually very busy, but I'm curious if you could do a quick look over https://github.com/crosstool-ng/crosstool-ng/pull/383 ? It's a big PR, and has some unrelated commits in it. But it's hard to get reviewers around here. |
# 09:07:46 |
y_morin |
Woot... 35 commits... :-] |
# 09:07:58 |
bhundven |
yes, aneyman__ has done a lot of work on multilib |
# 09:08:11 |
bhundven |
(aka stilor) |
# 09:10:11 |
y_morin |
I'm battling a USB gadget issue right now... Ping me on it tonight (~20:00 UTC...) |
# 09:10:25 |
bhundven |
sure! Thanks! |
# 09:10:49 |
bhundven |
I need sleep anyways :) |
# 09:11:14 |
y_morin |
Hehe! :-) |
# 09:13:31 |
bhundven |
ttyl! |
# 09:13:50 |
y_morin |
Night! |
# 09:53:16 |
y_morin |
quits : Quit: Nighty Night! Back ~20:00 UTC... |
# 10:48:37 |
mingwandroid |
joins #crosstool-ng |
# 11:02:34 |
Net147 |
quits : Ping timeout: 240 seconds |
# 11:06:24 |
Net147 |
joins #crosstool-ng |
# 11:11:34 |
Net147 |
quits : Ping timeout: 260 seconds |
# 11:13:56 |
Net147 |
joins #crosstool-ng |
# 11:32:21 |
Net147 |
quits : Ping timeout: 276 seconds |
# 11:33:30 |
Net147 |
joins #crosstool-ng |
# 12:34:28 |
diorcety |
quits : Read error: Connection reset by peer |
# 12:36:16 |
diorcety |
joins #crosstool-ng |
# 12:56:25 |
patrickdp |
joins #crosstool-ng |
# 13:10:31 |
alan_o |
joins #crosstool-ng |
# 13:29:48 |
Elimin8er |
quits : Ping timeout: 276 seconds |
# 13:48:23 |
enunes |
quits : Read error: Connection reset by peer |
# 13:48:37 |
enunes |
joins #crosstool-ng |
# 13:49:10 |
enunes |
quits : Read error: Connection reset by peer |
# 14:03:37 |
enunes |
joins #crosstool-ng |
# 14:08:23 |
blueness |
quits : Quit: blueness |
# 14:09:36 |
blueness |
joins #crosstool-ng |
# 15:23:44 |
Elimin8er |
joins #crosstool-ng |
# 15:34:36 |
patrickdp |
quits : Ping timeout: 276 seconds |
# 17:32:32 |
diorcety |
quits : Read error: Connection reset by peer |
# 18:59:21 |
diorcety |
joins #crosstool-ng |
# 19:07:39 |
diorcety |
quits : Read error: Connection reset by peer |
# 21:02:20 |
y_morin |
joins #crosstool-ng |
# 21:29:41 |
y_morin |
aneyman__: Hey! I've started having a look at your multilib series. It's pretty long, as it mixes quite a few different stuff. |
# 21:30:09 |
y_morin |
aneyman__: I won't be able to review it all tonight (23:30 here), so don;t hold your breath... |
# 21:50:41 |
enunes |
quits : Read error: Connection reset by peer |
# 22:06:47 |
aneyman__ |
hey, I am not holding my breath for a couple of months already :) it's been pending awhile, and the branch that fixed half of our samples (build was broken) was only picked up last week after a couple months delay |
# 22:07:14 |
aneyman__ |
bhundven was going through some rough patch and didn't have much time for maintainership |
# 22:08:34 |
aneyman__ |
as to mixing, I'd preferred to do glibc-multilib first and then do uClibc-multilib and musl-multilib as separate changes, but again, because the integration of the baseline branch took so long, I didn't have other options than to combine them |
# 22:09:24 |
y_morin |
aneyman__: I can understand that. Reviewing a 35-patch series is just daunting... :-/ |
# 22:09:49 |
y_morin |
Anyway, past midnight here, after a rather rough day at work. Need to recover... |
# 22:10:12 |
y_morin |
aneyman__: As I commented: ping me tomorrow when you see me on IRC, so I do not forget to continue the review... |
# 22:10:34 |
y_morin |
And now, bed... |
# 22:11:04 |
y_morin |
quits : Quit: Nighty Night! |
# 22:32:54 |
blueness |
quits : Quit: blueness |
# 22:40:40 |
blueness |
joins #crosstool-ng |
# 22:53:39 |
mingwandroid |
quits : Ping timeout: 246 seconds |
# 22:55:31 |
bhundven |
ignore the "reviewable" stuff on github. I was trying out an external app: https://reviewable.io |
# 22:56:14 |
Net147 |
quits : Ping timeout: 244 seconds |
# 22:58:06 |
Net147 |
joins #crosstool-ng |