diff options
| author |   Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com> | 2011-07-28 20:09:31 (GMT) |
|---|---|---|
| committer | Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com> | 2011-07-28 20:09:31 (GMT) |
| commit | 2ea05ecaa77cafacdb5664e0c5bec73a0164e15b (patch) | |
| tree | 5b54c086edf6ba71de47336998df2d3ec37785a9 | |
| parent | 4c21311b3cd7972c0466cb5c38e261db4d35143c (diff) | |
scripts/libc: do not build add-ons by default
Currently, no --enable-add-ons option is passed to libc configure when
"$(do_libc_add_ons_list ,)" is empty, which makes configure automatically search
for present add-ons. In that case, all present add-ons are built, although
no add-on was selected by the user in the config. Moreover, this can make the
configure fail if some non-standard add-ons like eglibc-localedef are present.
This behavior also leads to an inconsistency from a user point of view between
the following cases:
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS="none" in the config,
which makes "$(do_libc_add_ons_list ,)" return "", so all present add-ons
are built.
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS!="none" in the
config, which makes "$(do_libc_add_ons_list ,)" return the add-on supporting
the chosen threading implementation, e.g. "nptl", so only this add-on is
built.
This patch disables the building of all add-ons in that case.
It is still possible to build all present add-ons by adding --enable-add-ons to
LIBC_GLIBC_EXTRA_CONFIG_ARRAY.
Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
| -rw-r--r-- | scripts/build/libc/glibc-eglibc.sh-common | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/build/libc/glibc-eglibc.sh-common b/scripts/build/libc/glibc-eglibc.sh-common index 6e423b6..f57e9e9 100644 --- a/scripts/build/libc/glibc-eglibc.sh-common +++ b/scripts/build/libc/glibc-eglibc.sh-common @@ -142,7 +142,7 @@ do_libc_backend() { fi case "$(do_libc_add_ons_list ,)" in - "") ;; + "") extra_config+=("--enable-add-ons=no");; *) extra_config+=("--enable-add-ons=$(do_libc_add_ons_list ,)");; esac |