From d6f8cd9b0a714fc22fc1ddd200fb0e4047708df9 Mon Sep 17 00:00:00 2001
From: "Yann E. MORIN\"" <yann.morin.1998@anciens.enib.fr>
Date: Tue, 13 Dec 2011 11:51:07 +0100
Subject: libc/glibc: no default mode for backend

The caller SHALL explicitly ask for a nmode, and not rely on a default mode.
That's what actually happens, so we can get rid of the default.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>

diff --git a/scripts/build/libc/glibc-eglibc.sh-common b/scripts/build/libc/glibc-eglibc.sh-common
index f1c7fb3..dba9a76 100644
--- a/scripts/build/libc/glibc-eglibc.sh-common
+++ b/scripts/build/libc/glibc-eglibc.sh-common
@@ -67,9 +67,9 @@ do_libc() {
 
 # Usage: do_libc_backend param=value [...]
 #   Parameter           : Definition                            : Type      : Default
-#   libc_mode           : 'startfiles' or 'final'               : string    : final
+#   libc_mode           : 'startfiles' or 'final'               : string    : (none)
 do_libc_backend() {
-    local libc_mode=final
+    local libc_mode
     local src_dir="${CT_SRC_DIR}/${CT_LIBC}-${CT_LIBC_VERSION}"
     local extra_cc_args
     local -a extra_config
@@ -81,11 +81,11 @@ do_libc_backend() {
         shift
     done
 
-    if [ "${libc_mode}" = "startfiles" ]; then
-        CT_DoStep INFO "Installing C library headers & start files"
-    else # libc_mode = final
-        CT_DoStep INFO "Installing C library"
-    fi
+    case "${libc_mode}" in
+        startfiles) CT_DoStep INFO "Installing C library headers & start files";;
+        final)      CT_DoStep INFO "Installing C library";;
+        *)          CT_Abort "Unsupported (or unset) libc_mode='${libc_mode}'";;
+    esac
     mkdir -p "${CT_BUILD_DIR}/build-libc-${libc_mode}"
     cd "${CT_BUILD_DIR}/build-libc-${libc_mode}"
 
-- 
cgit v0.10.2-6-g49f6