On 20090120.2203+0100, Andy Johnson <ajohnson@aecno.com> wrote:
The glibc.sh script doesn't handle the glibc versions with
an underscore very well (bash expected integer error). I
have attached a small patch for that. Instead of looking
for "not period" I changed the sense to look for numbers.
I initially tried to make it look for either a period or
an underscore, but that didn't work like I wanted (probably
because I did something wrong).

Original patch modified to be more robust.

/trunk/scripts/build/libc/glibc.sh | 8 4 4 0 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff -dur binutils-2.17.old/bfd/opncls.c binutils-2.17/bfd/opncls.c

--- binutils-2.17.old/bfd/opncls.c	2006-03-16 13:20:16.000000000 +0100

+++ binutils-2.17/bfd/opncls.c	2007-05-01 18:26:11.000000000 +0200

@@ -158,6 +158,13 @@

 {

   bfd *nbfd;

   const bfd_target *target_vec;

+  struct stat s;

+

+  if (stat (filename, &s) == 0)

+    if (S_ISDIR(s.st_mode)) {

+      bfd_set_error (bfd_error_file_not_recognized);

+      return NULL;

+    }

   nbfd = _bfd_new_bfd ();

   if (nbfd == NULL)