patches/glibc/ports-2.13/260-assume-pipe2.patch
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Tue May 03 00:19:56 2011 +0200 (2011-05-03)
changeset 2438 2ba5655f6297
permissions -rw-r--r--
libc/glibc: add 2.13

Patchset provided by "Ioannis E. Venetis" <venetis@mail.capsl.udel.edu>
http://sourceware.org/ml/crossgcc/2011-04/msg00072.html
http://sourceware.org/ml/crossgcc/2011-04/msg00073.html

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
yann@2438
     1
http://bugs.gentoo.org/250342
yann@2438
     2
http://sources.redhat.com/bugzilla/show_bug.cgi?id=9685
yann@2438
     3
yann@2438
     4
we cant assume sock_cloexec and pipe2 are bound together as the former defines
yann@2438
     5
are found in glibc only while the latter are a combo of kernel headers and
yann@2438
     6
glibc.  so if we do a runtime detection of SOCK_CLOEXEC, but pipe2() is a stub
yann@2438
     7
inside of glibc, we hit a problem.  for example:
yann@2438
     8
yann@2438
     9
#include <grp.h>
yann@2438
    10
#include <stdio.h>
yann@2438
    11
main()
yann@2438
    12
{
yann@2438
    13
	getgrnam("portage");
yann@2438
    14
	if (!popen("ls", "r"))
yann@2438
    15
		perror("popen()");
yann@2438
    16
}
yann@2438
    17
yann@2438
    18
getgrnam() will detect that the kernel supports SOCK_CLOEXEC and then set both
yann@2438
    19
__have_sock_cloexec and __have_pipe2 to true.  but if glibc was built against
yann@2438
    20
older kernel headers where __NR_pipe2 does not exist, glibc will have a ENOSYS
yann@2438
    21
stub for it.  so popen() will always fail as glibc assumes pipe2() works.
yann@2438
    22
yann@2438
    23
diff -durN glibc-2.13.orig/socket/have_sock_cloexec.c glibc-2.13/socket/have_sock_cloexec.c
yann@2438
    24
--- glibc-2.13.orig/socket/have_sock_cloexec.c	2008-07-25 18:46:23.000000000 +0200
yann@2438
    25
+++ glibc-2.13/socket/have_sock_cloexec.c	2009-11-13 00:50:15.000000000 +0100
yann@2438
    26
@@ -16,9 +16,14 @@
yann@2438
    27
    Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
yann@2438
    28
    02111-1307 USA.  */
yann@2438
    29
 
yann@2438
    30
+#include <fcntl.h>
yann@2438
    31
 #include <sys/socket.h>
yann@2438
    32
 #include <kernel-features.h>
yann@2438
    33
 
yann@2438
    34
 #if defined SOCK_CLOEXEC && !defined __ASSUME_SOCK_CLOEXEC
yann@2438
    35
 int __have_sock_cloexec;
yann@2438
    36
 #endif
yann@2438
    37
+
yann@2438
    38
+#if defined O_CLOEXEC && !defined __ASSUME_PIPE2
yann@2438
    39
+int __have_pipe2;
yann@2438
    40
+#endif