patches/binutils/2.17a/140-better_file_error.patch
author "Yann E. MORIN" <yann.morin.1998@free.fr>
Tue Oct 16 20:57:44 2012 +0200 (2012-10-16)
changeset 3079 37831a33e07e
parent 747 d3e603e7c17c
permissions -rw-r--r--
kernel/linux: fix using custom location

Currently, extract and patch are skipped as thus:
- using a custom directory of pre-installed headers
- a correctly named directory already exists

Otherwise, extract and patch are done.

The current second condition is wrong, because it allows the following
sequence to happen:
- a non-custom kernel is used
- a previous build only partially extracted the non-custom sources
- that p[revious build broke during extraction (eg. incomplete tarball...)
- a subsequent build will find a properly named directory, and will
thus skip extract and patch, which is wrong

Fix that by following the conditions in this table:

Type | Extract | Patch
----------------------+---------+-------
Pre-installed headers | N | N
custom directory | N | N
custom tarball | Y | N
mainstream tarball | Y | Y

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: David Holsgrove <david.holsgrove@xilinx.com>
yann@55
     1
diff -dur binutils-2.17.old/bfd/opncls.c binutils-2.17/bfd/opncls.c
yann@55
     2
--- binutils-2.17.old/bfd/opncls.c	2006-03-16 13:20:16.000000000 +0100
yann@55
     3
+++ binutils-2.17/bfd/opncls.c	2007-05-01 18:26:11.000000000 +0200
yann@55
     4
@@ -158,6 +158,13 @@
yann@55
     5
 {
yann@55
     6
   bfd *nbfd;
yann@55
     7
   const bfd_target *target_vec;
yann@55
     8
+  struct stat s;
yann@55
     9
+
yann@55
    10
+  if (stat (filename, &s) == 0)
yann@55
    11
+    if (S_ISDIR(s.st_mode)) {
yann@55
    12
+      bfd_set_error (bfd_error_file_not_recognized);
yann@55
    13
+      return NULL;
yann@55
    14
+    }
yann@55
    15
 
yann@55
    16
   nbfd = _bfd_new_bfd ();
yann@55
    17
   if (nbfd == NULL)