patches/binutils/2.17a/180-psignal.patch
author "Yann E. MORIN" <yann.morin.1998@free.fr>
Tue Oct 16 20:57:44 2012 +0200 (2012-10-16)
changeset 3079 37831a33e07e
parent 747 d3e603e7c17c
permissions -rw-r--r--
kernel/linux: fix using custom location

Currently, extract and patch are skipped as thus:
- using a custom directory of pre-installed headers
- a correctly named directory already exists

Otherwise, extract and patch are done.

The current second condition is wrong, because it allows the following
sequence to happen:
- a non-custom kernel is used
- a previous build only partially extracted the non-custom sources
- that p[revious build broke during extraction (eg. incomplete tarball...)
- a subsequent build will find a properly named directory, and will
thus skip extract and patch, which is wrong

Fix that by following the conditions in this table:

Type | Extract | Patch
----------------------+---------+-------
Pre-installed headers | N | N
custom directory | N | N
custom tarball | Y | N
mainstream tarball | Y | Y

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: David Holsgrove <david.holsgrove@xilinx.com>
yann@56
     1
Make psignal prototype in libiberty match that in glibc.
yann@56
     2
yann@56
     3
Fixes:
yann@56
     4
yann@56
     5
gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c: In function `psignal':
yann@56
     6
gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c:563: argument `signo' doesn't match prototype
yann@56
     7
/usr/include/signal.h:131: prototype declaration
yann@56
     8
gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c:563: argument `message' doesn't match prototype
yann@56
     9
/usr/include/signal.h:131: prototype declaration
yann@56
    10
gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c:568: warning: comparison between signed and unsigned
yann@56
    11
mprotect... make[1]: *** [strsignal.o] Error 1
yann@56
    12
make[1]: Leaving directory `/export/hda3/dkegel/queue/jobdir.produser_cpsm17/crosstool-0.32/build/i686-unknown-linux-gnu/gcc-2.95.3-glibc-2.1.3/build-binutils/libiberty'
yann@56
    13
make: *** [all-libiberty] Error 2
yann@56
    14
yann@56
    15
when building on red hat 7.1
yann@56
    16
though it's a bit of a mystery why libiberty's psignal is being compiled at
yann@56
    17
all, since red hat 7.1's glibc supports psignal (hence the error message)
yann@56
    18
yann@56
    19
--- binutils-2.17/libiberty/strsignal.c.old	2005-04-18 13:57:40.000000000 -0700
yann@56
    20
+++ binutils-2.17/libiberty/strsignal.c	2005-04-18 13:59:09.000000000 -0700
yann@56
    21
@@ -536,7 +536,7 @@
yann@56
    22
 
yann@56
    23
 /*
yann@56
    24
 
yann@56
    25
-@deftypefn Supplemental void psignal (unsigned @var{signo}, char *@var{message})
yann@56
    26
+@deftypefn Supplemental void psignal (int @var{signo}, const char *@var{message})
yann@56
    27
 
yann@56
    28
 Print @var{message} to the standard error, followed by a colon,
yann@56
    29
 followed by the description of the signal specified by @var{signo},