patches/binutils/2.17/140-better_file_error.patch
author "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
Thu Jul 28 22:09:31 2011 +0200 (2011-07-28)
changeset 2573 424fa2092ace
parent 745 e445c00d134d
permissions -rw-r--r--
scripts/libc: do not build add-ons by default

Currently, no --enable-add-ons option is passed to libc configure when
"$(do_libc_add_ons_list ,)" is empty, which makes configure automatically search
for present add-ons. In that case, all present add-ons are built, although
no add-on was selected by the user in the config. Moreover, this can make the
configure fail if some non-standard add-ons like eglibc-localedef are present.

This behavior also leads to an inconsistency from a user point of view between
the following cases:
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS="none" in the config,
which makes "$(do_libc_add_ons_list ,)" return "", so all present add-ons
are built.
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS!="none" in the
config, which makes "$(do_libc_add_ons_list ,)" return the add-on supporting
the chosen threading implementation, e.g. "nptl", so only this add-on is
built.

This patch disables the building of all add-ons in that case.

It is still possible to build all present add-ons by adding --enable-add-ons to
LIBC_GLIBC_EXTRA_CONFIG_ARRAY.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
yann@55
     1
diff -dur binutils-2.17.old/bfd/opncls.c binutils-2.17/bfd/opncls.c
yann@55
     2
--- binutils-2.17.old/bfd/opncls.c	2006-03-16 13:20:16.000000000 +0100
yann@55
     3
+++ binutils-2.17/bfd/opncls.c	2007-05-01 18:26:11.000000000 +0200
yann@55
     4
@@ -158,6 +158,13 @@
yann@55
     5
 {
yann@55
     6
   bfd *nbfd;
yann@55
     7
   const bfd_target *target_vec;
yann@55
     8
+  struct stat s;
yann@55
     9
+
yann@55
    10
+  if (stat (filename, &s) == 0)
yann@55
    11
+    if (S_ISDIR(s.st_mode)) {
yann@55
    12
+      bfd_set_error (bfd_error_file_not_recognized);
yann@55
    13
+      return NULL;
yann@55
    14
+    }
yann@55
    15
 
yann@55
    16
   nbfd = _bfd_new_bfd ();
yann@55
    17
   if (nbfd == NULL)