patches/binutils/2.17/180-psignal.patch
author "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
Thu Jul 28 22:09:31 2011 +0200 (2011-07-28)
changeset 2573 424fa2092ace
parent 745 e445c00d134d
permissions -rw-r--r--
scripts/libc: do not build add-ons by default

Currently, no --enable-add-ons option is passed to libc configure when
"$(do_libc_add_ons_list ,)" is empty, which makes configure automatically search
for present add-ons. In that case, all present add-ons are built, although
no add-on was selected by the user in the config. Moreover, this can make the
configure fail if some non-standard add-ons like eglibc-localedef are present.

This behavior also leads to an inconsistency from a user point of view between
the following cases:
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS="none" in the config,
which makes "$(do_libc_add_ons_list ,)" return "", so all present add-ons
are built.
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS!="none" in the
config, which makes "$(do_libc_add_ons_list ,)" return the add-on supporting
the chosen threading implementation, e.g. "nptl", so only this add-on is
built.

This patch disables the building of all add-ons in that case.

It is still possible to build all present add-ons by adding --enable-add-ons to
LIBC_GLIBC_EXTRA_CONFIG_ARRAY.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
yann@56
     1
Make psignal prototype in libiberty match that in glibc.
yann@56
     2
yann@56
     3
Fixes:
yann@56
     4
yann@56
     5
gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c: In function `psignal':
yann@56
     6
gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c:563: argument `signo' doesn't match prototype
yann@56
     7
/usr/include/signal.h:131: prototype declaration
yann@56
     8
gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c:563: argument `message' doesn't match prototype
yann@56
     9
/usr/include/signal.h:131: prototype declaration
yann@56
    10
gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c:568: warning: comparison between signed and unsigned
yann@56
    11
mprotect... make[1]: *** [strsignal.o] Error 1
yann@56
    12
make[1]: Leaving directory `/export/hda3/dkegel/queue/jobdir.produser_cpsm17/crosstool-0.32/build/i686-unknown-linux-gnu/gcc-2.95.3-glibc-2.1.3/build-binutils/libiberty'
yann@56
    13
make: *** [all-libiberty] Error 2
yann@56
    14
yann@56
    15
when building on red hat 7.1
yann@56
    16
though it's a bit of a mystery why libiberty's psignal is being compiled at
yann@56
    17
all, since red hat 7.1's glibc supports psignal (hence the error message)
yann@56
    18
yann@56
    19
--- binutils-2.17/libiberty/strsignal.c.old	2005-04-18 13:57:40.000000000 -0700
yann@56
    20
+++ binutils-2.17/libiberty/strsignal.c	2005-04-18 13:59:09.000000000 -0700
yann@56
    21
@@ -536,7 +536,7 @@
yann@56
    22
 
yann@56
    23
 /*
yann@56
    24
 
yann@56
    25
-@deftypefn Supplemental void psignal (unsigned @var{signo}, char *@var{message})
yann@56
    26
+@deftypefn Supplemental void psignal (int @var{signo}, const char *@var{message})
yann@56
    27
 
yann@56
    28
 Print @var{message} to the standard error, followed by a colon,
yann@56
    29
 followed by the description of the signal specified by @var{signo},