patches/binutils/2.16.1/110-psignal.patch
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Tue Aug 31 23:24:40 2010 +0200 (2010-08-31)
branch1.8
changeset 2108 68d038933dc4
parent 402 197e1b49586e
permissions -rw-r--r--
binutils/binutils: remove faulty patch

The added code should be conditinal to the target system
being !MIPS, but is based on the host system being !MIPS.

This is plain wrong, and had not been noticed until now
as I never used those binutils versions on MIPS.

See:
http://sourceware.org/ml/crossgcc/2010-08/msg00192.html

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
(transplanted from f5ab0a80e46616adb3619cc7c5d78d0ccd7ea697)
yann@402
     1
Make psignal prototype in libiberty match that in glibc.
yann@402
     2
yann@402
     3
Fixes:
yann@402
     4
yann@402
     5
gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c: In function `psignal':
yann@402
     6
gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c:563: argument `signo' doesn't match prototype
yann@402
     7
/usr/include/signal.h:131: prototype declaration
yann@402
     8
gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c:563: argument `message' doesn't match prototype
yann@402
     9
/usr/include/signal.h:131: prototype declaration
yann@402
    10
gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c:568: warning: comparison between signed and unsigned
yann@402
    11
mprotect... make[1]: *** [strsignal.o] Error 1
yann@402
    12
make[1]: Leaving directory `/export/hda3/dkegel/queue/jobdir.produser_cpsm17/crosstool-0.32/build/i686-unknown-linux-gnu/gcc-2.95.3-glibc-2.1.3/build-binutils/libiberty'
yann@402
    13
make: *** [all-libiberty] Error 2
yann@402
    14
yann@402
    15
when building on red hat 7.1
yann@402
    16
though it's a bit of a mystery why libiberty's psignal is being compiled at
yann@402
    17
all, since red hat 7.1's glibc supports psignal (hence the error message)
yann@402
    18
yann@402
    19
--- binutils-2.15/libiberty/strsignal.c.old	2005-04-18 13:57:40.000000000 -0700
yann@402
    20
+++ binutils-2.15/libiberty/strsignal.c	2005-04-18 13:59:09.000000000 -0700
yann@402
    21
@@ -544,7 +544,7 @@
yann@402
    22
 
yann@402
    23
 /*
yann@402
    24
 
yann@402
    25
-@deftypefn Supplemental void psignal (unsigned @var{signo}, char *@var{message})
yann@402
    26
+@deftypefn Supplemental void psignal (int @var{signo}, const char *@var{message})
yann@402
    27
 
yann@402
    28
 Print @var{message} to the standard error, followed by a colon,
yann@402
    29
 followed by the description of the signal specified by @var{signo},
yann@402
    30
@@ -557,9 +557,7 @@
yann@402
    31
 #ifndef HAVE_PSIGNAL
yann@402
    32
 
yann@402
    33
 void
yann@402
    34
-psignal (signo, message)
yann@402
    35
-  unsigned signo;
yann@402
    36
-  char *message;
yann@402
    37
+psignal (int signo, const char *message)
yann@402
    38
 {
yann@402
    39
   if (signal_names == NULL)
yann@402
    40
     {