patches/binutils/2.19/150-warn-textrel.patch
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Tue Jan 06 22:22:02 2009 +0000 (2009-01-06)
changeset 1130 78681fe5cdd1
permissions -rw-r--r--
Update all samples to the latest set of config options.
There might be some small issues here and there due to the split of CT_ExtractAndPatch.

/trunk/samples/x86_64-unknown-linux-gnu/crosstool.config | 14 11 3 0 ++++++++++---
/trunk/samples/sh4-unknown-linux-gnu/crosstool.config | 13 10 3 0 +++++++++---
/trunk/samples/armeb-unknown-linux-uclibc/crosstool.config | 10 7 3 0 ++++++---
/trunk/samples/arm-unknown-elf/crosstool.config | 8 4 4 0 +++---
/trunk/samples/arm-unknown-linux-gnueabi/crosstool.config | 14 11 3 0 ++++++++++---
/trunk/samples/armeb-unknown-eabi/crosstool.config | 8 4 4 0 +++---
/trunk/samples/ia64-unknown-linux-gnu/crosstool.config | 13 10 3 0 +++++++++---
/trunk/samples/x86_64-unknown-linux-uclibc/crosstool.config | 11 8 3 0 +++++++---
/trunk/samples/armeb-unknown-linux-gnueabi/crosstool.config | 14 11 3 0 ++++++++++---
/trunk/samples/powerpc-e500v2-linux-gnuspe/crosstool.config | 11 8 3 0 +++++++---
/trunk/samples/i686-nptl-linux-gnu/crosstool.config | 14 11 3 0 ++++++++++---
/trunk/samples/powerpc-unknown-linux-gnu/crosstool.config | 14 11 3 0 ++++++++++---
/trunk/samples/arm-unknown-linux-gnu/crosstool.config | 14 11 3 0 ++++++++++---
/trunk/samples/mips-unknown-linux-uclibc/crosstool.config | 10 7 3 0 ++++++---
/trunk/samples/arm-unknown-linux-uclibcgnueabi/crosstool.config | 11 8 3 0 +++++++---
/trunk/samples/arm-iphone-linux-gnueabi/crosstool.config | 5 2 3 0 ++---
/trunk/samples/armeb-unknown-linux-gnu/crosstool.config | 14 11 3 0 ++++++++++---
/trunk/samples/powerpc-unknown_nofpu-linux-gnu/crosstool.config | 14 11 3 0 ++++++++++---
/trunk/samples/powerpc-unknown-linux-uclibc/crosstool.config | 10 7 3 0 ++++++---
/trunk/samples/arm-unknown-linux-uclibc/crosstool.config | 11 8 3 0 +++++++---
/trunk/samples/i586-geode-linux-uclibc/crosstool.config | 11 8 3 0 +++++++---
/trunk/samples/powerpc-405-linux-gnu/crosstool.config | 14 11 3 0 ++++++++++---
/trunk/samples/mips-unknown-elf/crosstool.config | 8 4 4 0 +++---
/trunk/samples/armeb-unknown-linux-uclibcgnueabi/crosstool.config | 11 8 3 0 +++++++---
/trunk/samples/mipsel-unknown-linux-gnu/crosstool.config | 13 10 3 0 +++++++++---
/trunk/samples/arm-unknown-eabi/crosstool.config | 8 4 4 0 +++---
/trunk/samples/alphaev56-unknown-linux-gnu/crosstool.config | 14 11 3 0 ++++++++++---
/trunk/samples/powerpc-860-linux-gnu/crosstool.config | 13 10 3 0 +++++++++---
28 files changed, 237 insertions(+), 88 deletions(-)
yann@1069
     1
Original patch from Gentoo:
yann@1069
     2
gentoo/src/patchsets/binutils/2.19/66_all_binutils-2.18.50.0.2-warn-textrel.patch
yann@1069
     3
yann@1069
     4
textrels are bad for forcing copy-on-write (this affects everyone),
yann@1069
     5
and for security/runtime code generation, this affects security ppl.
yann@1069
     6
But in either case, it doesn't matter who needs textrels, it's
yann@1069
     7
the very fact that they're needed at all.
yann@1069
     8
yann@1069
     9
diff -durN binutils-2.19.orig/bfd/elflink.c binutils-2.19/bfd/elflink.c
yann@1069
    10
--- binutils-2.19.orig/bfd/elflink.c	2008-11-23 16:49:47.000000000 +0100
yann@1069
    11
+++ binutils-2.19/bfd/elflink.c	2008-11-23 16:49:14.000000000 +0100
yann@1069
    12
@@ -10820,14 +10820,12 @@
yann@1069
    13
 	goto error_return;
yann@1069
    14
 
yann@1069
    15
       /* Check for DT_TEXTREL (late, in case the backend removes it).  */
yann@1069
    16
-      if (info->warn_shared_textrel && info->shared)
yann@1069
    17
+      o = bfd_get_section_by_name (dynobj, ".dynamic");
yann@1069
    18
+      if (info->warn_shared_textrel && o != NULL)
yann@1069
    19
 	{
yann@1069
    20
 	  bfd_byte *dyncon, *dynconend;
yann@1069
    21
 
yann@1069
    22
 	  /* Fix up .dynamic entries.  */
yann@1069
    23
-	  o = bfd_get_section_by_name (dynobj, ".dynamic");
yann@1069
    24
-	  BFD_ASSERT (o != NULL);
yann@1069
    25
-
yann@1069
    26
 	  dyncon = o->contents;
yann@1069
    27
 	  dynconend = o->contents + o->size;
yann@1069
    28
 	  for (; dyncon < dynconend; dyncon += bed->s->sizeof_dyn)
yann@1069
    29
@@ -10839,7 +10837,7 @@
yann@1069
    30
 	      if (dyn.d_tag == DT_TEXTREL)
yann@1069
    31
 		{
yann@1069
    32
 		 info->callbacks->einfo
yann@1069
    33
-		    (_("%P: warning: creating a DT_TEXTREL in a shared object.\n"));
yann@1069
    34
+		    (_("%P: warning: creating a DT_TEXTREL in object.\n"));
yann@1069
    35
 		  break;
yann@1069
    36
 		}
yann@1069
    37
 	    }
yann@1069
    38
diff -durN binutils-2.19.orig/ld/ldmain.c binutils-2.19/ld/ldmain.c
yann@1069
    39
--- binutils-2.19.orig/ld/ldmain.c	2008-08-17 05:12:50.000000000 +0200
yann@1069
    40
+++ binutils-2.19/ld/ldmain.c	2008-11-23 16:52:37.000000000 +0100
yann@1069
    41
@@ -274,6 +274,7 @@
yann@1069
    42
   link_info.relax_pass = 1;
yann@1069
    43
   link_info.pei386_auto_import = -1;
yann@1069
    44
   link_info.spare_dynamic_tags = 5;
yann@1069
    45
+  link_info.warn_shared_textrel = TRUE;
yann@1069
    46
   link_info.path_separator = ':';
yann@1069
    47
 
yann@1069
    48
   ldfile_add_arch ("");