patches/gcc/4.4.0/140-default-format-security.patch
author "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
Wed Jun 08 15:47:43 2011 +0200 (2011-06-08)
changeset 2508 9e2761e59a75
permissions -rw-r--r--
debug/cross-gdb: check host dependencies

Cross-gdb depends on expat and python. If either is missing, cross-gdb will
build successfully, but lacking some features.

Especially, if expat is missing, cross-gdb will be unable to parse the target
description, which may lead to runtime malfunctions and the following GDB
warning:
"Can not parse XML target description; XML support was disabled at compile time"

Hence, expat should be considered mandatory.

On the other hand, the features missing without python are not critical, so
python should not be considered mandatory.

This patch does the following:
- At configure time, warn the user if either expat or python is missing.
- In menuconfig, disable the static build options regarding cross-gdb if no
static version of expat is available, and disable cross-gdb if expat is
missing.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
[yann.morin.1998@anciens.enib.fr: add comment for impossible static cross-gdb]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
yann@1393
     1
diff -durN gcc-4.4.0.orig/gcc/c-common.c gcc-4.4.0/gcc/c-common.c
yann@1393
     2
--- gcc-4.4.0.orig/gcc/c-common.c	2009-03-30 19:42:27.000000000 +0200
yann@1393
     3
+++ gcc-4.4.0/gcc/c-common.c	2009-05-27 21:38:08.000000000 +0200
yann@1393
     4
@@ -301,7 +301,7 @@
yann@1393
     5
 /* Warn about format/argument anomalies in calls to formatted I/O functions
yann@1393
     6
    (*printf, *scanf, strftime, strfmon, etc.).  */
yann@1393
     7
 
yann@1393
     8
-int warn_format;
yann@1393
     9
+int warn_format = 1;
yann@1393
    10
 
yann@1393
    11
 /* Warn about using __null (as NULL in C++) as sentinel.  For code compiled
yann@1393
    12
    with GCC this doesn't matter as __null is guaranteed to have the right
yann@1393
    13
diff -durN gcc-4.4.0.orig/gcc/c.opt gcc-4.4.0/gcc/c.opt
yann@1393
    14
--- gcc-4.4.0.orig/gcc/c.opt	2009-03-18 22:14:53.000000000 +0100
yann@1393
    15
+++ gcc-4.4.0/gcc/c.opt	2009-05-27 21:38:08.000000000 +0200
yann@1393
    16
@@ -236,7 +236,7 @@
yann@1393
    17
 Warn about format strings that contain NUL bytes
yann@1393
    18
 
yann@1393
    19
 Wformat-security
yann@1393
    20
-C ObjC C++ ObjC++ Var(warn_format_security) Warning
yann@1393
    21
+C ObjC C++ ObjC++ Var(warn_format_security) Init(1) Warning
yann@1393
    22
 Warn about possible security problems with format functions
yann@1393
    23
 
yann@1393
    24
 Wformat-y2k
yann@1393
    25
diff -durN gcc-4.4.0.orig/gcc/doc/invoke.texi gcc-4.4.0/gcc/doc/invoke.texi
yann@1393
    26
--- gcc-4.4.0.orig/gcc/doc/invoke.texi	2009-04-01 09:18:47.000000000 +0200
yann@1393
    27
+++ gcc-4.4.0/gcc/doc/invoke.texi	2009-05-27 21:38:08.000000000 +0200
yann@1393
    28
@@ -2867,6 +2867,9 @@
yann@1393
    29
 @option{-Wformat-nonliteral}, @option{-Wformat-security}, and
yann@1393
    30
 @option{-Wformat=2} are available, but are not included in @option{-Wall}.
yann@1393
    31
 
yann@1393
    32
+NOTE: In Gentoo, this option is enabled by default for C, C++, ObjC, ObjC++.
yann@1393
    33
+To disable, use @option{-Wformat=0}.
yann@1393
    34
+
yann@1393
    35
 @item -Wformat-y2k
yann@1393
    36
 @opindex Wformat-y2k
yann@1393
    37
 @opindex Wno-format-y2k
yann@1393
    38
@@ -2920,6 +2923,11 @@
yann@1393
    39
 in future warnings may be added to @option{-Wformat-security} that are not
yann@1393
    40
 included in @option{-Wformat-nonliteral}.)
yann@1393
    41
 
yann@1393
    42
+NOTE: In Gentoo, this option is enabled by default for C, C++, ObjC, ObjC++.
yann@1393
    43
+To disable, use @option{-Wno-format-security}, or disable all format warnings
yann@1393
    44
+with @option{-Wformat=0}.  To make format security warnings fatal, specify
yann@1393
    45
+@option{-Werror=format-security}.
yann@1393
    46
+
yann@1393
    47
 @item -Wformat=2
yann@1393
    48
 @opindex Wformat=2
yann@1393
    49
 @opindex Wno-format=2