patches/glibc/ports-2.10.1/300-nscd-one-fork.patch
author "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
Fri Jan 27 13:31:16 2012 +0100 (2012-01-27)
changeset 2854 a70abdbfa342
permissions -rw-r--r--
complibs/cloog: fix linking with libm

In Ubuntu 11.04 and 11.10, the default options for ld have changed.
--no-copy-dt-needed-entries and --as-needed are now enabled by default, which
causes errors like:

[EXTRA] Checking CLooG/ppl
[DEBUG] ==> Executing: 'make' '-j3' '-s' 'check'
[ALL ] Making check in .
[ALL ] config.status: creating include/cloog/cloog-config.h
[ALL ] config.status: include/cloog/cloog-config.h is unchanged
[ALL ] libtool: link: i686-build_pc-linux-gnu-gcc -Wall -fomit-frame-pointer
-pipe -o cloog cloog.o -L/<snip>/build/static/lib ./.libs/libcloog.a -lm
/<snip>/build/static/lib/libppl_c.a /<snip>/build/static/lib/libpwl.a
/<snip>/build/static/lib/libppl.a /<snip>/build/static/lib/libgmpxx.a
/<snip>/build/static/lib/libgmp.a -lstdc++
[ALL ] /usr/bin/ld: /<snip>/build/static/lib/libppl.a(MIP_Problem.o):
undefined reference to symbol 'sqrt@@GLIBC_2.0'
[ALL ] /usr/bin/ld: note: 'sqrt@@GLIBC_2.0' is defined in DSO
/usr/lib/gcc/i686-linux-gnu/4.6.1/../../../i386-linux-gnu/libm.so so try adding
it to the linker command line
[ALL ] /usr/lib/gcc/i686-linux-gnu/4.6.1/../../../i386-linux-gnu/libm.so:
could not read symbols: Invalid operation
[ALL ] collect2: ld returned 1 exit status
[ERROR] make[2]: *** [cloog] Error 1
[ERROR] make[1]: *** [check-recursive] Error 1

See:
https://wiki.ubuntu.com/NattyNarwhal/ToolchainTransition

This patch fixes these errors by placing '-lm' at the right place on the command
line as libppl requires libm when linking cloog.

Signed-off-by: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
yann@1625
     1
only fork one to assist in stop-start-daemon assumptions about daemon behavior
yann@1625
     2
yann@1625
     3
http://bugs.gentoo.org/190785
yann@1625
     4
yann@1625
     5
diff -durN glibc-2.10.1.orig/nscd/nscd.c glibc-2.10.1/nscd/nscd.c
yann@1625
     6
--- glibc-2.10.1.orig/nscd/nscd.c	2009-02-06 21:10:27.000000000 +0100
yann@1625
     7
+++ glibc-2.10.1/nscd/nscd.c	2009-11-13 00:50:24.000000000 +0100
yann@1625
     8
@@ -182,6 +182,9 @@
yann@1625
     9
       if (pid != 0)
yann@1625
    10
 	exit (0);
yann@1625
    11
 
yann@1625
    12
+       if (write_pid (_PATH_NSCDPID) < 0)
yann@1625
    13
+	dbg_log ("%s: %s", _PATH_NSCDPID, strerror (errno));
yann@1625
    14
+
yann@1625
    15
       int nullfd = open (_PATH_DEVNULL, O_RDWR);
yann@1625
    16
       if (nullfd != -1)
yann@1625
    17
 	{
yann@1625
    18
@@ -231,12 +234,6 @@
yann@1625
    19
 	for (i = min_close_fd; i < getdtablesize (); i++)
yann@1625
    20
 	  close (i);
yann@1625
    21
 
yann@1625
    22
-      pid = fork ();
yann@1625
    23
-      if (pid == -1)
yann@1625
    24
-	error (EXIT_FAILURE, errno, _("cannot fork"));
yann@1625
    25
-      if (pid != 0)
yann@1625
    26
-	exit (0);
yann@1625
    27
-
yann@1625
    28
       setsid ();
yann@1625
    29
 
yann@1625
    30
       if (chdir ("/") != 0)
yann@1625
    31
@@ -245,9 +242,6 @@
yann@1625
    32
 
yann@1625
    33
       openlog ("nscd", LOG_CONS | LOG_ODELAY, LOG_DAEMON);
yann@1625
    34
 
yann@1625
    35
-      if (write_pid (_PATH_NSCDPID) < 0)
yann@1625
    36
-        dbg_log ("%s: %s", _PATH_NSCDPID, strerror (errno));
yann@1625
    37
-
yann@1625
    38
       if (!init_logfile ())
yann@1625
    39
 	dbg_log (_("Could not create log file"));
yann@1625
    40