| author | "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> |
| Tue Aug 02 18:28:10 2011 +0200 (2011-08-02) | |
| changeset 2590 | b64cfb67944e |
| permissions | -rw-r--r-- |
| yann@2438 | 1 |
revert cfi additions to clone on i386/x86_64 to workaround problems in |
| yann@2438 | 2 |
gcc's unwinder code. this is not a bug in glibc, it triggers problems |
| yann@2438 | 3 |
elsewhere. this cfi code does not gain us a whole lot anyways. |
| yann@2438 | 4 |
|
| yann@2438 | 5 |
http://gcc.gnu.org/ml/gcc/2006-12/msg00293.html |
| yann@2438 | 6 |
|
| yann@2438 | 7 |
Index: sysdeps/unix/sysv/linux/i386/clone.S |
| yann@2438 | 8 |
=================================================================== |
| yann@2438 | 9 |
RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/i386/clone.S,v |
| yann@2438 | 10 |
retrieving revision 1.27 |
| yann@2438 | 11 |
retrieving revision 1.26 |
| yann@2438 | 12 |
diff -u -p -r1.27 -r1.26 |
| yann@2438 | 13 |
|
| yann@2438 | 14 |
diff -durN glibc-2.13.orig/sysdeps/unix/sysv/linux/i386/clone.S glibc-2.13/sysdeps/unix/sysv/linux/i386/clone.S |
| yann@2438 | 15 |
--- glibc-2.13.orig/sysdeps/unix/sysv/linux/i386/clone.S 2006-12-04 00:12:36.000000000 +0100 |
| yann@2438 | 16 |
+++ glibc-2.13/sysdeps/unix/sysv/linux/i386/clone.S 2009-11-13 00:49:45.000000000 +0100 |
| yann@2438 | 17 |
@@ -120,9 +120,6 @@ |
| yann@2438 | 18 |
ret |
| yann@2438 | 19 |
|
| yann@2438 | 20 |
L(thread_start): |
| yann@2438 | 21 |
- cfi_startproc; |
| yann@2438 | 22 |
- /* Clearing frame pointer is insufficient, use CFI. */ |
| yann@2438 | 23 |
- cfi_undefined (eip); |
| yann@2438 | 24 |
/* Note: %esi is zero. */ |
| yann@2438 | 25 |
movl %esi,%ebp /* terminate the stack frame */ |
| yann@2438 | 26 |
#ifdef RESET_PID |
| yann@2438 | 27 |
@@ -155,7 +152,6 @@ |
| yann@2438 | 28 |
jmp L(haspid) |
| yann@2438 | 29 |
.previous |
| yann@2438 | 30 |
#endif |
| yann@2438 | 31 |
- cfi_endproc; |
| yann@2438 | 32 |
|
| yann@2438 | 33 |
cfi_startproc |
| yann@2438 | 34 |
PSEUDO_END (BP_SYM (__clone)) |
| yann@2438 | 35 |
diff -durN glibc-2.13.orig/sysdeps/unix/sysv/linux/x86_64/clone.S glibc-2.13/sysdeps/unix/sysv/linux/x86_64/clone.S |
| yann@2438 | 36 |
--- glibc-2.13.orig/sysdeps/unix/sysv/linux/x86_64/clone.S 2006-12-04 00:12:36.000000000 +0100 |
| yann@2438 | 37 |
+++ glibc-2.13/sysdeps/unix/sysv/linux/x86_64/clone.S 2009-11-13 00:49:45.000000000 +0100 |
| yann@2438 | 38 |
@@ -89,9 +89,6 @@ |
| yann@2438 | 39 |
ret |
| yann@2438 | 40 |
|
| yann@2438 | 41 |
L(thread_start): |
| yann@2438 | 42 |
- cfi_startproc; |
| yann@2438 | 43 |
- /* Clearing frame pointer is insufficient, use CFI. */ |
| yann@2438 | 44 |
- cfi_undefined (rip); |
| yann@2438 | 45 |
/* Clear the frame pointer. The ABI suggests this be done, to mark |
| yann@2438 | 46 |
the outermost frame obviously. */ |
| yann@2438 | 47 |
xorl %ebp, %ebp |
| yann@2438 | 48 |
@@ -116,7 +113,6 @@ |
| yann@2438 | 49 |
/* Call exit with return value from function call. */ |
| yann@2438 | 50 |
movq %rax, %rdi |
| yann@2438 | 51 |
call HIDDEN_JUMPTARGET (_exit) |
| yann@2438 | 52 |
- cfi_endproc; |
| yann@2438 | 53 |
|
| yann@2438 | 54 |
cfi_startproc; |
| yann@2438 | 55 |
PSEUDO_END (BP_SYM (__clone)) |