patches/binutils/2.20.1a/290-ld-stub-crash.patch
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Tue Dec 13 23:32:39 2011 +0100 (2011-12-13)
branch1.13
changeset 2847 c0bf2319af08
parent 2088 4f21ba5f8e91
permissions -rw-r--r--
scripts: fix dumping execution backtrace

Dumping the backtrace has been broken since changeset #652e56d6d35a:
scripts: execute each steps in a subshell

We can spawn sub-sub-shells in some cases.

The way the fault handler works is to dump the backtrace, but to avoid
printing it once for every sub-shell (which could get quite confusing),
it simply exits when it detects that it is being run in a sub-shell,
leaving to the top-level shell the work to dump the backtrace.

Because each step is executed in its own sub-shell, the variable arrays
that contain the step name, the source file and line number, are lost
when exiting the per-step sub-shell.

Hence, the backtrace is currently limited to printing only the top-level
main procedure of the shell.

Fix this thus:
- when dumping the bckatraces for the steps & the functions, remember
it was dumped, and only dump it if it was not already dumped
- at the top-level shell, print the hints

Also, rename the top-level step label.

Reported-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
(transplanted from 4193d6e6a17430a177fa88c287879c2c35e319f3)
jocke@1700
     1
diff -p -c -u -r1.196 elf32-arm.c
yann@2088
     2
yann@2088
     3
diff -durN binutils-2.20.1.orig/bfd/elf32-arm.c binutils-2.20.1/bfd/elf32-arm.c
yann@2088
     4
--- binutils-2.20.1.orig/bfd/elf32-arm.c	2010-02-22 09:06:48.000000000 +0100
yann@2088
     5
+++ binutils-2.20.1/bfd/elf32-arm.c	2010-08-17 19:32:25.000000000 +0200
yann@2088
     6
@@ -3194,11 +3194,15 @@
jocke@1700
     7
 
jocke@1700
     8
 	  /* We have an extra 2-bytes reach because of
jocke@1700
     9
 	     the mode change (bit 24 (H) of BLX encoding).  */
jocke@1700
    10
+	  /* A stub is needed only if this call is not throught a PLT
jocke@1700
    11
+	     entry, because PLT stubs handle mode switching
jocke@1700
    12
+	     already.  */
jocke@1700
    13
 	  if (branch_offset > (ARM_MAX_FWD_BRANCH_OFFSET + 2)
jocke@1700
    14
 	      || (branch_offset < ARM_MAX_BWD_BRANCH_OFFSET)
jocke@1700
    15
-	      || ((r_type == R_ARM_CALL) && !globals->use_blx)
jocke@1700
    16
-	      || (r_type == R_ARM_JUMP24)
jocke@1700
    17
-	      || (r_type == R_ARM_PLT32))
jocke@1700
    18
+	      || ( (((r_type == R_ARM_CALL) && !globals->use_blx)
jocke@1700
    19
+		    || (r_type == R_ARM_JUMP24)
jocke@1700
    20
+		    || (r_type == R_ARM_PLT32))
jocke@1700
    21
+		   && !use_plt))
jocke@1700
    22
 	    {
jocke@1700
    23
 	      stub_type = (info->shared | globals->pic_veneer)
jocke@1700
    24
 		/* PIC stubs.  */