patches/glibc/2.3.6/260-csu-Makefile.patch
author Zoltan Devai <zdevai@gmail.com>
Wed Oct 28 12:03:38 2009 +0100 (2009-10-28)
branch1.5
changeset 1645 01d01185eb18
parent 495 276501e872e5
permissions -rw-r--r--
libc/uClibc: fix building on system with recent glibc

While trying to build a toolchain with ct-ng 1.5.0,
arm-unknown-linux-uclibcgnueabi target,
I get the following error:

[INFO ] Installing C library headers
[EXTRA] Copying sources to build dir
[EXTRA] Applying configuration
[EXTRA] Building headers
[EXTRA] Installing headers
[ERROR] extra/scripts/unifdef.c:209: error: conflicting types for 'getline'
[ERROR] make[2]: *** [extra/scripts/unifdef] Error 1
[ERROR] Build failed in step 'Installing C library headers'

The following patch solves the problem.
(It's a backport of this uClibc commit:
http://git.uclibc.org/uClibc/commit/?id=49e81cada73616864b9b31df0aeb6961c30f5a6e
)

[--SNIP from another mail--]
AFAIK this is a problem since glibc 2.10.
(transplanted from 1ba79f2126df8bd89120899a58f2d0bcc2e9c771)
     1 Use printf instead of echo for some shells.
     2 
     3 http://www.cygwin.com/ml/libc-alpha/2005-02/msg00123.html
     4 
     5 This patch does not generate invalid csu/version-info.h which has
     6 unterminating " line because some /bin/sh cannot parse correctly.  The
     7 previous discussion was:
     8 
     9 	http://sources.redhat.com/ml/libc-alpha/2004-08/msg00129.html
    10 	http://sources.redhat.com/ml/libc-alpha/2004-08/msg00145.html
    11 
    12 This patch gets rid of all this issue because the conclusion of the
    13 discussion was to use printf instead of echo.  Roland, could you look
    14 at it again?
    15 
    16 Regards,
    17 -- gotom
    18 
    19 2005-02-26  GOTO Masanori  <gotom@debian.or.jp>
    20 
    21 	* csu/Makefile: Use printf instead of echo for some shells.
    22 
    23 Index: csu/Makefile
    24 ===================================================================
    25 RCS file: /cvs/glibc/libc/csu/Makefile,v
    26 retrieving revision 1.75
    27 diff -u -p -r1.75 Makefile
    28 --- glibc/csu/Makefile	3 Jan 2005 17:57:14 -0000	1.75
    29 +++ glibc.new/csu/Makefile	27 Feb 2005 01:17:49 -0000
    30 @@ -241,7 +241,7 @@ $(objpfx)version-info.h: $(common-objpfx
    31  	 esac; \
    32  	 files="$(all-Banner-files)";				\
    33  	 if test -n "$$files"; then				\
    34 -	   echo "\"Available extensions:\\n\"";			\
    35 +	   printf '"Available extensions:\\n"\n';		\
    36  	   sed -e '/^#/d' -e 's/^[[:space:]]*/	/'		\
    37  	       -e 's/^\(.*\)$$/\"\1\\n\"/' $$files;		\
    38  	 fi) > $@T
    39