patches/gdb/6.7.1/120-deleted-children.patch
author Zoltan Devai <zdevai@gmail.com>
Wed Oct 28 12:03:38 2009 +0100 (2009-10-28)
changeset 1602 1ba79f2126df
parent 746 b150d6f590fc
permissions -rw-r--r--
libc/uClibc: fix building on system with recent glibc

While trying to build a toolchain with ct-ng 1.5.0,
arm-unknown-linux-uclibcgnueabi target,
I get the following error:

[INFO ] Installing C library headers
[EXTRA] Copying sources to build dir
[EXTRA] Applying configuration
[EXTRA] Building headers
[EXTRA] Installing headers
[ERROR] extra/scripts/unifdef.c:209: error: conflicting types for 'getline'
[ERROR] make[2]: *** [extra/scripts/unifdef] Error 1
[ERROR] Build failed in step 'Installing C library headers'

The following patch solves the problem.
(It's a backport of this uClibc commit:
http://git.uclibc.org/uClibc/commit/?id=49e81cada73616864b9b31df0aeb6961c30f5a6e
)

[--SNIP from another mail--]
AFAIK this is a problem since glibc 2.10.
     1 Original patch from gentoo: gentoo/src/patchsets/gdb/6.7.1/50_all_gdb-deleted-children.patch
     2 -= BEGIN original header =-
     3 http://bugs.gentoo.org/210636
     4 http://sourceware.org/ml/gdb-patches/2007-11/msg00136.html
     5 
     6 2007-11-07  Vladimir Prus  <vladimir@codesourcery.com>
     7 
     8 	Fix crash when a variable object being deleted
     9 	has any of its children deleted previously.
    10 	
    11 	* varobj.c (delete_variable_1): Don't recurse
    12 	into deleted children.
    13 
    14 -= END original header =-
    15 diff -durN gdb-6.7.1.orig/gdb/varobj.c gdb-6.7.1/gdb/varobj.c
    16 --- gdb-6.7.1.orig/gdb/varobj.c	2007-08-31 21:01:17.000000000 +0200
    17 +++ gdb-6.7.1/gdb/varobj.c	2008-06-17 23:27:45.000000000 +0200
    18 @@ -1295,6 +1295,8 @@
    19    for (i = 0; i < VEC_length (varobj_p, var->children); ++i)
    20      {   
    21        varobj_p child = VEC_index (varobj_p, var->children, i);
    22 +      if (!child)
    23 +	continue;
    24        if (!remove_from_parent_p)
    25  	child->parent = NULL;
    26        delete_variable_1 (resultp, delcountp, child, 0, only_children_p);