patches/gcc/4.4.3/140-default-format-security.patch
author "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
Wed Dec 14 16:55:22 2011 +0100 (2011-12-14)
branch1.13
changeset 2848 1ff89596dab0
parent 1611 e2516bba8fe5
permissions -rw-r--r--
libc/eglibc: fix localedef 2.14 build

The localedef of eglibc 2.14 requires NOT_IN_libc to be defined in order to
compile intl/l10nflist.c.

This is because localedef is built separately from eglibc and uses some parts of
eglibc that don't compile in standalone without this preprocessor definition.

This fixes the following error:

[ALL ] gcc -g -O2 -DNO_SYSCONF -DNO_UNCOMPRESS
-DLOCALE_PATH='"/usr/lib/locale:/usr/share/i18n"'
-DLOCALEDIR='"/usr/lib/locale"' -DLOCALE_ALIAS_PATH='"/usr/share/locale"'
-DCHARMAP_PATH='"/usr/share/i18n/charmaps"'
-DREPERTOIREMAP_PATH='"/usr/share/i18n/repertoiremaps"'
-DLOCSRCDIR='"/usr/share/i18n/locales"' -Iglibc/locale/programs -Iglibc/locale
-I/<snip>/.build/src/eglibc-localedef-2_14/include
-I/<snip>/.build/src/eglibc-localedef-2_14 -I.
-include /<snip>/.build/src/eglibc-localedef-2_14/include/always.h -Wall
-Wno-format -c -o locarchive.o glibc/locale/programs/locarchive.c
[ALL ] glibc/locale/programs/locarchive.c: In function 'enlarge_archive':
[ALL ] glibc/locale/programs/locarchive.c:303:21: warning: variable
'oldlocrectab' set but not used [-Wunused-but-set-variable]
[ALL ] In file included from glibc/locale/programs/locarchive.c:651:0:
[ALL ] glibc/locale/programs/../../intl/l10nflist.c: In function
'_nl_normalize_codeset':
[ERROR] glibc/locale/programs/../../intl/l10nflist.c:342:9: error:
'_nl_C_locobj_ptr' undeclared (first use in this function)
[ALL ] glibc/locale/programs/../../intl/l10nflist.c:342:9: note: each
undeclared identifier is reported only once for each function it appears in
[ALL ] glibc/locale/programs/locarchive.c: In function
'add_locales_to_archive':
[ALL ] glibc/locale/programs/locarchive.c:1450:7: warning: passing argument
1 of '__xpg_basename' discards 'const' qualifier from pointer target type
[enabled by default]
[ALL ] /usr/include/libgen.h:35:14: note: expected 'char *' but argument is
of type 'const char *'
[ERROR] make[1]: *** [locarchive.o] Error 1

Signed-off-by: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
(transplanted from 4cd9134739b594451794cf61a6e1b137422cdafd)
     1 diff -durN gcc-4.4.0.orig/gcc/c-common.c gcc-4.4.0/gcc/c-common.c
     2 --- gcc-4.4.0.orig/gcc/c-common.c	2009-03-30 19:42:27.000000000 +0200
     3 +++ gcc-4.4.0/gcc/c-common.c	2009-05-27 21:38:08.000000000 +0200
     4 @@ -301,7 +301,7 @@
     5  /* Warn about format/argument anomalies in calls to formatted I/O functions
     6     (*printf, *scanf, strftime, strfmon, etc.).  */
     7  
     8 -int warn_format;
     9 +int warn_format = 1;
    10  
    11  /* Warn about using __null (as NULL in C++) as sentinel.  For code compiled
    12     with GCC this doesn't matter as __null is guaranteed to have the right
    13 diff -durN gcc-4.4.0.orig/gcc/c.opt gcc-4.4.0/gcc/c.opt
    14 --- gcc-4.4.0.orig/gcc/c.opt	2009-03-18 22:14:53.000000000 +0100
    15 +++ gcc-4.4.0/gcc/c.opt	2009-05-27 21:38:08.000000000 +0200
    16 @@ -236,7 +236,7 @@
    17  Warn about format strings that contain NUL bytes
    18  
    19  Wformat-security
    20 -C ObjC C++ ObjC++ Var(warn_format_security) Warning
    21 +C ObjC C++ ObjC++ Var(warn_format_security) Init(1) Warning
    22  Warn about possible security problems with format functions
    23  
    24  Wformat-y2k
    25 diff -durN gcc-4.4.0.orig/gcc/doc/invoke.texi gcc-4.4.0/gcc/doc/invoke.texi
    26 --- gcc-4.4.0.orig/gcc/doc/invoke.texi	2009-04-01 09:18:47.000000000 +0200
    27 +++ gcc-4.4.0/gcc/doc/invoke.texi	2009-05-27 21:38:08.000000000 +0200
    28 @@ -2867,6 +2867,9 @@
    29  @option{-Wformat-nonliteral}, @option{-Wformat-security}, and
    30  @option{-Wformat=2} are available, but are not included in @option{-Wall}.
    31  
    32 +NOTE: In Gentoo, this option is enabled by default for C, C++, ObjC, ObjC++.
    33 +To disable, use @option{-Wformat=0}.
    34 +
    35  @item -Wformat-y2k
    36  @opindex Wformat-y2k
    37  @opindex Wno-format-y2k
    38 @@ -2920,6 +2923,11 @@
    39  in future warnings may be added to @option{-Wformat-security} that are not
    40  included in @option{-Wformat-nonliteral}.)
    41  
    42 +NOTE: In Gentoo, this option is enabled by default for C, C++, ObjC, ObjC++.
    43 +To disable, use @option{-Wno-format-security}, or disable all format warnings
    44 +with @option{-Wformat=0}.  To make format security warnings fatal, specify
    45 +@option{-Werror=format-security}.
    46 +
    47  @item -Wformat=2
    48  @opindex Wformat=2
    49  @opindex Wno-format=2