patches/glibc/ports-2.12.1/220-section-comments.patch
author "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
Thu Jul 28 22:09:31 2011 +0200 (2011-07-28)
changeset 2573 424fa2092ace
permissions -rw-r--r--
scripts/libc: do not build add-ons by default

Currently, no --enable-add-ons option is passed to libc configure when
"$(do_libc_add_ons_list ,)" is empty, which makes configure automatically search
for present add-ons. In that case, all present add-ons are built, although
no add-on was selected by the user in the config. Moreover, this can make the
configure fail if some non-standard add-ons like eglibc-localedef are present.

This behavior also leads to an inconsistency from a user point of view between
the following cases:
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS="none" in the config,
which makes "$(do_libc_add_ons_list ,)" return "", so all present add-ons
are built.
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS!="none" in the
config, which makes "$(do_libc_add_ons_list ,)" return the add-on supporting
the chosen threading implementation, e.g. "nptl", so only this add-on is
built.

This patch disables the building of all add-ons in that case.

It is still possible to build all present add-ons by adding --enable-add-ons to
LIBC_GLIBC_EXTRA_CONFIG_ARRAY.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
     1 http://sources.redhat.com/ml/binutils/2004-04/msg00665.html
     2 
     3 fixes building on some architectures (like m68k/arm/cris/etc...) because
     4 it does the right thing
     5 
     6 diff -durN glibc-2.12.1.orig/include/libc-symbols.h glibc-2.12.1/include/libc-symbols.h
     7 --- glibc-2.12.1.orig/include/libc-symbols.h	2009-03-14 00:51:46.000000000 +0100
     8 +++ glibc-2.12.1/include/libc-symbols.h	2009-11-13 00:50:07.000000000 +0100
     9 @@ -239,12 +239,12 @@
    10  #  define __make_section_unallocated(section_string)
    11  # endif
    12  
    13 -/* Tacking on "\n\t#" to the section name makes gcc put it's bogus
    14 +/* Tacking on "\n#APP\n\t#" to the section name makes gcc put it's bogus
    15     section attributes on what looks like a comment to the assembler.  */
    16  # ifdef HAVE_SECTION_QUOTES
    17 -#  define __sec_comment "\"\n\t#\""
    18 +#  define __sec_comment "\"\n#APP\n\t#\""
    19  # else
    20 -#  define __sec_comment "\n\t#"
    21 +#  define __sec_comment "\n#APP\n\t#"
    22  # endif
    23  # define link_warning(symbol, msg) \
    24    __make_section_unallocated (".gnu.warning." #symbol) \