crosstool-ng: patches/glibc/ports-2.12.1/230-no-inline-gmon.patch@424fa2092ace

scripts/libc: do not build add-ons by default

Currently, no --enable-add-ons option is passed to libc configure when
"$(do_libc_add_ons_list ,)" is empty, which makes configure automatically search
for present add-ons. In that case, all present add-ons are built, although
no add-on was selected by the user in the config. Moreover, this can make the
configure fail if some non-standard add-ons like eglibc-localedef are present.

This behavior also leads to an inconsistency from a user point of view between
the following cases:
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS="none" in the config,
which makes "$(do_libc_add_ons_list ,)" return "", so all present add-ons
are built.
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS!="none" in the
config, which makes "$(do_libc_add_ons_list ,)" return the add-on supporting
the chosen threading implementation, e.g. "nptl", so only this add-on is
built.

This patch disables the building of all add-ons in that case.

It is still possible to build all present add-ons by adding --enable-add-ons to
LIBC_GLIBC_EXTRA_CONFIG_ARRAY.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>

     1 http://bugs.gentoo.org/196245

     2 http://sourceware.org/ml/libc-alpha/2006-05/msg00017.html

     4 Attached is a patch to add __attribute__ ((noinline)) to

     5 call_gmon_start.

     7 Without this patch, the sec script that processed initfini.s removes a

     8 part of inlined call_gmon_start, causing undefined label errors.

    10 This patch solves the problem by forcing gcc not to inline

    11 call_gmon_start with __attribute__ ((noinline)).

    13 Tested by building for arm-none-lixux-gnueabi.  OK to apply?

    15 Kazu Hirata

    17 2006-05-07  Kazu Hirata  &lt;kazu@codesourcery.com&gt;

    19 	* sysdeps/generic/initfini.c (call_gmon_start): Add

    20 	__attribute__ ((noinline)).

    22 Index: sysdeps/generic/initfini.c

    23 ===================================================================

    25 diff -durN glibc-2.12.1.orig/sysdeps/generic/initfini.c glibc-2.12.1/sysdeps/generic/initfini.c

    26 --- glibc-2.12.1.orig/sysdeps/generic/initfini.c	2007-06-17 20:02:40.000000000 +0200

    27 +++ glibc-2.12.1/sysdeps/generic/initfini.c	2009-11-13 00:50:09.000000000 +0100

    28 @@ -70,7 +70,7 @@

    29  /* The beginning of _init:  */

    30  asm ("\n/*@_init_PROLOG_BEGINS*/");

    32 -static void

    33 +static void __attribute__ ((noinline))

    34  call_gmon_start(void)

    35  {

    36    extern void __gmon_start__ (void) __attribute__ ((weak)); /*weak_extern (__gmon_start__);*/

author	"Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
	Thu Jul 28 22:09:31 2011 +0200 (2011-07-28)
changeset 2573	424fa2092ace
permissions	-rw-r--r--