crosstool-ng: patches/uClibc/0.9.30/150-getaddrinfo-segfault-ipv6-and-ipv4.patch@424fa2092ace

scripts/libc: do not build add-ons by default

Currently, no --enable-add-ons option is passed to libc configure when
"$(do_libc_add_ons_list ,)" is empty, which makes configure automatically search
for present add-ons. In that case, all present add-ons are built, although
no add-on was selected by the user in the config. Moreover, this can make the
configure fail if some non-standard add-ons like eglibc-localedef are present.

This behavior also leads to an inconsistency from a user point of view between
the following cases:
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS="none" in the config,
which makes "$(do_libc_add_ons_list ,)" return "", so all present add-ons
are built.
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS!="none" in the
config, which makes "$(do_libc_add_ons_list ,)" return the add-on supporting
the chosen threading implementation, e.g. "nptl", so only this add-on is
built.

This patch disables the building of all add-ons in that case.

It is still possible to build all present add-ons by adding --enable-add-ons to
LIBC_GLIBC_EXTRA_CONFIG_ARRAY.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>

     1 From: Tomoyoshi ASANO <asa@lineo.co.jp>

     2 Message ID: <20081208073522.0AEF.22C34B8C@lineo.co.jp>

     4 Hello,

     6 I have SEGV at busybox's telnet with uClibc-0.9.30.

     7 It seem the current uClibc-trunk has the same problem.

     9 Thanks,

    10 -- Tom

    12 diff -ru uClibc-0.9.30.orig/libc/inet/getaddrinfo.c uClibc-0.9.30/libc/inet/getaddrinfo.c

    13 --- uClibc-0.9.30.orig/libc/inet/getaddrinfo.c	2008-10-28 17:25:10.000000000 +0100

    14 +++ uClibc-0.9.30/libc/inet/getaddrinfo.c	2009-02-26 14:20:06.000000000 +0100

    15 @@ -186,7 +186,7 @@

    16  			return seen;

    17  		}

    19 -		for (runp = ifa; runp != NULL; runp = runp->ifa_next)

    20 +		for (runp = ifa; runp != NULL; runp = runp->ifa_next) {

    21  #if defined __UCLIBC_HAS_IPV4__

    22  			if (runp->ifa_addr->sa_family == PF_INET)

    23  				seen |= SEEN_IPV4;

    24 @@ -195,7 +195,7 @@

    25  			if (runp->ifa_addr->sa_family == PF_INET6)

    26  				seen |= SEEN_IPV6;

    27  #endif /* __UCLIBC_HAS_IPV6__ */

    28 -

    29 +                }

    30  		freeifaddrs(ifa);

    31  	}

    32  #else

author	"Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
	Thu Jul 28 22:09:31 2011 +0200 (2011-07-28)
changeset 2573	424fa2092ace
permissions	-rw-r--r--