patches/binutils/2.20.1a/290-ld-stub-crash.patch
author Anthony Foiani <anthony.foiani@gmail.com>
Thu Apr 26 19:55:59 2012 -0600 (2012-04-26)
changeset 2939 58974be61289
parent 2088 4f21ba5f8e91
permissions -rw-r--r--
Allow multi-word "install" command.

Autoconf can determine that the correct install command includes flags,
e.g., "/usr/bin/install -c". When using this as a command, we can't
enclose the value in double-quotes, as that makes some shells use the
whole expression as a filename:

# this is the value returned by autoconf and stored in CT_install
$ ins="/usr/bin/install -c"

# if we call it with quotes, the command is not found
$ "${ins}"
bash: /usr/bin/install -c: No such file or directory

# removing the quotes lets it work as expected
$ ${ins}
/usr/bin/install: missing file operand
Try `/usr/bin/install --help' for more information.

Signed-Off-By: Anthony Foiani <anthony.foiani@gmail.com>
     1 diff -p -c -u -r1.196 elf32-arm.c
     2 
     3 diff -durN binutils-2.20.1.orig/bfd/elf32-arm.c binutils-2.20.1/bfd/elf32-arm.c
     4 --- binutils-2.20.1.orig/bfd/elf32-arm.c	2010-02-22 09:06:48.000000000 +0100
     5 +++ binutils-2.20.1/bfd/elf32-arm.c	2010-08-17 19:32:25.000000000 +0200
     6 @@ -3194,11 +3194,15 @@
     7  
     8  	  /* We have an extra 2-bytes reach because of
     9  	     the mode change (bit 24 (H) of BLX encoding).  */
    10 +	  /* A stub is needed only if this call is not throught a PLT
    11 +	     entry, because PLT stubs handle mode switching
    12 +	     already.  */
    13  	  if (branch_offset > (ARM_MAX_FWD_BRANCH_OFFSET + 2)
    14  	      || (branch_offset < ARM_MAX_BWD_BRANCH_OFFSET)
    15 -	      || ((r_type == R_ARM_CALL) && !globals->use_blx)
    16 -	      || (r_type == R_ARM_JUMP24)
    17 -	      || (r_type == R_ARM_PLT32))
    18 +	      || ( (((r_type == R_ARM_CALL) && !globals->use_blx)
    19 +		    || (r_type == R_ARM_JUMP24)
    20 +		    || (r_type == R_ARM_PLT32))
    21 +		   && !use_plt))
    22  	    {
    23  	      stub_type = (info->shared | globals->pic_veneer)
    24  		/* PIC stubs.  */