patches/glibc/ports-2.13/260-assume-pipe2.patch
author Anthony Foiani <anthony.foiani@gmail.com>
Thu Apr 26 19:55:59 2012 -0600 (2012-04-26)
changeset 2939 58974be61289
permissions -rw-r--r--
Allow multi-word "install" command.

Autoconf can determine that the correct install command includes flags,
e.g., "/usr/bin/install -c". When using this as a command, we can't
enclose the value in double-quotes, as that makes some shells use the
whole expression as a filename:

# this is the value returned by autoconf and stored in CT_install
$ ins="/usr/bin/install -c"

# if we call it with quotes, the command is not found
$ "${ins}"
bash: /usr/bin/install -c: No such file or directory

# removing the quotes lets it work as expected
$ ${ins}
/usr/bin/install: missing file operand
Try `/usr/bin/install --help' for more information.

Signed-Off-By: Anthony Foiani <anthony.foiani@gmail.com>
     1 http://bugs.gentoo.org/250342
     2 http://sources.redhat.com/bugzilla/show_bug.cgi?id=9685
     3 
     4 we cant assume sock_cloexec and pipe2 are bound together as the former defines
     5 are found in glibc only while the latter are a combo of kernel headers and
     6 glibc.  so if we do a runtime detection of SOCK_CLOEXEC, but pipe2() is a stub
     7 inside of glibc, we hit a problem.  for example:
     8 
     9 #include <grp.h>
    10 #include <stdio.h>
    11 main()
    12 {
    13 	getgrnam("portage");
    14 	if (!popen("ls", "r"))
    15 		perror("popen()");
    16 }
    17 
    18 getgrnam() will detect that the kernel supports SOCK_CLOEXEC and then set both
    19 __have_sock_cloexec and __have_pipe2 to true.  but if glibc was built against
    20 older kernel headers where __NR_pipe2 does not exist, glibc will have a ENOSYS
    21 stub for it.  so popen() will always fail as glibc assumes pipe2() works.
    22 
    23 diff -durN glibc-2.13.orig/socket/have_sock_cloexec.c glibc-2.13/socket/have_sock_cloexec.c
    24 --- glibc-2.13.orig/socket/have_sock_cloexec.c	2008-07-25 18:46:23.000000000 +0200
    25 +++ glibc-2.13/socket/have_sock_cloexec.c	2009-11-13 00:50:15.000000000 +0100
    26 @@ -16,9 +16,14 @@
    27     Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
    28     02111-1307 USA.  */
    29  
    30 +#include <fcntl.h>
    31  #include <sys/socket.h>
    32  #include <kernel-features.h>
    33  
    34  #if defined SOCK_CLOEXEC && !defined __ASSUME_SOCK_CLOEXEC
    35  int __have_sock_cloexec;
    36  #endif
    37 +
    38 +#if defined O_CLOEXEC && !defined __ASSUME_PIPE2
    39 +int __have_pipe2;
    40 +#endif