patches/gcc/4.4.4/140-default-format-security.patch
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Tue Aug 31 23:24:40 2010 +0200 (2010-08-31)
branch1.8
changeset 2108 68d038933dc4
child 2148 ada9128c98b8
permissions -rw-r--r--
binutils/binutils: remove faulty patch

The added code should be conditinal to the target system
being !MIPS, but is based on the host system being !MIPS.

This is plain wrong, and had not been noticed until now
as I never used those binutils versions on MIPS.

See:
http://sourceware.org/ml/crossgcc/2010-08/msg00192.html

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
(transplanted from f5ab0a80e46616adb3619cc7c5d78d0ccd7ea697)
     1 diff -durN gcc-4.4.0.orig/gcc/c-common.c gcc-4.4.0/gcc/c-common.c
     2 
     3 diff -durN gcc-4.4.4.orig/gcc/c-common.c gcc-4.4.4/gcc/c-common.c
     4 --- gcc-4.4.4.orig/gcc/c-common.c	2009-11-05 15:57:57.000000000 +0100
     5 +++ gcc-4.4.4/gcc/c-common.c	2010-05-16 19:11:21.000000000 +0200
     6 @@ -301,7 +301,7 @@
     7  /* Warn about format/argument anomalies in calls to formatted I/O functions
     8     (*printf, *scanf, strftime, strfmon, etc.).  */
     9  
    10 -int warn_format;
    11 +int warn_format = 1;
    12  
    13  /* Warn about using __null (as NULL in C++) as sentinel.  For code compiled
    14     with GCC this doesn't matter as __null is guaranteed to have the right
    15 diff -durN gcc-4.4.4.orig/gcc/c.opt gcc-4.4.4/gcc/c.opt
    16 --- gcc-4.4.4.orig/gcc/c.opt	2009-09-18 23:53:23.000000000 +0200
    17 +++ gcc-4.4.4/gcc/c.opt	2010-05-16 19:11:21.000000000 +0200
    18 @@ -236,7 +236,7 @@
    19  Warn about format strings that contain NUL bytes
    20  
    21  Wformat-security
    22 -C ObjC C++ ObjC++ Var(warn_format_security) Warning
    23 +C ObjC C++ ObjC++ Var(warn_format_security) Init(1) Warning
    24  Warn about possible security problems with format functions
    25  
    26  Wformat-y2k
    27 diff -durN gcc-4.4.4.orig/gcc/doc/invoke.texi gcc-4.4.4/gcc/doc/invoke.texi
    28 --- gcc-4.4.4.orig/gcc/doc/invoke.texi	2010-04-08 12:46:46.000000000 +0200
    29 +++ gcc-4.4.4/gcc/doc/invoke.texi	2010-05-16 19:11:21.000000000 +0200
    30 @@ -2888,6 +2888,9 @@
    31  @option{-Wformat-nonliteral}, @option{-Wformat-security}, and
    32  @option{-Wformat=2} are available, but are not included in @option{-Wall}.
    33  
    34 +NOTE: In Gentoo, this option is enabled by default for C, C++, ObjC, ObjC++.
    35 +To disable, use @option{-Wformat=0}.
    36 +
    37  @item -Wformat-y2k
    38  @opindex Wformat-y2k
    39  @opindex Wno-format-y2k
    40 @@ -2941,6 +2944,11 @@
    41  in future warnings may be added to @option{-Wformat-security} that are not
    42  included in @option{-Wformat-nonliteral}.)
    43  
    44 +NOTE: In Gentoo, this option is enabled by default for C, C++, ObjC, ObjC++.
    45 +To disable, use @option{-Wno-format-security}, or disable all format warnings
    46 +with @option{-Wformat=0}.  To make format security warnings fatal, specify
    47 +@option{-Werror=format-security}.
    48 +
    49  @item -Wformat=2
    50  @opindex Wformat=2
    51  @opindex Wno-format=2