Mercurialcrosstool-ng / file revision
summary | shortlog | changelog | graph | tags | branches | files | changeset | file | latest | revisions | annotate | diff | raw | help
patches/gdb/6.8/100-dwarf-stack-overflow.patch
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Mon Mar 29 00:15:32 2010 +0200 (2010-03-29)
changeset 1864 758d5137fe87
parent 570 301eb285ae7d
permissions -rw-r--r--
scripts/populate: optimise search loop

Curently, populate will iterate over all ELF (shared objects|executables)
to look for missing NEEDED DSOs, adding to the list at every iterations
of the search loop.

Instead of looking again at previously handled ELF files, recursively
resolve every ELf files.

Also, in case there are a whole lot of files (more than the shell can
accept as arguments list, or creating a command line longer than the
shell can cope with), use a temporary file with the list of files
to search for missing dependencies. 
     1 Original patch from gentoo: gentoo/src/patchsets/gdb/6.8/80_all_gdb-6.5-dwarf-stack-overflow.patch

     2 -= BEGIN original header =-

     3 http://bugs.gentoo.org/144833

     4 

     5 for gdb/ChangeLog:

     6 2006-08-22  Will Drewry <wad@google.com>

     7 	    Tavis Ormandy <taviso@google.com>

     8 

     9 	* dwarf2read.c (decode_locdesc): Enforce location description stack

    10 	boundaries.

    11 	* dwarfread.c (locval): Likewise.

    12 

    13 -= END original header =-

    14 diff -durN gdb-6.8.orig/gdb/dwarf2read.c gdb-6.8/gdb/dwarf2read.c

    15 --- gdb-6.8.orig/gdb/dwarf2read.c	2008-03-10 15:18:10.000000000 +0100

    16 +++ gdb-6.8/gdb/dwarf2read.c	2008-06-17 16:07:31.000000000 +0200

    17 @@ -9124,8 +9124,7 @@

    18     callers will only want a very basic result and this can become a

    19     complaint.

    20  

    21 -   Note that stack[0] is unused except as a default error return.

    22 -   Note that stack overflow is not yet handled.  */

    23 +   Note that stack[0] is unused except as a default error return. */

    24  

    25  static CORE_ADDR

    26  decode_locdesc (struct dwarf_block *blk, struct dwarf2_cu *cu)

    27 @@ -9142,7 +9141,7 @@

    28  

    29    i = 0;

    30    stacki = 0;

    31 -  stack[stacki] = 0;

    32 +  stack[++stacki] = 0;

    33  

    34    while (i < size)

    35      {

    36 @@ -9324,6 +9323,16 @@

    37  		     dwarf_stack_op_name (op));

    38  	  return (stack[stacki]);

    39  	}

    40 +      /* Enforce maximum stack depth of size-1 to avoid ++stacki writing

    41 +         outside of the allocated space. Also enforce minimum > 0.

    42 +         -- wad@google.com 14 Aug 2006 */

    43 +      if (stacki >= sizeof (stack) / sizeof (*stack) - 1)

    44 +	internal_error (__FILE__, __LINE__,

    45 +	                _("location description stack too deep: %d"),

    46 +	                stacki);

    47 +      if (stacki <= 0)

    48 +	internal_error (__FILE__, __LINE__,

    49 +	                _("location description stack too shallow"));

    50      }

    51    return (stack[stacki]);

    52  }
crosstool-ng