patches/gcc/4.0.4/170-libmudflap-susv3-legacy.patch
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Tue Dec 13 23:32:39 2011 +0100 (2011-12-13)
branch1.13
changeset 2847 c0bf2319af08
parent 27 14938fdeaaa2
permissions -rw-r--r--
scripts: fix dumping execution backtrace

Dumping the backtrace has been broken since changeset #652e56d6d35a:
scripts: execute each steps in a subshell

We can spawn sub-sub-shells in some cases.

The way the fault handler works is to dump the backtrace, but to avoid
printing it once for every sub-shell (which could get quite confusing),
it simply exits when it detects that it is being run in a sub-shell,
leaving to the top-level shell the work to dump the backtrace.

Because each step is executed in its own sub-shell, the variable arrays
that contain the step name, the source file and line number, are lost
when exiting the per-step sub-shell.

Hence, the backtrace is currently limited to printing only the top-level
main procedure of the shell.

Fix this thus:
- when dumping the bckatraces for the steps & the functions, remember
it was dumped, and only dump it if it was not already dumped
- at the top-level shell, print the hints

Also, rename the top-level step label.

Reported-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
(transplanted from 4193d6e6a17430a177fa88c287879c2c35e319f3)
     1 Index: gcc-4.2/libmudflap/mf-hooks2.c
     2 ===================================================================
     3 --- gcc-4.2/libmudflap/mf-hooks2.c	(revision 119834)
     4 +++ gcc-4.2/libmudflap/mf-hooks2.c	(working copy)
     5 @@ -427,7 +427,7 @@
     6  {
     7    TRACE ("%s\n", __PRETTY_FUNCTION__);
     8    MF_VALIDATE_EXTENT(s, n, __MF_CHECK_WRITE, "bzero region");
     9 -  bzero (s, n);
    10 +  memset (s, 0, n);
    11  }
    12  
    13  
    14 @@ -437,7 +437,7 @@
    15    TRACE ("%s\n", __PRETTY_FUNCTION__);
    16    MF_VALIDATE_EXTENT(src, n, __MF_CHECK_READ, "bcopy src");
    17    MF_VALIDATE_EXTENT(dest, n, __MF_CHECK_WRITE, "bcopy dest");
    18 -  bcopy (src, dest, n);
    19 +  memmove (dest, src, n);
    20  }
    21  
    22  
    23 @@ -447,7 +447,7 @@
    24    TRACE ("%s\n", __PRETTY_FUNCTION__);
    25    MF_VALIDATE_EXTENT(s1, n, __MF_CHECK_READ, "bcmp 1st arg");
    26    MF_VALIDATE_EXTENT(s2, n, __MF_CHECK_READ, "bcmp 2nd arg");
    27 -  return bcmp (s1, s2, n);
    28 +  return n == 0 ? 0 : memcmp (s1, s2, n);
    29  }
    30  
    31  
    32 @@ -456,7 +456,7 @@
    33    size_t n = strlen (s);
    34    TRACE ("%s\n", __PRETTY_FUNCTION__);
    35    MF_VALIDATE_EXTENT(s, CLAMPADD(n, 1), __MF_CHECK_READ, "index region");
    36 -  return index (s, c);
    37 +  return strchr (s, c);
    38  }
    39  
    40  
    41 @@ -465,7 +465,7 @@
    42    size_t n = strlen (s);
    43    TRACE ("%s\n", __PRETTY_FUNCTION__);
    44    MF_VALIDATE_EXTENT(s, CLAMPADD(n, 1), __MF_CHECK_READ, "rindex region");
    45 -  return rindex (s, c);
    46 +  return strrchr (s, c);
    47  }
    48  
    49  /* XXX:  stpcpy, memccpy */