scripts/build/companion_tools.sh
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Tue Dec 13 23:32:39 2011 +0100 (2011-12-13)
branch1.13
changeset 2847 c0bf2319af08
permissions -rw-r--r--
scripts: fix dumping execution backtrace

Dumping the backtrace has been broken since changeset #652e56d6d35a:
scripts: execute each steps in a subshell

We can spawn sub-sub-shells in some cases.

The way the fault handler works is to dump the backtrace, but to avoid
printing it once for every sub-shell (which could get quite confusing),
it simply exits when it detects that it is being run in a sub-shell,
leaving to the top-level shell the work to dump the backtrace.

Because each step is executed in its own sub-shell, the variable arrays
that contain the step name, the source file and line number, are lost
when exiting the per-step sub-shell.

Hence, the backtrace is currently limited to printing only the top-level
main procedure of the shell.

Fix this thus:
- when dumping the bckatraces for the steps & the functions, remember
it was dumped, and only dump it if it was not already dumped
- at the top-level shell, print the hints

Also, rename the top-level step label.

Reported-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
(transplanted from 4193d6e6a17430a177fa88c287879c2c35e319f3)
     1 # Wrapper to build the companion tools facilities
     2 
     3 # List all companion tools facilities, and parse their scripts
     4 CT_COMP_TOOLS_FACILITY_LIST=
     5 for f in "${CT_LIB_DIR}/scripts/build/companion_tools/"*.sh; do
     6     _f="$(basename "${f}" .sh)"
     7     _f="${_f#???-}"
     8     __f="CT_COMP_TOOLS_${_f}"
     9     if [ "${!__f}" = "y" ]; then
    10         CT_DoLog DEBUG "Enabling companion tools '${_f}'"
    11         . "${f}"
    12         CT_COMP_TOOLS_FACILITY_LIST="${CT_COMP_TOOLS_FACILITY_LIST} ${_f}"
    13     else
    14         CT_DoLog DEBUG "Disabling companion tools '${_f}'"
    15     fi
    16 done
    17 
    18 # Download the companion tools facilities
    19 do_companion_tools_get() {
    20     for f in ${CT_COMP_TOOLS_FACILITY_LIST}; do
    21         do_companion_tools_${f}_get
    22     done
    23 }
    24 
    25 # Extract and patch the companion tools facilities
    26 do_companion_tools_extract() {
    27     for f in ${CT_COMP_TOOLS_FACILITY_LIST}; do
    28         do_companion_tools_${f}_extract
    29     done
    30 }
    31 
    32 # Build the companion tools facilities
    33 do_companion_tools() {
    34     for f in ${CT_COMP_TOOLS_FACILITY_LIST}; do
    35         do_companion_tools_${f}_build
    36     done
    37 }
    38