scripts/scripts.mk
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Tue Dec 13 23:32:39 2011 +0100 (2011-12-13)
branch1.13
changeset 2847 c0bf2319af08
parent 1618 7f52e1cca71e
permissions -rw-r--r--
scripts: fix dumping execution backtrace

Dumping the backtrace has been broken since changeset #652e56d6d35a:
scripts: execute each steps in a subshell

We can spawn sub-sub-shells in some cases.

The way the fault handler works is to dump the backtrace, but to avoid
printing it once for every sub-shell (which could get quite confusing),
it simply exits when it detects that it is being run in a sub-shell,
leaving to the top-level shell the work to dump the backtrace.

Because each step is executed in its own sub-shell, the variable arrays
that contain the step name, the source file and line number, are lost
when exiting the per-step sub-shell.

Hence, the backtrace is currently limited to printing only the top-level
main procedure of the shell.

Fix this thus:
- when dumping the bckatraces for the steps & the functions, remember
it was dumped, and only dump it if it was not already dumped
- at the top-level shell, print the hints

Also, rename the top-level step label.

Reported-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
(transplanted from 4193d6e6a17430a177fa88c287879c2c35e319f3)
     1 # Makefile for the scripts/ sub-directory
     2 
     3 # Here, we can update the config.* scripts.
     4 # If we're in CT_LIB_DIR, then CT_LIB_DIR == CT_TOP_DIR, and we can update those
     5 # scripts for later inclusion mainline. If CT_LIB_DIR != CT_TOP_DIR, then those
     6 # scripts are downloaded only for use in CT_TOP_DIR.
     7 
     8 # ----------------------------------------------------------
     9 # The tools help entry
    10 
    11 help-distrib::
    12 	@echo  '  updatetools        - Update the config tools'
    13 
    14 # ----------------------------------------------------------
    15 # Where to get tools from, and where to store them into
    16 # The tools are: config.guess and config.sub
    17 
    18 CONFIG_SUB_SRC="http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD"
    19 CONFIG_SUB_DEST=scripts/config.sub
    20 CONFIG_GUESS_SRC="http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD"
    21 CONFIG_GUESS_DEST=scripts/config.guess
    22 
    23 PHONY += updatetools
    24 updatetools: $(CONFIG_SUB_DEST) $(CONFIG_GUESS_DEST)
    25 
    26 # ----------------------------------------------------------
    27 # How to retrieve the tools
    28 
    29 wget_opt=-o /dev/null
    30 ifeq ($(strip $(V)),2)
    31   wget_opt=
    32 endif
    33 
    34 PHONY += scripts
    35 scripts:
    36 	@$(ECHO) '  MKDIR $@'
    37 	$(SILENT)mkdir -p $@
    38 
    39 $(CONFIG_SUB_DEST): scripts FORCE
    40 	@$(ECHO) '  WGET  $@'
    41 	$(SILENT)wget $(wget_opt) -O $@ $(CONFIG_SUB_SRC)
    42 	$(SILENT)chmod u+rwx,go+rx-w $@
    43 
    44 $(CONFIG_GUESS_DEST): scripts FORCE
    45 	@$(ECHO) '  WGET  $@'
    46 	$(SILENT)wget $(wget_opt) -O $@ $(CONFIG_GUESS_SRC)
    47 	$(SILENT)chmod u+rwx,go+rx-w $@
    48 
    49 # ----------------------------------------------------------
    50 # Clean up the mess
    51 
    52 distclean::
    53 	@$(ECHO) "  CLEAN scripts"
    54 	$(SILENT)[ $(CT_TOP_DIR) = $(CT_LIB_DIR) ] || rm -rf $(CT_TOP_DIR)/scripts