patches/binutils/2.17/140-better_file_error.patch
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Mon Dec 14 19:17:37 2009 +0100 (2009-12-14)
changeset 1662 ea3490d46f4e
parent 745 e445c00d134d
permissions -rw-r--r--
scripts: correctly warn when the local tarballs directory does not exist

Warn about a missing local tarball directory, only if it was configured.
Avoid the spurious message:
Directory '${CT_LOCAL_TARBALLS_DIR}' does not exist.
Will not save downloaded tarballs to local storage.

Thanks to "Pedro I. Sanchez" <psanchez@colcan.ca> for pointing out the
issue:
http://sourceware.org/ml/crossgcc/2009-12/msg00011.html
     1 diff -dur binutils-2.17.old/bfd/opncls.c binutils-2.17/bfd/opncls.c
     2 --- binutils-2.17.old/bfd/opncls.c	2006-03-16 13:20:16.000000000 +0100
     3 +++ binutils-2.17/bfd/opncls.c	2007-05-01 18:26:11.000000000 +0200
     4 @@ -158,6 +158,13 @@
     5  {
     6    bfd *nbfd;
     7    const bfd_target *target_vec;
     8 +  struct stat s;
     9 +
    10 +  if (stat (filename, &s) == 0)
    11 +    if (S_ISDIR(s.st_mode)) {
    12 +      bfd_set_error (bfd_error_file_not_recognized);
    13 +      return NULL;
    14 +    }
    15  
    16    nbfd = _bfd_new_bfd ();
    17    if (nbfd == NULL)