patches/binutils/2.20/180-only-use-new-ld-dtags.patch.disabled
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Mon Dec 14 19:17:37 2009 +0100 (2009-12-14)
changeset 1662 ea3490d46f4e
permissions -rw-r--r--
scripts: correctly warn when the local tarballs directory does not exist

Warn about a missing local tarball directory, only if it was configured.
Avoid the spurious message:
Directory '${CT_LOCAL_TARBALLS_DIR}' does not exist.
Will not save downloaded tarballs to local storage.

Thanks to "Pedro I. Sanchez" <psanchez@colcan.ca> for pointing out the
issue:
http://sourceware.org/ml/crossgcc/2009-12/msg00011.html
     1 Don't generate RPATH if we're going to be generating RUNPATH.
     2 
     3 need to ponder what ramifications this has before enabling it
     4 
     5 --- binutils/bfd/elflink.c
     6 +++ binutils/bfd/elflink.c
     7 @@ -5382,11 +5382,15 @@
     8  
     9  	  indx = _bfd_elf_strtab_add (elf_hash_table (info)->dynstr, rpath,
    10  				      TRUE);
    11 -	  if (indx == (bfd_size_type) -1
    12 -	      || !_bfd_elf_add_dynamic_entry (info, DT_RPATH, indx))
    13 +	  if (indx == (bfd_size_type) -1)
    14  	    return FALSE;
    15  
    16 -	  if  (info->new_dtags)
    17 +	  if (!info->new_dtags)
    18 +	    {
    19 +	      if (!_bfd_elf_add_dynamic_entry (info, DT_RPATH, indx))
    20 +		return FALSE;
    21 +	    }
    22 +	  else
    23  	    {
    24  	      _bfd_elf_strtab_addref (elf_hash_table (info)->dynstr, indx);
    25  	      if (!_bfd_elf_add_dynamic_entry (info, DT_RUNPATH, indx))