Mercurialcrosstool-ng / file revision
summary | shortlog | changelog | graph | tags | branches | files | changeset | file | latest | revisions | annotate | diff | raw | help
patches/glibc/2.3.6/200-use_short_for_fnstsw.patch
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Tue Jun 22 23:49:23 2010 +0200 (2010-06-22)
changeset 1992 eebcaff6626f
parent 744 4bf8448536d5
permissions -rw-r--r--
scripts/wrapper: fix wrong test when checking access to the reall tool

In C, the proper syntax for a bit-wise OR is a single '|', not two.

It worked so far because all was well:
- X_OK == 1
- R_OK||X_OK == 1
- the file we searched for had the x-bit set
-> access( file, R_OK||X_OK ) worked
- inicidentally, the file we searched for also had the r-bit set,
but we were not testing that in fact. 
     1 Original patch from H.J. Lu, as reported there:

     2 http://www.nabble.com/PATCH:-Use-short-for-fnstsw-td14775171.html

     3 

     4 fnstsw stores 16bit into %ax. The upper 16bit of %eax is unchanged.

     5 The new assembler (binutils-2.18.50.0.4 and up) will disallow "fnstsw %eax".

     6 

     7 diff -dur glibc-2.6.1.orig/sysdeps/i386/fpu/ftestexcept.c glibc-2.6.1/sysdeps/i386/fpu/ftestexcept.c

     8 --- glibc-2.6.1.orig/sysdeps/i386/fpu/ftestexcept.c	2004-03-05 11:14:48.000000000 +0100

     9 +++ glibc-2.6.1/sysdeps/i386/fpu/ftestexcept.c	2008-06-24 10:56:14.000000000 +0200

    10 @@ -26,7 +26,7 @@

    11  int

    12  fetestexcept (int excepts)

    13  {

    14 -  int temp;

    15 +  short temp;

    16    int xtemp = 0;

    17  

    18    /* Get current exceptions.  */
crosstool-ng