"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Wed, 23 Nov 2011 00:11:36 +0100] rev 2825
libc/glibc: add multilib-cacpable backend
For mutlilib, the C library must be built once for each variants.
Special care must be taken to put the resulting libraries in
the proper places.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Tue, 22 Nov 2011 00:51:37 +0100] rev 2824
libc/glibc: fix code formatting
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Tue, 22 Nov 2011 00:16:37 +0100] rev 2823
libc/glib: pass installation subdir to backend
When building a multilib variant, install in a separate directory, to
avoid clutering the default or any other variant.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Tue, 22 Nov 2011 00:11:51 +0100] rev 2822
libc/glibc: set the endian option according to extra CFLAGS
When building a multilib, some extra CFLAGS can override the
default config option. This is the case for the endianness
selection.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Mon, 21 Nov 2011 23:56:53 +0100] rev 2821
libc/glibc: set the float option according to extra CFLAGS
When building a multilib, some extra CFLAGS can override the
default config option. This is the case for the floating point
selection.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Mon, 21 Nov 2011 23:33:08 +0100] rev 2820
libc/glibc: add extra CFLAGS when building the C library
When building multilib, we need extra CFLAGS that tell the compiler
to use non-default settings (eg. big/little endian, hard/soft float,
-march/cpu/tune flags, and so on...).
We have to pass these flags to the build.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Tue, 13 Dec 2011 11:51:07 +0100] rev 2819
libc/glibc: no default mode for backend
The caller SHALL explicitly ask for a nmode, and not rely on a default mode.
That's what actually happens, so we can get rid of the default.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Fri, 30 Dec 2011 21:43:10 +0100] rev 2818
cc/gcc: print supported multilibs
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Wed, 23 Nov 2011 23:51:07 +0100] rev 2817
cc/gcc: build multilib
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Wed, 23 Nov 2011 23:27:12 +0100] rev 2816
binutils/binutils: build multilib
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Wed, 23 Nov 2011 23:25:43 +0100] rev 2815
config: add option to build multilib
Add a toolchain-wide option to enable multilib.
This is currently a noop, and will be implemented
in subsequent patches for each impacted components.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Sat, 31 Dec 2011 16:23:27 +0100] rev 2814
cc/gcc: add option to use system zlib
In some cases, it might be desirable to use the system zlib
Eg. because latest gcc seem to be totally borked when it comes
to multilib, and tries to build a multilib host zlib, when it
is *absolutely* *not* needed: we want mulitlib on the target,
not on the host! Sigh... :-(
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Fri, 30 Dec 2011 22:04:24 +0100] rev 2813
libc/uClibc: add latest version
Add 0.9.32.1
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Fri, 30 Dec 2011 14:16:49 +0100] rev 2812
kernel/linux: update to latest versions
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Fri, 30 Dec 2011 14:15:43 +0100] rev 2811
scripts: update config.guess and config.sub
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Benoît Thébaudeau" <benoit.thebaudeau@advansee.com> [Wed, 14 Dec 2011 19:57:47 +0100] rev 2810
binutils/binutils: add the patches used by BuildRoot for 2.22
Signed-off-by: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
"Benoît Thébaudeau" <benoit.thebaudeau@advansee.com> [Wed, 14 Dec 2011 16:55:22 +0100] rev 2809
libc/eglibc: fix localedef 2.14 build
The localedef of eglibc 2.14 requires NOT_IN_libc to be defined in order to
compile intl/l10nflist.c.
This is because localedef is built separately from eglibc and uses some parts of
eglibc that don't compile in standalone without this preprocessor definition.
This fixes the following error:
[ALL ] gcc -g -O2 -DNO_SYSCONF -DNO_UNCOMPRESS
-DLOCALE_PATH='"/usr/lib/locale:/usr/share/i18n"'
-DLOCALEDIR='"/usr/lib/locale"' -DLOCALE_ALIAS_PATH='"/usr/share/locale"'
-DCHARMAP_PATH='"/usr/share/i18n/charmaps"'
-DREPERTOIREMAP_PATH='"/usr/share/i18n/repertoiremaps"'
-DLOCSRCDIR='"/usr/share/i18n/locales"' -Iglibc/locale/programs -Iglibc/locale
-I/<snip>/.build/src/eglibc-localedef-2_14/include
-I/<snip>/.build/src/eglibc-localedef-2_14 -I.
-include /<snip>/.build/src/eglibc-localedef-2_14/include/always.h -Wall
-Wno-format -c -o locarchive.o glibc/locale/programs/locarchive.c
[ALL ] glibc/locale/programs/locarchive.c: In function 'enlarge_archive':
[ALL ] glibc/locale/programs/locarchive.c:303:21: warning: variable
'oldlocrectab' set but not used [-Wunused-but-set-variable]
[ALL ] In file included from glibc/locale/programs/locarchive.c:651:0:
[ALL ] glibc/locale/programs/../../intl/l10nflist.c: In function
'_nl_normalize_codeset':
[ERROR] glibc/locale/programs/../../intl/l10nflist.c:342:9: error:
'_nl_C_locobj_ptr' undeclared (first use in this function)
[ALL ] glibc/locale/programs/../../intl/l10nflist.c:342:9: note: each
undeclared identifier is reported only once for each function it appears in
[ALL ] glibc/locale/programs/locarchive.c: In function
'add_locales_to_archive':
[ALL ] glibc/locale/programs/locarchive.c:1450:7: warning: passing argument
1 of '__xpg_basename' discards 'const' qualifier from pointer target type
[enabled by default]
[ALL ] /usr/include/libgen.h:35:14: note: expected 'char *' but argument is
of type 'const char *'
[ERROR] make[1]: *** [locarchive.o] Error 1
Signed-off-by: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
Zhenqiang Chen <zhenqiang.chen@linaro.org> [Thu, 15 Dec 2011 15:20:33 +0800] rev 2808
libc/newlib: build manual for newlib
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
[yann.morin.1998@anciens.enib.fr: copy with a single call to 'cp']
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Tue, 13 Dec 2011 23:32:39 +0100] rev 2807
scripts: fix dumping execution backtrace
Dumping the backtrace has been broken since changeset #652e56d6d35a:
scripts: execute each steps in a subshell
We can spawn sub-sub-shells in some cases.
The way the fault handler works is to dump the backtrace, but to avoid
printing it once for every sub-shell (which could get quite confusing),
it simply exits when it detects that it is being run in a sub-shell,
leaving to the top-level shell the work to dump the backtrace.
Because each step is executed in its own sub-shell, the variable arrays
that contain the step name, the source file and line number, are lost
when exiting the per-step sub-shell.
Hence, the backtrace is currently limited to printing only the top-level
main procedure of the shell.
Fix this thus:
- when dumping the bckatraces for the steps & the functions, remember
it was dumped, and only dump it if it was not already dumped
- at the top-level shell, print the hints
Also, rename the top-level step label.
Reported-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Mon, 21 Nov 2011 23:35:21 +0100] rev 2806
libc/glibc: document the glibc backend arguments
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Mon, 21 Nov 2011 23:26:18 +0100] rev 2805
libc/glibc: create build dir using libc_mode
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Benoît Thébaudeau" <benoit.thebaudeau@advansee.com> [Mon, 12 Dec 2011 20:24:05 +0100] rev 2804
binutils/binutils: fix extra config array variable name
The changeset 2467 #200836977ce6 missed renaming one occurrence of
CT_BINUTILS_EXTRA_CONFIG to CT_BINUTILS_EXTRA_CONFIG_ARRAY, which is fixed by
this patch.
Signed-off-by: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
"Benoît Thébaudeau" <benoit.thebaudeau@advansee.com> [Mon, 12 Dec 2011 13:27:59 +0100] rev 2803
debug/gdb: update Linaro GDB revisions to 2011.12
Update Linaro GDB with the latest available revisions.
Signed-off-by: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
"Benoît Thébaudeau" <benoit.thebaudeau@advansee.com> [Mon, 12 Dec 2011 13:25:11 +0100] rev 2802
cc/gcc: update Linaro GCC revisions to 2011.12
Update Linaro GCC with the latest available revisions.
Signed-off-by: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Mon, 12 Dec 2011 21:41:16 +0200] rev 2801
scripts: unset CONFIG_SITE
Some distributions (eg. openSUSE 12.1) systematically export
the CONFIG_SITE environment variable to point to a custom
script setting misc paths for ./configure.
This can, and does, break when cross-compiling for architectures
that are not supported by this script.
The simple workaround is to unset this variable.
NB: buildroot has a similar fix:
http://git.buildroot.org/buildroot/commit/?id=12c9f7dd6dee9c6029b4f9a12d6aac1516911ab4
Reported-by: Trevor Woerner <twoerner@gmail.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Benoît Thébaudeau" <benoit.thebaudeau@advansee.com> [Mon, 12 Dec 2011 21:47:08 +0100] rev 2800
kernel/linux: fix missing quote
Signed-off-by: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Sun, 11 Dec 2011 23:14:57 +0100] rev 2799
kernel/linux: add latest versions
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Mon, 12 Dec 2011 00:01:54 +0100] rev 2798
kernel/linux: add alternate download locations
Some longterm versions are not in the usual directory.
Account for these new locations.
Get rid of the mirror location, now that the main kernel site is
(almost) back to normal operations.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Titus von Boxberg <titus@v9g.de> [Mon, 28 Nov 2011 21:27:08 +0100] rev 2797
binutils/binutils: add binutils 2.22
Enable (EXPERIMENTAL) selection of binutils 2.22
Signed-off-by: "Titus von Boxberg" <titus@v9g.de>
Zhenqiang Chen <zhenqiang.chen@linaro.org> [Wed, 07 Dec 2011 16:15:50 +0800] rev 2796
scripts: create CT_HEADERS_DIR
"${CT_SYSROOT_DIR}/usr/include" is only for "${CT_USE_SYSROOT}" = "y".
We should also mkdir when "${CT_USE_SYSROOT}" != "y".
"${CT_HEADERS_DIR}" can support both cases.
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
Titus von Boxberg <titus@v9g.de> [Wed, 30 Nov 2011 12:07:59 +0100] rev 2795
scripts: use CT_CONFIG_SHELL instead of CT_SHELL
CT_SHELL is undefined.
Thus, the generated wrapper scripts are not executable by the kernel
because they do not contain a valid interpreter.
Use CT_CONFIG_SHELL instead.
Signed-off-by: "Titus von Boxberg" <titus@v9g.de>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Fri, 25 Nov 2011 23:59:29 +0100] rev 2794
config/target: enforce floating point support
Do not prompt for the type of floating-point support, if the
architecture did not explicitly stated that it did support it.
Reported-by: Morten Thunberg Svendsen <mts@doredevelopment.dk>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Thu, 24 Nov 2011 19:48:35 +0100] rev 2793
arch/sparc: Sparc supports setting the floating point type
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Thu, 24 Nov 2011 19:44:17 +0100] rev 2792
arch/powerpc: PowerPC supports setting the floating point type
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Thu, 24 Nov 2011 19:42:02 +0100] rev 2791
arch/mips: MIPS supports setting the floating point type
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Thu, 24 Nov 2011 19:38:37 +0100] rev 2790
arch/arm: ARM supports setting the floating point type
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Fri, 25 Nov 2011 23:57:55 +0100] rev 2789
config/target: add float support selection
Changeset #149c33923f47 broke the architectures that do not
support the --with-float=X ./configure flag (in gcc). For example,
x86_64 does not support it.
Add a new blind config option that architectures can set to tell
they support floating point selection.
Reported-by: Morten Thunberg Svendsen <mts@doredevelopment.dk>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Wed, 30 Nov 2011 00:25:22 +0100] rev 2788
arch: rename the SUPPORT_XXX options
First, 'SUPPORT' should be spelled 'SUPPORTS'.
Second, 'SUPPORT_XXX' really means 'supports --with-xxx', so rename the
affected options accordingly. Update the affected archs to match the new
namings.
Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Zhenqiang Chen <zhenqiang.chen@linaro.org> [Mon, 28 Nov 2011 16:05:23 +0800] rev 2787
libc/newlib: remove hard-coded "-O"
With hard-coded "-O", users can not customize CFLAGS_FOR_TARGET
by CT_TARGET_CFLAGS. If "-O" is needed, users can input it in
CT_TARGET_CFLAGS. By default, "-Os" is enabled.
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Mon, 28 Nov 2011 18:35:17 +0100] rev 2786
config: fix NLS typo
Reported-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Titus von Boxberg <titus@v9g.de> [Tue, 22 Nov 2011 10:08:10 +0100] rev 2785
scripts/functions: extract: portable call for old and defective tars
Instead of using -J, --lzma, --use-compress-program or the like
use <compressor> -dc <file> | tar -f -
Signed-off-by: Titus von Boxberg <titus@v9g.de>
Zhenqiang Chen <zhenqiang.chen@linaro.org> [Wed, 23 Nov 2011 13:15:27 +0800] rev 2784
debug/gdb: add extra config for gdb cross.
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
[yann.morin.1998@anciens.enib.fr: prompt rewording, as suggested by M. Hope]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Zhenqiang Chen <zhenqiang.chen@linaro.org> [Tue, 22 Nov 2011 14:18:14 +0800] rev 2783
libc/newlib: add option to optimise for size
Add an option to build with -Os instead of the default -O.
Reviewed-by: Michael Hope
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
Zhenqiang Chen <zhenqiang.chen@linaro.org> [Fri, 18 Nov 2011 11:32:50 +0800] rev 2782
cc/gcc: Apply CT_CC_GCC_DISABLE_PCH to do_cc_core.
Otherwise, users have to input --disable-libstdcxx-pch option
when building bare-metal CANADIAN C++ compiler.
Reviewed-by: Michael Hope
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
Zhenqiang Chen <zhenqiang.chen@linaro.org> [Fri, 18 Nov 2011 11:47:30 +0800] rev 2781
libc/newlib: Add extra config for newlib.
So users can input config like --enable-newlib-register-fini.
Reviewed-by: Michael Hope
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
Zhenqiang Chen <zhenqiang.chen@linaro.org> [Thu, 17 Nov 2011 18:00:28 +0800] rev 2780
cc/gcc: handle NLS option
Add --disable-nls config when option "Enable nls" is not selected.
Reviewed-by: Michael Hope
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
Zhenqiang Chen <zhenqiang.chen@linaro.org> [Thu, 17 Nov 2011 17:59:44 +0800] rev 2779
binutils/binutils: handle NLS option
Add --disable-nls config when option "Enable nls" is not selected.
Reviewed-by: Michael Hope
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
Zhenqiang Chen <zhenqiang.chen@linaro.org> [Fri, 18 Nov 2011 15:29:18 +0800] rev 2778
config/toolchain: Add "Enable nls" in "Toolchain options".
Reviewed-by: Michael Hope
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Sun, 20 Nov 2011 21:08:27 +0100] rev 2777
libc/uClibc: use endian string in tests
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Sun, 20 Nov 2011 21:06:36 +0100] rev 2776
libc/eglibc: use endian string in tests
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Sun, 20 Nov 2011 21:05:36 +0100] rev 2775
arch/sh: use endian string in tests
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Sun, 20 Nov 2011 21:04:31 +0100] rev 2774
arch/mips: use endian string in tests
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Sun, 20 Nov 2011 21:01:34 +0100] rev 2773
scripts/functions: use endian string in tests
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Mon, 14 Nov 2011 19:13:00 +0100] rev 2772
config: introduce endianness as a string
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Sun, 20 Nov 2011 20:57:06 +0100] rev 2771
1.13: update version to 1.13.2+hg
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Sun, 20 Nov 2011 20:57:06 +0100] rev 2770
Tagging release 1.13.2
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Sun, 20 Nov 2011 20:57:06 +0100] rev 2769
1.13: update version to 1.13.2
Titus von Boxberg <titus@v9g.de> [Thu, 17 Nov 2011 14:18:44 +0100] rev 2768
arch/x86: prescott is an i686
let CT_ARCH_ARCH=prescott result in a i686 tuple prefix
Signed-off-by: Titus von Boxberg <titus@v9g.de>
(transplanted from d063b1ae8c1b30c7006b110d0f9045e6d7c34f13)
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Sun, 16 Oct 2011 15:10:29 +0200] rev 2767
complibs/cloog: auto-reconf for 0.15.10 and later
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
(transplanted from 47199f966983bab6a68b2b5da2e1542adbd9388a)
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> [Sun, 16 Oct 2011 14:58:29 +0200] rev 2766
complibs/cloog: fix extraction
In the early days, cloog-ppl was bizarrely packaged: the first tarball
did not contain the version in the name of the extracted directory, so
we had to play tricks.
Nowadays, however, the first component of the path are stripped when
extracting a tarball, which means that the created directory will
always be properly named. So, our old tricks do no longer work, and
worse, they break the build.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
(transplanted from f070d922facf42b0395b7db909e1867d45b245dd)