yann@2438: http://bugs.gentoo.org/250342 yann@2438: http://sources.redhat.com/bugzilla/show_bug.cgi?id=9685 yann@2438: yann@2438: we cant assume sock_cloexec and pipe2 are bound together as the former defines yann@2438: are found in glibc only while the latter are a combo of kernel headers and yann@2438: glibc. so if we do a runtime detection of SOCK_CLOEXEC, but pipe2() is a stub yann@2438: inside of glibc, we hit a problem. for example: yann@2438: yann@2438: #include yann@2438: #include yann@2438: main() yann@2438: { yann@2438: getgrnam("portage"); yann@2438: if (!popen("ls", "r")) yann@2438: perror("popen()"); yann@2438: } yann@2438: yann@2438: getgrnam() will detect that the kernel supports SOCK_CLOEXEC and then set both yann@2438: __have_sock_cloexec and __have_pipe2 to true. but if glibc was built against yann@2438: older kernel headers where __NR_pipe2 does not exist, glibc will have a ENOSYS yann@2438: stub for it. so popen() will always fail as glibc assumes pipe2() works. yann@2438: yann@2438: diff -durN glibc-2.13.orig/socket/have_sock_cloexec.c glibc-2.13/socket/have_sock_cloexec.c yann@2438: --- glibc-2.13.orig/socket/have_sock_cloexec.c 2008-07-25 18:46:23.000000000 +0200 yann@2438: +++ glibc-2.13/socket/have_sock_cloexec.c 2009-11-13 00:50:15.000000000 +0100 yann@2438: @@ -16,9 +16,14 @@ yann@2438: Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA yann@2438: 02111-1307 USA. */ yann@2438: yann@2438: +#include yann@2438: #include yann@2438: #include yann@2438: yann@2438: #if defined SOCK_CLOEXEC && !defined __ASSUME_SOCK_CLOEXEC yann@2438: int __have_sock_cloexec; yann@2438: #endif yann@2438: + yann@2438: +#if defined O_CLOEXEC && !defined __ASSUME_PIPE2 yann@2438: +int __have_pipe2; yann@2438: +#endif