yann@1243: Original patch from: ../crosstool-NG/ct-ng.trunk/patches/binutils/2.19/150-warn-textrel.patch yann@1243: yann@1243: -= BEGIN original header =- yann@1243: Original patch from Gentoo: yann@1243: gentoo/src/patchsets/binutils/2.19/66_all_binutils-2.18.50.0.2-warn-textrel.patch yann@1243: yann@1243: textrels are bad for forcing copy-on-write (this affects everyone), yann@1243: and for security/runtime code generation, this affects security ppl. yann@1243: But in either case, it doesn't matter who needs textrels, it's yann@1243: the very fact that they're needed at all. yann@1243: yann@1243: -= END original header =- yann@1243: yann@1243: diff -durN binutils-2.19.1.orig/bfd/elflink.c binutils-2.19.1/bfd/elflink.c yann@1243: --- binutils-2.19.1.orig/bfd/elflink.c 2009-03-08 11:57:02.000000000 +0100 yann@1243: +++ binutils-2.19.1/bfd/elflink.c 2009-03-08 11:57:02.000000000 +0100 yann@1243: @@ -10820,14 +10820,12 @@ yann@1243: goto error_return; yann@1243: yann@1243: /* Check for DT_TEXTREL (late, in case the backend removes it). */ yann@1243: - if (info->warn_shared_textrel && info->shared) yann@1243: + o = bfd_get_section_by_name (dynobj, ".dynamic"); yann@1243: + if (info->warn_shared_textrel && o != NULL) yann@1243: { yann@1243: bfd_byte *dyncon, *dynconend; yann@1243: yann@1243: /* Fix up .dynamic entries. */ yann@1243: - o = bfd_get_section_by_name (dynobj, ".dynamic"); yann@1243: - BFD_ASSERT (o != NULL); yann@1243: - yann@1243: dyncon = o->contents; yann@1243: dynconend = o->contents + o->size; yann@1243: for (; dyncon < dynconend; dyncon += bed->s->sizeof_dyn) yann@1243: @@ -10839,7 +10837,7 @@ yann@1243: if (dyn.d_tag == DT_TEXTREL) yann@1243: { yann@1243: info->callbacks->einfo yann@1243: - (_("%P: warning: creating a DT_TEXTREL in a shared object.\n")); yann@1243: + (_("%P: warning: creating a DT_TEXTREL in object.\n")); yann@1243: break; yann@1243: } yann@1243: } yann@1243: diff -durN binutils-2.19.1.orig/ld/ldmain.c binutils-2.19.1/ld/ldmain.c yann@1243: --- binutils-2.19.1.orig/ld/ldmain.c 2008-08-17 05:12:50.000000000 +0200 yann@1243: +++ binutils-2.19.1/ld/ldmain.c 2009-03-08 11:57:02.000000000 +0100 yann@1243: @@ -274,6 +274,7 @@ yann@1243: link_info.relax_pass = 1; yann@1243: link_info.pei386_auto_import = -1; yann@1243: link_info.spare_dynamic_tags = 5; yann@1243: + link_info.warn_shared_textrel = TRUE; yann@1243: link_info.path_separator = ':'; yann@1243: yann@1243: ldfile_add_arch ("");