yann@1625: http://bugs.gentoo.org/250342
yann@1625: http://sources.redhat.com/bugzilla/show_bug.cgi?id=9685
yann@1625: 
yann@1625: we cant assume sock_cloexec and pipe2 are bound together as the former defines
yann@1625: are found in glibc only while the latter are a combo of kernel headers and
yann@1625: glibc.  so if we do a runtime detection of SOCK_CLOEXEC, but pipe2() is a stub
yann@1625: inside of glibc, we hit a problem.  for example:
yann@1625: 
yann@1625: #include <grp.h>
yann@1625: #include <stdio.h>
yann@1625: main()
yann@1625: {
yann@1625: 	getgrnam("portage");
yann@1625: 	if (!popen("ls", "r"))
yann@1625: 		perror("popen()");
yann@1625: }
yann@1625: 
yann@1625: getgrnam() will detect that the kernel supports SOCK_CLOEXEC and then set both
yann@1625: __have_sock_cloexec and __have_pipe2 to true.  but if glibc was built against
yann@1625: older kernel headers where __NR_pipe2 does not exist, glibc will have a ENOSYS
yann@1625: stub for it.  so popen() will always fail as glibc assumes pipe2() works.
yann@1625: 
yann@1625: diff -durN glibc-2.10.1.orig/include/unistd.h glibc-2.10.1/include/unistd.h
yann@1625: --- glibc-2.10.1.orig/include/unistd.h	2008-07-27 20:23:17.000000000 +0200
yann@1625: +++ glibc-2.10.1/include/unistd.h	2009-11-13 00:50:15.000000000 +0100
yann@1625: @@ -167,9 +167,6 @@
yann@1625:  extern int __pause_nocancel (void) attribute_hidden;
yann@1625:  
yann@1625:  extern int __have_sock_cloexec;
yann@1625: -/* At lot of other functionality became available at the same time as
yann@1625: -   SOCK_CLOEXEC.  Avoid defining separate variables for all of them
yann@1625: -   unless it is really necessary.  */
yann@1625: -#define __have_pipe2 __have_sock_cloexec
yann@1625: +extern int __have_pipe2;
yann@1625:  
yann@1625:  #endif
yann@1625: diff -durN glibc-2.10.1.orig/socket/have_sock_cloexec.c glibc-2.10.1/socket/have_sock_cloexec.c
yann@1625: --- glibc-2.10.1.orig/socket/have_sock_cloexec.c	2008-07-25 18:46:23.000000000 +0200
yann@1625: +++ glibc-2.10.1/socket/have_sock_cloexec.c	2009-11-13 00:50:15.000000000 +0100
yann@1625: @@ -16,9 +16,14 @@
yann@1625:     Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
yann@1625:     02111-1307 USA.  */
yann@1625:  
yann@1625: +#include <fcntl.h>
yann@1625:  #include <sys/socket.h>
yann@1625:  #include <kernel-features.h>
yann@1625:  
yann@1625:  #if defined SOCK_CLOEXEC && !defined __ASSUME_SOCK_CLOEXEC
yann@1625:  int __have_sock_cloexec;
yann@1625:  #endif
yann@1625: +
yann@1625: +#if defined O_CLOEXEC && !defined __ASSUME_PIPE2
yann@1625: +int __have_pipe2;
yann@1625: +#endif