yann@1069: Original patch from Gentoo: yann@1069: gentoo/src/patchsets/binutils/2.19/66_all_binutils-2.18.50.0.2-warn-textrel.patch yann@1069: yann@1069: textrels are bad for forcing copy-on-write (this affects everyone), yann@1069: and for security/runtime code generation, this affects security ppl. yann@1069: But in either case, it doesn't matter who needs textrels, it's yann@1069: the very fact that they're needed at all. yann@1069: yann@1069: diff -durN binutils-2.19.orig/bfd/elflink.c binutils-2.19/bfd/elflink.c yann@1069: --- binutils-2.19.orig/bfd/elflink.c 2008-11-23 16:49:47.000000000 +0100 yann@1069: +++ binutils-2.19/bfd/elflink.c 2008-11-23 16:49:14.000000000 +0100 yann@1069: @@ -10820,14 +10820,12 @@ yann@1069: goto error_return; yann@1069: yann@1069: /* Check for DT_TEXTREL (late, in case the backend removes it). */ yann@1069: - if (info->warn_shared_textrel && info->shared) yann@1069: + o = bfd_get_section_by_name (dynobj, ".dynamic"); yann@1069: + if (info->warn_shared_textrel && o != NULL) yann@1069: { yann@1069: bfd_byte *dyncon, *dynconend; yann@1069: yann@1069: /* Fix up .dynamic entries. */ yann@1069: - o = bfd_get_section_by_name (dynobj, ".dynamic"); yann@1069: - BFD_ASSERT (o != NULL); yann@1069: - yann@1069: dyncon = o->contents; yann@1069: dynconend = o->contents + o->size; yann@1069: for (; dyncon < dynconend; dyncon += bed->s->sizeof_dyn) yann@1069: @@ -10839,7 +10837,7 @@ yann@1069: if (dyn.d_tag == DT_TEXTREL) yann@1069: { yann@1069: info->callbacks->einfo yann@1069: - (_("%P: warning: creating a DT_TEXTREL in a shared object.\n")); yann@1069: + (_("%P: warning: creating a DT_TEXTREL in object.\n")); yann@1069: break; yann@1069: } yann@1069: } yann@1069: diff -durN binutils-2.19.orig/ld/ldmain.c binutils-2.19/ld/ldmain.c yann@1069: --- binutils-2.19.orig/ld/ldmain.c 2008-08-17 05:12:50.000000000 +0200 yann@1069: +++ binutils-2.19/ld/ldmain.c 2008-11-23 16:52:37.000000000 +0100 yann@1069: @@ -274,6 +274,7 @@ yann@1069: link_info.relax_pass = 1; yann@1069: link_info.pei386_auto_import = -1; yann@1069: link_info.spare_dynamic_tags = 5; yann@1069: + link_info.warn_shared_textrel = TRUE; yann@1069: link_info.path_separator = ':'; yann@1069: yann@1069: ldfile_add_arch ("");