yann@1614: textrels are bad for forcing copy-on-write (this affects everyone),
yann@1614: and for security/runtime code generation, this affects security ppl.
yann@1614: But in either case, it doesn't matter who needs textrels, it's
yann@1614: the very fact that they're needed at all.
yann@1614: 
yann@1614: 2006-06-10  Ned Ludd  <solar@gentoo.org>, Mike Frysinger <vapier@gentoo.org>
yann@1614: 
yann@1614: 	* bfd/elflink.c (bfd_elf_final_link): Check all objects for TEXTRELs.
yann@1614: 	* ld/ldmain.c (main): Change textrel warning default to true.
yann@1614: 	* ld/testsuite/lib/ld-lib.exp (default_ld_simple_link): Scrub TEXTREL
yann@1614: 	warnings from ld output.
yann@1614: 
fr@1621: --- binutils/bfd/elflink.c
fr@1621: +++ binutils/bfd/elflink.c
yann@1614: @@ -8652,14 +8652,12 @@
yann@1614:  	goto error_return;
yann@1614:  
yann@1614:        /* Check for DT_TEXTREL (late, in case the backend removes it).  */
yann@1614: -      if (info->warn_shared_textrel && info->shared)
yann@1614: +      o = bfd_get_section_by_name (dynobj, ".dynamic");
yann@1614: +      if (info->warn_shared_textrel && o != NULL)
yann@1614:  	{
yann@1614:  	  bfd_byte *dyncon, *dynconend;
yann@1614:  
yann@1614:  	  /* Fix up .dynamic entries.  */
yann@1614: -	  o = bfd_get_section_by_name (dynobj, ".dynamic");
yann@1614: -	  BFD_ASSERT (o != NULL);
yann@1614: -
yann@1614:  	  dyncon = o->contents;
yann@1614:  	  dynconend = o->contents + o->size;
yann@1614:  	  for (; dyncon < dynconend; dyncon += bed->s->sizeof_dyn)
yann@1614: @@ -8702,7 +8702,7 @@ bfd_elf_final_link (bfd *abfd, struct bf
yann@1614:  	      if (dyn.d_tag == DT_TEXTREL)
yann@1614:  		{
yann@1614:  		 info->callbacks->einfo
yann@1614: -		    (_("%P: warning: creating a DT_TEXTREL in a shared object.\n"));
yann@1614: +		    (_("%P: warning: creating a DT_TEXTREL in object.\n"));
yann@1614:  		  break;
yann@1614:  		}
yann@1614:  	    }
fr@1621: --- binutils/ld/ldmain.c
fr@1621: +++ binutils/ld/ldmain.c
yann@1614: @@ -282,2 +282,3 @@ main (int argc, char **argv)
yann@1614:    link_info.spare_dynamic_tags = 5;
yann@1614: +  link_info.warn_shared_textrel = TRUE;
yann@1614:    link_info.sharable_sections = FALSE;
fr@1621: --- binutils/ld/testsuite/lib/ld-lib.exp
fr@1621: +++ binutils/ld/testsuite/lib/ld-lib.exp
yann@1614: @@ -181,6 +181,10 @@ proc default_ld_simple_link { ld target 
yann@1614:      # symbol, since the default linker script might use ENTRY.
yann@1614:      regsub -all "(^|\n)(\[^\n\]*: warning: cannot find entry symbol\[^\n\]*\n?)" $exec_output "\\1" exec_output
yann@1614:  
yann@1614: +    # Gentoo tweak:
yann@1614: +    # We want to ignore TEXTREL warnings since we force enable them by default
yann@1614: +    regsub -all "^lt-ld-new: warning: creating a DT_TEXTREL in object\." $exec_output "\\1" exec_output
yann@1614: +
yann@1614:      if [string match "" $exec_output] then {
yann@1614:  	return 1
yann@1614:      } else {