yann@2437: when glibc runs its tests, it does so by invoking the local library loader. yann@2437: in Gentoo, we build/run inside of our "sandbox" which itself is linked against yann@2437: libdl (so that it can load libraries and pull out symbols). the trouble yann@2437: is that when you upgrade from an older glibc to the new one, often times yann@2437: internal symbols change name or abi. this is normally OK as you cannot use yann@2437: libc.so from say version 2.3.6 but libpthread.so from say version 2.5, so yann@2437: we always say "keep all of the glibc libraries from the same build". but yann@2437: when glibc runs its tests, it uses dynamic paths to point to its new local yann@2437: copies of libraries. if the test doesnt use libdl, then glibc doesnt add yann@2437: its path, and when sandbox triggers the loading of libdl, glibc does so yann@2437: from the host system system. this gets us into the case of all libraries yann@2437: are from the locally compiled version of glibc except for libdl.so. yann@2437: yann@2437: Fix by Wormo yann@2437: yann@2437: http://bugs.gentoo.org/56898 yann@2437: yann@2437: diff -durN glibc-2.12.1.orig/grp/tst_fgetgrent.sh glibc-2.12.1/grp/tst_fgetgrent.sh yann@2437: --- glibc-2.12.1.orig/grp/tst_fgetgrent.sh 2001-07-06 06:54:46.000000000 +0200 yann@2437: +++ glibc-2.12.1/grp/tst_fgetgrent.sh 2009-11-13 00:50:37.000000000 +0100 yann@2437: @@ -24,7 +24,8 @@ yann@2437: rtld_installed_name=$1; shift yann@2437: yann@2437: testout=${common_objpfx}/grp/tst_fgetgrent.out yann@2437: -library_path=${common_objpfx} yann@2437: +# make sure libdl is also in path in case sandbox is in use yann@2437: +library_path=${common_objpfx}:${common_objpfx}/dlfcn yann@2437: yann@2437: result=0 yann@2437: yann@2437: diff -durN glibc-2.12.1.orig/iconvdata/run-iconv-test.sh glibc-2.12.1/iconvdata/run-iconv-test.sh yann@2437: --- glibc-2.12.1.orig/iconvdata/run-iconv-test.sh 2008-05-15 03:59:44.000000000 +0200 yann@2437: +++ glibc-2.12.1/iconvdata/run-iconv-test.sh 2009-11-13 00:50:37.000000000 +0100 yann@2437: @@ -34,7 +34,7 @@ yann@2437: export GCONV_PATH yann@2437: yann@2437: # We have to have some directories in the library path. yann@2437: -LIBPATH=$codir:$codir/iconvdata yann@2437: +LIBPATH=$codir:$codir/iconvdata:$codir/dlfcn yann@2437: yann@2437: # How the start the iconv(1) program. yann@2437: ICONV='$codir/elf/ld.so --library-path $LIBPATH --inhibit-rpath ${from}.so \ yann@2437: diff -durN glibc-2.12.1.orig/iconvdata/tst-table.sh glibc-2.12.1/iconvdata/tst-table.sh yann@2437: --- glibc-2.12.1.orig/iconvdata/tst-table.sh 2002-04-24 23:39:35.000000000 +0200 yann@2437: +++ glibc-2.12.1/iconvdata/tst-table.sh 2009-11-13 00:50:37.000000000 +0100 yann@2437: @@ -59,8 +59,11 @@ yann@2437: irreversible=${charset}.irreversible yann@2437: fi yann@2437: yann@2437: +# make sure libdl is also in path in case sandbox is in use yann@2437: +library_path=${common_objpfx}:${common_objpfx}/dlfcn yann@2437: + yann@2437: # iconv in one direction. yann@2437: -${common_objpfx}elf/ld.so --library-path $common_objpfx \ yann@2437: +${common_objpfx}elf/ld.so --library-path $library_path \ yann@2437: ${objpfx}tst-table-from ${charset} \ yann@2437: > ${objpfx}tst-${charset}.table yann@2437: yann@2437: diff -durN glibc-2.12.1.orig/intl/tst-codeset.sh glibc-2.12.1/intl/tst-codeset.sh yann@2437: --- glibc-2.12.1.orig/intl/tst-codeset.sh 2005-04-06 04:18:35.000000000 +0200 yann@2437: +++ glibc-2.12.1/intl/tst-codeset.sh 2009-11-13 00:50:37.000000000 +0100 yann@2437: @@ -37,6 +37,9 @@ yann@2437: LOCPATH=${common_objpfx}localedata yann@2437: export LOCPATH yann@2437: yann@2437: +# make sure libdl is also in path in case sandbox is in use yann@2437: +library_path=${common_objpfx}:${common_objpfx}/dlfcn yann@2437: + yann@2437: ${common_objpfx}elf/ld.so --library-path $common_objpfx \ yann@2437: ${objpfx}tst-codeset > ${objpfx}tst-codeset.out yann@2437: yann@2437: diff -durN glibc-2.12.1.orig/intl/tst-gettext.sh glibc-2.12.1/intl/tst-gettext.sh yann@2437: --- glibc-2.12.1.orig/intl/tst-gettext.sh 2004-08-15 21:28:18.000000000 +0200 yann@2437: +++ glibc-2.12.1/intl/tst-gettext.sh 2009-11-13 00:50:37.000000000 +0100 yann@2437: @@ -51,9 +51,12 @@ yann@2437: LOCPATH=${common_objpfx}localedata yann@2437: export LOCPATH yann@2437: yann@2437: +# make sure libdl is also in path in case sandbox is in use yann@2437: +library_path=${common_objpfx}:${common_objpfx}/dlfcn yann@2437: + yann@2437: # Now run the test. yann@2437: MALLOC_TRACE=$malloc_trace LOCPATH=${objpfx}localedir:$LOCPATH \ yann@2437: -${common_objpfx}elf/ld.so --library-path $common_objpfx \ yann@2437: +${common_objpfx}elf/ld.so --library-path $library_path \ yann@2437: ${objpfx}tst-gettext > ${objpfx}tst-gettext.out ${objpfx}domaindir yann@2437: yann@2437: exit $? yann@2437: diff -durN glibc-2.12.1.orig/intl/tst-gettext2.sh glibc-2.12.1/intl/tst-gettext2.sh yann@2437: --- glibc-2.12.1.orig/intl/tst-gettext2.sh 2005-05-04 19:54:48.000000000 +0200 yann@2437: +++ glibc-2.12.1/intl/tst-gettext2.sh 2009-11-13 00:50:37.000000000 +0100 yann@2437: @@ -65,8 +65,11 @@ yann@2437: LOCPATH=${objpfx}domaindir yann@2437: export LOCPATH yann@2437: yann@2437: +# make sure libdl is also in path in case sandbox is in use yann@2437: +library_path=${common_objpfx}:${common_objpfx}/dlfcn yann@2437: + yann@2437: # Now run the test. yann@2437: -${common_objpfx}elf/ld.so --library-path $common_objpfx \ yann@2437: +${common_objpfx}elf/ld.so --library-path $library_path \ yann@2437: ${objpfx}tst-gettext2 > ${objpfx}tst-gettext2.out ${objpfx}domaindir && yann@2437: cmp ${objpfx}tst-gettext2.out - < ${objpfx}tst-translit.out ${objpfx}domaindir yann@2437: yann@2437: exit $? yann@2437: diff -durN glibc-2.12.1.orig/malloc/tst-mtrace.sh glibc-2.12.1/malloc/tst-mtrace.sh yann@2437: --- glibc-2.12.1.orig/malloc/tst-mtrace.sh 2005-10-15 01:40:35.000000000 +0200 yann@2437: +++ glibc-2.12.1/malloc/tst-mtrace.sh 2009-11-13 00:50:37.000000000 +0100 yann@2437: @@ -24,9 +24,12 @@ yann@2437: status=0 yann@2437: trap "rm -f ${common_objpfx}malloc/tst-mtrace.leak; exit 1" 1 2 15 yann@2437: yann@2437: +# make sure libdl is also in path in case sandbox is in use yann@2437: +library_path=${common_objpfx}:${common_objpfx}/dlfcn yann@2437: + yann@2437: MALLOC_TRACE=${common_objpfx}malloc/tst-mtrace.leak \ yann@2437: LOCPATH=${common_objpfx}localedata GCONV_PATH=${common_objpfx}iconvdata \ yann@2437: -${common_objpfx}elf/ld.so --library-path $common_objpfx \ yann@2437: +${common_objpfx}elf/ld.so --library-path $library_path \ yann@2437: ${common_objpfx}malloc/tst-mtrace || status=1 yann@2437: yann@2437: if test $status -eq 0 && test -f ${common_objpfx}malloc/mtrace; then yann@2437: diff -durN glibc-2.12.1.orig/nptl/tst-tls6.sh glibc-2.12.1/nptl/tst-tls6.sh yann@2437: --- glibc-2.12.1.orig/nptl/tst-tls6.sh 2003-09-03 00:02:59.000000000 +0200 yann@2437: +++ glibc-2.12.1/nptl/tst-tls6.sh 2009-11-13 00:50:37.000000000 +0100 yann@2437: @@ -5,8 +5,8 @@ yann@2437: rtld_installed_name=$1; shift yann@2437: logfile=$common_objpfx/nptl/tst-tls6.out yann@2437: yann@2437: -# We have to find libc and nptl yann@2437: -library_path=${common_objpfx}:${common_objpfx}nptl yann@2437: +# We have to find libc and nptl (also libdl in case sandbox is in use) yann@2437: +library_path=${common_objpfx}:${common_objpfx}nptl:${common_objpfx}/dlfcn yann@2437: tst_tls5="${elf_objpfx}${rtld_installed_name} --library-path ${library_path} \ yann@2437: ${common_objpfx}/nptl/tst-tls5" yann@2437: yann@2437: diff -durN glibc-2.12.1.orig/posix/globtest.sh glibc-2.12.1/posix/globtest.sh yann@2437: --- glibc-2.12.1.orig/posix/globtest.sh 2008-12-06 07:05:39.000000000 +0100 yann@2437: +++ glibc-2.12.1/posix/globtest.sh 2009-11-13 00:50:37.000000000 +0100 yann@2437: @@ -18,7 +18,7 @@ yann@2437: esac yann@2437: yann@2437: # We have to find the libc and the NSS modules. yann@2437: -library_path=${common_objpfx}:${common_objpfx}nss:${common_objpfx}nis:${common_objpfx}db2:${common_objpfx}hesiod yann@2437: +library_path=${common_objpfx}:${common_objpfx}nss:${common_objpfx}nis:${common_objpfx}db2:${common_objpfx}hesiod:${common_objpfx}/dlfcn yann@2437: yann@2437: # Since we use `sort' we must make sure to use the same locale everywhere. yann@2437: LC_ALL=C yann@2437: diff -durN glibc-2.12.1.orig/posix/tst-getconf.sh glibc-2.12.1/posix/tst-getconf.sh yann@2437: --- glibc-2.12.1.orig/posix/tst-getconf.sh 2002-09-01 13:11:25.000000000 +0200 yann@2437: +++ glibc-2.12.1/posix/tst-getconf.sh 2009-11-13 00:50:37.000000000 +0100 yann@2437: @@ -10,7 +10,10 @@ yann@2437: else yann@2437: rtld_installed_name=$1; shift yann@2437: runit() { yann@2437: - ${elf_objpfx}${rtld_installed_name} --library-path ${common_objpfx} "$@" yann@2437: + yann@2437: + # make sure libdl is also in path in case sandbox is in use yann@2437: + library_path=${common_objpfx}:${common_objpfx}/dlfcn yann@2437: + ${elf_objpfx}${rtld_installed_name} --library-path ${library_path} "$@" yann@2437: } yann@2437: fi yann@2437: yann@2437: diff -durN glibc-2.12.1.orig/posix/wordexp-tst.sh glibc-2.12.1/posix/wordexp-tst.sh yann@2437: --- glibc-2.12.1.orig/posix/wordexp-tst.sh 2000-10-20 18:23:30.000000000 +0200 yann@2437: +++ glibc-2.12.1/posix/wordexp-tst.sh 2009-11-13 00:50:37.000000000 +0100 yann@2437: @@ -19,8 +19,11 @@ yann@2437: " yann@2437: export IFS yann@2437: yann@2437: +# make sure libdl is also in path in case sandbox is in use yann@2437: +library_path=${common_objpfx}:${common_objpfx}/dlfcn yann@2437: + yann@2437: failed=0 yann@2437: -${elf_objpfx}${rtld_installed_name} --library-path ${common_objpfx} \ yann@2437: +${elf_objpfx}${rtld_installed_name} --library-path ${library_path} \ yann@2437: ${common_objpfx}posix/wordexp-test '$*' > ${testout}1 yann@2437: cat <<"EOF" | cmp - ${testout}1 >> $logfile || failed=1 yann@2437: wordexp returned 0