yann@1201: Original patch from: gentoo/src/patchsets/glibc/2.9/1020_all_glibc-2.9-strlen-hack.patch yann@1201: yann@1201: -= BEGIN original header =- yann@1201: http://sourceware.org/bugzilla/show_bug.cgi?id=5807 yann@1201: http://www.cl.cam.ac.uk/~am21/progtricks.html yann@1201: yann@1201: -= END original header =- yann@1201: yann@1201: diff -durN glibc-2_9.orig/string/strlen.c glibc-2_9/string/strlen.c yann@1201: --- glibc-2_9.orig/string/strlen.c 2005-12-14 12:09:07.000000000 +0100 yann@1201: +++ glibc-2_9/string/strlen.c 2009-02-02 22:00:51.000000000 +0100 yann@1201: @@ -32,7 +32,7 @@ yann@1201: { yann@1201: const char *char_ptr; yann@1201: const unsigned long int *longword_ptr; yann@1201: - unsigned long int longword, magic_bits, himagic, lomagic; yann@1201: + unsigned long int longword, himagic, lomagic; yann@1201: yann@1201: /* Handle the first few characters by reading one character at a time. yann@1201: Do this until CHAR_PTR is aligned on a longword boundary. */ yann@1201: @@ -42,28 +42,14 @@ yann@1201: if (*char_ptr == '\0') yann@1201: return char_ptr - str; yann@1201: yann@1201: - /* All these elucidatory comments refer to 4-byte longwords, yann@1201: - but the theory applies equally well to 8-byte longwords. */ yann@1201: - yann@1201: longword_ptr = (unsigned long int *) char_ptr; yann@1201: yann@1201: - /* Bits 31, 24, 16, and 8 of this number are zero. Call these bits yann@1201: - the "holes." Note that there is a hole just to the left of yann@1201: - each byte, with an extra at the end: yann@1201: - yann@1201: - bits: 01111110 11111110 11111110 11111111 yann@1201: - bytes: AAAAAAAA BBBBBBBB CCCCCCCC DDDDDDDD yann@1201: - yann@1201: - The 1-bits make sure that carries propagate to the next 0-bit. yann@1201: - The 0-bits provide holes for carries to fall into. */ yann@1201: - magic_bits = 0x7efefeffL; yann@1201: himagic = 0x80808080L; yann@1201: lomagic = 0x01010101L; yann@1201: if (sizeof (longword) > 4) yann@1201: { yann@1201: /* 64-bit version of the magic. */ yann@1201: /* Do the shift in two steps to avoid a warning if long has 32 bits. */ yann@1201: - magic_bits = ((0x7efefefeL << 16) << 16) | 0xfefefeffL; yann@1201: himagic = ((himagic << 16) << 16) | himagic; yann@1201: lomagic = ((lomagic << 16) << 16) | lomagic; yann@1201: } yann@1201: @@ -75,56 +61,12 @@ yann@1201: if *any of the four* bytes in the longword in question are zero. */ yann@1201: for (;;) yann@1201: { yann@1201: - /* We tentatively exit the loop if adding MAGIC_BITS to yann@1201: - LONGWORD fails to change any of the hole bits of LONGWORD. yann@1201: - yann@1201: - 1) Is this safe? Will it catch all the zero bytes? yann@1201: - Suppose there is a byte with all zeros. Any carry bits yann@1201: - propagating from its left will fall into the hole at its yann@1201: - least significant bit and stop. Since there will be no yann@1201: - carry from its most significant bit, the LSB of the yann@1201: - byte to the left will be unchanged, and the zero will be yann@1201: - detected. yann@1201: - yann@1201: - 2) Is this worthwhile? Will it ignore everything except yann@1201: - zero bytes? Suppose every byte of LONGWORD has a bit set yann@1201: - somewhere. There will be a carry into bit 8. If bit 8 yann@1201: - is set, this will carry into bit 16. If bit 8 is clear, yann@1201: - one of bits 9-15 must be set, so there will be a carry yann@1201: - into bit 16. Similarly, there will be a carry into bit yann@1201: - 24. If one of bits 24-30 is set, there will be a carry yann@1201: - into bit 31, so all of the hole bits will be changed. yann@1201: - yann@1201: - The one misfire occurs when bits 24-30 are clear and bit yann@1201: - 31 is set; in this case, the hole at bit 31 is not yann@1201: - changed. If we had access to the processor carry flag, yann@1201: - we could close this loophole by putting the fourth hole yann@1201: - at bit 32! yann@1201: - yann@1201: - So it ignores everything except 128's, when they're aligned yann@1201: - properly. */ yann@1201: - yann@1201: longword = *longword_ptr++; yann@1201: yann@1201: - if ( yann@1201: -#if 0 yann@1201: - /* Add MAGIC_BITS to LONGWORD. */ yann@1201: - (((longword + magic_bits) yann@1201: - yann@1201: - /* Set those bits that were unchanged by the addition. */ yann@1201: - ^ ~longword) yann@1201: - yann@1201: - /* Look at only the hole bits. If any of the hole bits yann@1201: - are unchanged, most likely one of the bytes was a yann@1201: - zero. */ yann@1201: - & ~magic_bits) yann@1201: -#else yann@1201: - ((longword - lomagic) & himagic) yann@1201: -#endif yann@1201: - != 0) yann@1201: + /* This hack taken from Alan Mycroft's HAKMEMC postings. yann@1201: + See: http://www.cl.cam.ac.uk/~am21/progtricks.html */ yann@1201: + if (((longword - lomagic) & ~longword & himagic) != 0) yann@1201: { yann@1201: - /* Which of the bytes was the zero? If none of them were, it was yann@1201: - a misfire; continue the search. */ yann@1201: yann@1201: const char *cp = (const char *) (longword_ptr - 1); yann@1201: