yann@2735: commit f210735fe2f17a6225432ee3d1239bcf23a8659c yann@2735: Author: Markus Trippelsdorf yann@2735: Date: Fri Jun 24 15:51:00 2011 +0200 yann@2735: yann@2735: headers_install: fix __packed in exported kernel headers yann@2735: yann@2735: checkpatch.pl warns about using __attribute__((packed)) in kernel yann@2735: headers: "__packed is preferred over __attribute__((packed))". If one yann@2735: follows that advice it could cause problems in the exported header yann@2735: files, because the outside world doesn't know about this shortcut. yann@2735: yann@2735: For example busybox will fail to compile: yann@2735: CC miscutils/ubi_attach_detach.o yann@2735: In file included from miscutils/ubi_attach_detach.c:27:0: yann@2735: /usr/include/mtd/ubi-user.h:330:3: error: conflicting types for ‘__packed’ yann@2735: /usr/include/mtd/ubi-user.h:314:3: note: previous declaration of ‘__packed’ was here yann@2735: ... yann@2735: yann@2735: Fix the problem by substituting __packed with __attribute__((packed)) in yann@2735: the header_install.pl script. yann@2735: yann@2735: Cc: Artem Bityutskiy yann@2735: CC: Joe Perches yann@2735: Signed-off-by: Markus Trippelsdorf yann@2735: Signed-off-by: Michal Marek yann@2735: yann@2735: diff --git a/scripts/headers_install.pl b/scripts/headers_install.pl yann@2735: index efb3be1..48462be 100644 yann@2735: --- a/scripts/headers_install.pl yann@2735: +++ b/scripts/headers_install.pl yann@2735: @@ -35,6 +35,7 @@ foreach my $file (@files) { yann@2735: $line =~ s/([\s(])__iomem\s/$1/g; yann@2735: $line =~ s/\s__attribute_const__\s/ /g; yann@2735: $line =~ s/\s__attribute_const__$//g; yann@2735: + $line =~ s/\b__packed\b/__attribute__((packed))/g; yann@2735: $line =~ s/^#include //; yann@2735: $line =~ s/(^|\s)(inline)\b/$1__$2__/g; yann@2735: $line =~ s/(^|\s)(asm)\b(\s|[(]|$)/$1__$2__$3/g;