yann@402: Signed-off-by: dank@kegel.com yann@402: Fixes ld speed issue. yann@402: See http://weblogs.mozillazine.org/roc/archives/2005/02/optimizing_gnu.html yann@402: See thread "Re: optimizations for 3x speedup in ld", yann@402: http://sources.redhat.com/ml/binutils/2005-03/msg00847.html yann@402: yann@402: Wildcard section matching enhancement, backported from the binutils CVS tree. yann@402: Here's the CVS log comment from the original change to ldlang.c: yann@402: yann@402: revision 1.177 yann@402: date: 2005/04/06 15:33:02; author: jakub; state: Exp; lines: +438 -51 yann@402: 2005-04-06 Jakub Jelinek yann@402: yann@402: * ldlang.c: Formatting. yann@402: (walk_wild_consider_section): Remember return value from wildcardp. yann@402: (is_simple_wild): Use strcspn instead of 2 strpbrk calls and strlen. yann@402: (wild_spec_can_overlap): Use strcspn instead of strpbrk and strlen. yann@402: yann@402: 2005-04-06 Robert O'Callahan yann@402: yann@402: * ld.h (lean_section_userdata_type): Remove. yann@402: (fat_section_userdata_type): Remove file field. yann@402: (SECTION_USERDATA_SIZE): Remove. yann@402: * ldlang.c (init_os): Eliminate initialization of unused yann@402: lean_section_userdata_type. yann@402: yann@402: * ldlang.h (callback_t, walk_wild_section_handler_t): New yann@402: typedefs. yann@402: (struct lang_wild_statement_struct): Add walk_wild_section_handler yann@402: and handler_data fields. yann@402: * ldlang.c (callback_t): Removed. yann@402: (walk_wild_consider_section, walk_wild_section_general, yann@402: section_iterator_callback, find_section, is_simple_wild, yann@402: match_simple_wild, walk_wild_section_specs1_wild0, yann@402: walk_wild_section_specs1_wild1, walk_wild_section_specs2_wild1, yann@402: walk_wild_section_specs3_wild2, walk_wild_section_specs4_wild2, yann@402: wild_spec_can_overlap, analyze_walk_wild_section_handler): New yann@402: functions. yann@402: (lang_add_wild): Call analyze_walk_wild_section_handler. yann@402: (walk_wild_section): Renamed to walk_wild_section_general and yann@402: created a wrapper function. yann@402: (section_iterator_callback_data): New typedef. yann@402: yann@402: Note that bfd_get_section_by_name_if didn't exist in 2.15, so it was backported yann@402: as well. yann@402: yann@402: --- binutils-2.15/bfd/bfd-in2.h.old 2004-05-17 15:35:56.000000000 -0400 yann@402: +++ binutils-2.15/bfd/bfd-in2.h 2006-02-09 11:54:45.989940000 -0500 yann@402: @@ -1425,6 +1425,10 @@ yann@402: yann@402: asection *bfd_get_section_by_name (bfd *abfd, const char *name); yann@402: yann@402: +asection *bfd_get_section_by_name_if (bfd *abfd, const char *name, yann@402: + bfd_boolean (*operation) (bfd *, asection *, void *), yann@402: + void *user_storage); yann@402: + yann@402: char *bfd_get_unique_section_name yann@402: (bfd *abfd, const char *templat, int *count); yann@402: yann@402: --- binutils-2.15/bfd/section.c.old 2003-12-01 01:33:01.000000000 -0500 yann@402: +++ binutils-2.15/bfd/section.c 2006-01-23 14:16:54.768993000 -0500 yann@402: @@ -801,6 +801,57 @@ yann@402: yann@402: /* yann@402: FUNCTION yann@402: + bfd_get_section_by_name_if yann@402: + yann@402: +SYNOPSIS yann@402: + asection *bfd_get_section_by_name_if yann@402: + (bfd *abfd, yann@402: + const char *name, yann@402: + bfd_boolean (*func) (bfd *abfd, asection *sect, void *obj), yann@402: + void *obj); yann@402: + yann@402: +DESCRIPTION yann@402: + Call the provided function @var{func} for each section yann@402: + attached to the BFD @var{abfd} whose name matches @var{name}, yann@402: + passing @var{obj} as an argument. The function will be called yann@402: + as if by yann@402: + yann@402: +| func (abfd, the_section, obj); yann@402: + yann@402: + It returns the first section for which @var{func} returns true, yann@402: + otherwise <>. yann@402: + yann@402: +*/ yann@402: + yann@402: +asection * yann@402: +bfd_get_section_by_name_if (bfd *abfd, const char *name, yann@402: + bfd_boolean (*operation) (bfd *, yann@402: + asection *, yann@402: + void *), yann@402: + void *user_storage) yann@402: +{ yann@402: + struct section_hash_entry *sh; yann@402: + unsigned long hash; yann@402: + yann@402: + sh = section_hash_lookup (&abfd->section_htab, name, FALSE, FALSE); yann@402: + if (sh == NULL) yann@402: + return NULL; yann@402: + yann@402: + hash = sh->root.hash; yann@402: + do yann@402: + { yann@402: + if ((*operation) (abfd, &sh->section, user_storage)) yann@402: + return &sh->section; yann@402: + sh = (struct section_hash_entry *) sh->root.next; yann@402: + } yann@402: + while (sh != NULL && sh->root.hash == hash yann@402: + && strcmp (sh->root.string, name) == 0); yann@402: + yann@402: + return NULL; yann@402: +} yann@402: + yann@402: +/* yann@402: +FUNCTION yann@402: bfd_get_unique_section_name yann@402: yann@402: SYNOPSIS yann@402: --- binutils-2.15/ld/ldlang.c.old 2004-05-17 15:36:16.000000000 -0400 yann@402: +++ binutils-2.15/ld/ldlang.c 2006-01-23 13:40:12.745499000 -0500 yann@402: @@ -81,9 +81,6 @@ yann@402: static void lang_record_phdrs (void); yann@402: static void lang_do_version_exports_section (void); yann@402: yann@402: -typedef void (*callback_t) (lang_wild_statement_type *, struct wildcard_list *, yann@402: - asection *, lang_input_statement_type *, void *); yann@402: - yann@402: /* Exported variables. */ yann@402: lang_output_section_statement_type *abs_output_section; yann@402: lang_statement_list_type lang_output_section_statement; yann@402: @@ -138,21 +135,71 @@ yann@402: yann@402: /* Generic traversal routines for finding matching sections. */ yann@402: yann@402: +/* Try processing a section against a wildcard. This just calls yann@402: + the callback unless the filename exclusion list is present yann@402: + and excludes the file. It's hardly ever present so this yann@402: + function is very fast. */ yann@402: + yann@402: +static void yann@402: +walk_wild_consider_section (lang_wild_statement_type *ptr, yann@402: + lang_input_statement_type *file, yann@402: + asection *s, yann@402: + struct wildcard_list *sec, yann@402: + callback_t callback, yann@402: + void *data) yann@402: +{ yann@402: + bfd_boolean skip = FALSE; yann@402: + struct name_list *list_tmp; yann@402: + yann@402: + /* Don't process sections from files which were yann@402: + excluded. */ yann@402: + for (list_tmp = sec->spec.exclude_name_list; yann@402: + list_tmp; yann@402: + list_tmp = list_tmp->next) yann@402: + { yann@402: + bfd_boolean is_wildcard = wildcardp (list_tmp->name); yann@402: + if (is_wildcard) yann@402: + skip = fnmatch (list_tmp->name, file->filename, 0) == 0; yann@402: + else yann@402: + skip = strcmp (list_tmp->name, file->filename) == 0; yann@402: + yann@402: + /* If this file is part of an archive, and the archive is yann@402: + excluded, exclude this file. */ yann@402: + if (! skip && file->the_bfd != NULL yann@402: + && file->the_bfd->my_archive != NULL yann@402: + && file->the_bfd->my_archive->filename != NULL) yann@402: + { yann@402: + if (is_wildcard) yann@402: + skip = fnmatch (list_tmp->name, yann@402: + file->the_bfd->my_archive->filename, yann@402: + 0) == 0; yann@402: + else yann@402: + skip = strcmp (list_tmp->name, yann@402: + file->the_bfd->my_archive->filename) == 0; yann@402: + } yann@402: + yann@402: + if (skip) yann@402: + break; yann@402: + } yann@402: + yann@402: + if (!skip) yann@402: + (*callback) (ptr, sec, s, file, data); yann@402: +} yann@402: + yann@402: +/* Lowest common denominator routine that can handle everything correctly, yann@402: + but slowly. */ yann@402: + yann@402: static void yann@402: -walk_wild_section (lang_wild_statement_type *ptr, yann@402: - lang_input_statement_type *file, yann@402: - callback_t callback, yann@402: - void *data) yann@402: +walk_wild_section_general (lang_wild_statement_type *ptr, yann@402: + lang_input_statement_type *file, yann@402: + callback_t callback, yann@402: + void *data) yann@402: { yann@402: asection *s; yann@402: - yann@402: - if (file->just_syms_flag) yann@402: - return; yann@402: + struct wildcard_list *sec; yann@402: yann@402: for (s = file->the_bfd->sections; s != NULL; s = s->next) yann@402: { yann@402: - struct wildcard_list *sec; yann@402: - yann@402: sec = ptr->section_list; yann@402: if (sec == NULL) yann@402: (*callback) (ptr, sec, s, file, data); yann@402: @@ -160,39 +207,8 @@ yann@402: while (sec != NULL) yann@402: { yann@402: bfd_boolean skip = FALSE; yann@402: - struct name_list *list_tmp; yann@402: - yann@402: - /* Don't process sections from files which were yann@402: - excluded. */ yann@402: - for (list_tmp = sec->spec.exclude_name_list; yann@402: - list_tmp; yann@402: - list_tmp = list_tmp->next) yann@402: - { yann@402: - if (wildcardp (list_tmp->name)) yann@402: - skip = fnmatch (list_tmp->name, file->filename, 0) == 0; yann@402: - else yann@402: - skip = strcmp (list_tmp->name, file->filename) == 0; yann@402: - yann@402: - /* If this file is part of an archive, and the archive is yann@402: - excluded, exclude this file. */ yann@402: - if (! skip && file->the_bfd != NULL yann@402: - && file->the_bfd->my_archive != NULL yann@402: - && file->the_bfd->my_archive->filename != NULL) yann@402: - { yann@402: - if (wildcardp (list_tmp->name)) yann@402: - skip = fnmatch (list_tmp->name, yann@402: - file->the_bfd->my_archive->filename, yann@402: - 0) == 0; yann@402: - else yann@402: - skip = strcmp (list_tmp->name, yann@402: - file->the_bfd->my_archive->filename) == 0; yann@402: - } yann@402: - yann@402: - if (skip) yann@402: - break; yann@402: - } yann@402: yann@402: - if (!skip && sec->spec.name != NULL) yann@402: + if (sec->spec.name != NULL) yann@402: { yann@402: const char *sname = bfd_get_section_name (file->the_bfd, s); yann@402: yann@402: @@ -203,13 +219,381 @@ yann@402: } yann@402: yann@402: if (!skip) yann@402: - (*callback) (ptr, sec, s, file, data); yann@402: + walk_wild_consider_section (ptr, file, s, sec, callback, data); yann@402: yann@402: sec = sec->next; yann@402: } yann@402: } yann@402: } yann@402: yann@402: +/* Routines to find a single section given its name. If there's more yann@402: + than one section with that name, we report that. */ yann@402: + yann@402: +typedef struct yann@402: +{ yann@402: + asection *found_section; yann@402: + bfd_boolean multiple_sections_found; yann@402: +} section_iterator_callback_data; yann@402: + yann@402: +static bfd_boolean yann@402: +section_iterator_callback (bfd *bfd ATTRIBUTE_UNUSED, asection *s, void *data) yann@402: +{ yann@402: + section_iterator_callback_data *d = data; yann@402: + yann@402: + if (d->found_section != NULL) yann@402: + { yann@402: + d->multiple_sections_found = TRUE; yann@402: + return TRUE; yann@402: + } yann@402: + yann@402: + d->found_section = s; yann@402: + return FALSE; yann@402: +} yann@402: + yann@402: +static asection * yann@402: +find_section (lang_input_statement_type *file, yann@402: + struct wildcard_list *sec, yann@402: + bfd_boolean *multiple_sections_found) yann@402: +{ yann@402: + section_iterator_callback_data cb_data = { NULL, FALSE }; yann@402: + yann@402: + bfd_get_section_by_name_if (file->the_bfd, sec->spec.name, yann@402: + section_iterator_callback, &cb_data); yann@402: + *multiple_sections_found = cb_data.multiple_sections_found; yann@402: + return cb_data.found_section; yann@402: +} yann@402: + yann@402: +/* Code for handling simple wildcards without going through fnmatch, yann@402: + which can be expensive because of charset translations etc. */ yann@402: + yann@402: +/* A simple wild is a literal string followed by a single '*', yann@402: + where the literal part is at least 4 characters long. */ yann@402: + yann@402: +static bfd_boolean yann@402: +is_simple_wild (const char *name) yann@402: +{ yann@402: + size_t len = strcspn (name, "*?["); yann@402: + return len >= 4 && name[len] == '*' && name[len + 1] == '\0'; yann@402: +} yann@402: + yann@402: +static bfd_boolean yann@402: +match_simple_wild (const char *pattern, const char *name) yann@402: +{ yann@402: + /* The first four characters of the pattern are guaranteed valid yann@402: + non-wildcard characters. So we can go faster. */ yann@402: + if (pattern[0] != name[0] || pattern[1] != name[1] yann@402: + || pattern[2] != name[2] || pattern[3] != name[3]) yann@402: + return FALSE; yann@402: + yann@402: + pattern += 4; yann@402: + name += 4; yann@402: + while (*pattern != '*') yann@402: + if (*name++ != *pattern++) yann@402: + return FALSE; yann@402: + yann@402: + return TRUE; yann@402: +} yann@402: + yann@402: +/* Specialized, optimized routines for handling different kinds of yann@402: + wildcards */ yann@402: + yann@402: +static void yann@402: +walk_wild_section_specs1_wild0 (lang_wild_statement_type *ptr, yann@402: + lang_input_statement_type *file, yann@402: + callback_t callback, yann@402: + void *data) yann@402: +{ yann@402: + /* We can just do a hash lookup for the section with the right name. yann@402: + But if that lookup discovers more than one section with the name yann@402: + (should be rare), we fall back to the general algorithm because yann@402: + we would otherwise have to sort the sections to make sure they yann@402: + get processed in the bfd's order. */ yann@402: + bfd_boolean multiple_sections_found; yann@402: + struct wildcard_list *sec0 = ptr->handler_data[0]; yann@402: + asection *s0 = find_section (file, sec0, &multiple_sections_found); yann@402: + yann@402: + if (multiple_sections_found) yann@402: + walk_wild_section_general (ptr, file, callback, data); yann@402: + else if (s0) yann@402: + walk_wild_consider_section (ptr, file, s0, sec0, callback, data); yann@402: +} yann@402: + yann@402: +static void yann@402: +walk_wild_section_specs1_wild1 (lang_wild_statement_type *ptr, yann@402: + lang_input_statement_type *file, yann@402: + callback_t callback, yann@402: + void *data) yann@402: +{ yann@402: + asection *s; yann@402: + struct wildcard_list *wildsec0 = ptr->handler_data[0]; yann@402: + yann@402: + for (s = file->the_bfd->sections; s != NULL; s = s->next) yann@402: + { yann@402: + const char *sname = bfd_get_section_name (file->the_bfd, s); yann@402: + bfd_boolean skip = !match_simple_wild (wildsec0->spec.name, sname); yann@402: + yann@402: + if (!skip) yann@402: + walk_wild_consider_section (ptr, file, s, wildsec0, callback, data); yann@402: + } yann@402: +} yann@402: + yann@402: +static void yann@402: +walk_wild_section_specs2_wild1 (lang_wild_statement_type *ptr, yann@402: + lang_input_statement_type *file, yann@402: + callback_t callback, yann@402: + void *data) yann@402: +{ yann@402: + asection *s; yann@402: + struct wildcard_list *sec0 = ptr->handler_data[0]; yann@402: + struct wildcard_list *wildsec1 = ptr->handler_data[1]; yann@402: + bfd_boolean multiple_sections_found; yann@402: + asection *s0 = find_section (file, sec0, &multiple_sections_found); yann@402: + yann@402: + if (multiple_sections_found) yann@402: + { yann@402: + walk_wild_section_general (ptr, file, callback, data); yann@402: + return; yann@402: + } yann@402: + yann@402: + /* Note that if the section was not found, s0 is NULL and yann@402: + we'll simply never succeed the s == s0 test below. */ yann@402: + for (s = file->the_bfd->sections; s != NULL; s = s->next) yann@402: + { yann@402: + /* Recall that in this code path, a section cannot satisfy more yann@402: + than one spec, so if s == s0 then it cannot match yann@402: + wildspec1. */ yann@402: + if (s == s0) yann@402: + walk_wild_consider_section (ptr, file, s, sec0, callback, data); yann@402: + else yann@402: + { yann@402: + const char *sname = bfd_get_section_name (file->the_bfd, s); yann@402: + bfd_boolean skip = !match_simple_wild (wildsec1->spec.name, sname); yann@402: + yann@402: + if (!skip) yann@402: + walk_wild_consider_section (ptr, file, s, wildsec1, callback, yann@402: + data); yann@402: + } yann@402: + } yann@402: +} yann@402: + yann@402: +static void yann@402: +walk_wild_section_specs3_wild2 (lang_wild_statement_type *ptr, yann@402: + lang_input_statement_type *file, yann@402: + callback_t callback, yann@402: + void *data) yann@402: +{ yann@402: + asection *s; yann@402: + struct wildcard_list *sec0 = ptr->handler_data[0]; yann@402: + struct wildcard_list *wildsec1 = ptr->handler_data[1]; yann@402: + struct wildcard_list *wildsec2 = ptr->handler_data[2]; yann@402: + bfd_boolean multiple_sections_found; yann@402: + asection *s0 = find_section (file, sec0, &multiple_sections_found); yann@402: + yann@402: + if (multiple_sections_found) yann@402: + { yann@402: + walk_wild_section_general (ptr, file, callback, data); yann@402: + return; yann@402: + } yann@402: + yann@402: + for (s = file->the_bfd->sections; s != NULL; s = s->next) yann@402: + { yann@402: + if (s == s0) yann@402: + walk_wild_consider_section (ptr, file, s, sec0, callback, data); yann@402: + else yann@402: + { yann@402: + const char *sname = bfd_get_section_name (file->the_bfd, s); yann@402: + bfd_boolean skip = !match_simple_wild (wildsec1->spec.name, sname); yann@402: + yann@402: + if (!skip) yann@402: + walk_wild_consider_section (ptr, file, s, wildsec1, callback, data); yann@402: + else yann@402: + { yann@402: + skip = !match_simple_wild (wildsec2->spec.name, sname); yann@402: + if (!skip) yann@402: + walk_wild_consider_section (ptr, file, s, wildsec2, callback, yann@402: + data); yann@402: + } yann@402: + } yann@402: + } yann@402: +} yann@402: + yann@402: +static void yann@402: +walk_wild_section_specs4_wild2 (lang_wild_statement_type *ptr, yann@402: + lang_input_statement_type *file, yann@402: + callback_t callback, yann@402: + void *data) yann@402: +{ yann@402: + asection *s; yann@402: + struct wildcard_list *sec0 = ptr->handler_data[0]; yann@402: + struct wildcard_list *sec1 = ptr->handler_data[1]; yann@402: + struct wildcard_list *wildsec2 = ptr->handler_data[2]; yann@402: + struct wildcard_list *wildsec3 = ptr->handler_data[3]; yann@402: + bfd_boolean multiple_sections_found; yann@402: + asection *s0 = find_section (file, sec0, &multiple_sections_found), *s1; yann@402: + yann@402: + if (multiple_sections_found) yann@402: + { yann@402: + walk_wild_section_general (ptr, file, callback, data); yann@402: + return; yann@402: + } yann@402: + yann@402: + s1 = find_section (file, sec1, &multiple_sections_found); yann@402: + if (multiple_sections_found) yann@402: + { yann@402: + walk_wild_section_general (ptr, file, callback, data); yann@402: + return; yann@402: + } yann@402: + yann@402: + for (s = file->the_bfd->sections; s != NULL; s = s->next) yann@402: + { yann@402: + if (s == s0) yann@402: + walk_wild_consider_section (ptr, file, s, sec0, callback, data); yann@402: + else yann@402: + if (s == s1) yann@402: + walk_wild_consider_section (ptr, file, s, sec1, callback, data); yann@402: + else yann@402: + { yann@402: + const char *sname = bfd_get_section_name (file->the_bfd, s); yann@402: + bfd_boolean skip = !match_simple_wild (wildsec2->spec.name, yann@402: + sname); yann@402: + yann@402: + if (!skip) yann@402: + walk_wild_consider_section (ptr, file, s, wildsec2, callback, yann@402: + data); yann@402: + else yann@402: + { yann@402: + skip = !match_simple_wild (wildsec3->spec.name, sname); yann@402: + if (!skip) yann@402: + walk_wild_consider_section (ptr, file, s, wildsec3, yann@402: + callback, data); yann@402: + } yann@402: + } yann@402: + } yann@402: +} yann@402: + yann@402: +static void yann@402: +walk_wild_section (lang_wild_statement_type *ptr, yann@402: + lang_input_statement_type *file, yann@402: + callback_t callback, yann@402: + void *data) yann@402: +{ yann@402: + if (file->just_syms_flag) yann@402: + return; yann@402: + yann@402: + (*ptr->walk_wild_section_handler) (ptr, file, callback, data); yann@402: +} yann@402: + yann@402: +/* Returns TRUE when name1 is a wildcard spec that might match yann@402: + something name2 can match. We're conservative: we return FALSE yann@402: + only if the prefixes of name1 and name2 are different up to the yann@402: + first wildcard character. */ yann@402: + yann@402: +static bfd_boolean yann@402: +wild_spec_can_overlap (const char *name1, const char *name2) yann@402: +{ yann@402: + size_t prefix1_len = strcspn (name1, "?*["); yann@402: + size_t prefix2_len = strcspn (name2, "?*["); yann@402: + size_t min_prefix_len; yann@402: + yann@402: + /* Note that if there is no wildcard character, then we treat the yann@402: + terminating 0 as part of the prefix. Thus ".text" won't match yann@402: + ".text." or ".text.*", for example. */ yann@402: + if (name1[prefix1_len] == '\0') yann@402: + prefix1_len++; yann@402: + if (name2[prefix2_len] == '\0') yann@402: + prefix2_len++; yann@402: + yann@402: + min_prefix_len = prefix1_len < prefix2_len ? prefix1_len : prefix2_len; yann@402: + yann@402: + return memcmp (name1, name2, min_prefix_len) == 0; yann@402: +} yann@402: + yann@402: +/* Select specialized code to handle various kinds of wildcard yann@402: + statements. */ yann@402: + yann@402: +static void yann@402: +analyze_walk_wild_section_handler (lang_wild_statement_type *ptr) yann@402: +{ yann@402: + int sec_count = 0; yann@402: + int wild_name_count = 0; yann@402: + struct wildcard_list *sec; yann@402: + int signature; yann@402: + int data_counter; yann@402: + yann@402: + ptr->walk_wild_section_handler = walk_wild_section_general; yann@402: + yann@402: + /* Count how many wildcard_specs there are, and how many of those yann@402: + actually use wildcards in the name. Also, bail out if any of the yann@402: + wildcard names are NULL. (Can this actually happen? yann@402: + walk_wild_section used to test for it.) And bail out if any yann@402: + of the wildcards are more complex than a simple string yann@402: + ending in a single '*'. */ yann@402: + for (sec = ptr->section_list; sec != NULL; sec = sec->next) yann@402: + { yann@402: + ++sec_count; yann@402: + if (sec->spec.name == NULL) yann@402: + return; yann@402: + if (wildcardp (sec->spec.name)) yann@402: + { yann@402: + ++wild_name_count; yann@402: + if (!is_simple_wild (sec->spec.name)) yann@402: + return; yann@402: + } yann@402: + } yann@402: + yann@402: + /* The zero-spec case would be easy to optimize but it doesn't yann@402: + happen in practice. Likewise, more than 4 specs doesn't yann@402: + happen in practice. */ yann@402: + if (sec_count == 0 || sec_count > 4) yann@402: + return; yann@402: + yann@402: + /* Check that no two specs can match the same section. */ yann@402: + for (sec = ptr->section_list; sec != NULL; sec = sec->next) yann@402: + { yann@402: + struct wildcard_list *sec2; yann@402: + for (sec2 = sec->next; sec2 != NULL; sec2 = sec2->next) yann@402: + { yann@402: + if (wild_spec_can_overlap (sec->spec.name, sec2->spec.name)) yann@402: + return; yann@402: + } yann@402: + } yann@402: + yann@402: + signature = (sec_count << 8) + wild_name_count; yann@402: + switch (signature) yann@402: + { yann@402: + case 0x0100: yann@402: + ptr->walk_wild_section_handler = walk_wild_section_specs1_wild0; yann@402: + break; yann@402: + case 0x0101: yann@402: + ptr->walk_wild_section_handler = walk_wild_section_specs1_wild1; yann@402: + break; yann@402: + case 0x0201: yann@402: + ptr->walk_wild_section_handler = walk_wild_section_specs2_wild1; yann@402: + break; yann@402: + case 0x0302: yann@402: + ptr->walk_wild_section_handler = walk_wild_section_specs3_wild2; yann@402: + break; yann@402: + case 0x0402: yann@402: + ptr->walk_wild_section_handler = walk_wild_section_specs4_wild2; yann@402: + break; yann@402: + default: yann@402: + return; yann@402: + } yann@402: + yann@402: + /* Now fill the data array with pointers to the specs, first the yann@402: + specs with non-wildcard names, then the specs with wildcard yann@402: + names. It's OK to process the specs in different order from the yann@402: + given order, because we've already determined that no section yann@402: + will match more than one spec. */ yann@402: + data_counter = 0; yann@402: + for (sec = ptr->section_list; sec != NULL; sec = sec->next) yann@402: + if (!wildcardp (sec->spec.name)) yann@402: + ptr->handler_data[data_counter++] = sec; yann@402: + for (sec = ptr->section_list; sec != NULL; sec = sec->next) yann@402: + if (wildcardp (sec->spec.name)) yann@402: + ptr->handler_data[data_counter++] = sec; yann@402: +} yann@402: + yann@402: /* Handle a wild statement for a single file F. */ yann@402: yann@402: static void yann@402: @@ -4353,6 +4737,7 @@ yann@402: new->section_list = section_list; yann@402: new->keep_sections = keep_sections; yann@402: lang_list_init (&new->children); yann@402: + analyze_walk_wild_section_handler (new); yann@402: } yann@402: yann@402: void yann@402: --- binutils-2.15/ld/ldlang.h.old 2004-05-17 15:36:16.000000000 -0400 yann@402: +++ binutils-2.15/ld/ldlang.h 2006-01-23 13:32:33.653292000 -0500 yann@402: @@ -295,7 +295,17 @@ yann@402: union lang_statement_union *file; yann@402: } lang_afile_asection_pair_statement_type; yann@402: yann@402: -typedef struct lang_wild_statement_struct yann@402: +typedef struct lang_wild_statement_struct lang_wild_statement_type; yann@402: + yann@402: +typedef void (*callback_t) (lang_wild_statement_type *, struct wildcard_list *, yann@402: + asection *, lang_input_statement_type *, void *); yann@402: + yann@402: +typedef void (*walk_wild_section_handler_t) (lang_wild_statement_type *, yann@402: + lang_input_statement_type *, yann@402: + callback_t callback, yann@402: + void *data); yann@402: + yann@402: +struct lang_wild_statement_struct yann@402: { yann@402: lang_statement_header_type header; yann@402: const char *filename; yann@402: @@ -303,7 +313,10 @@ yann@402: struct wildcard_list *section_list; yann@402: bfd_boolean keep_sections; yann@402: lang_statement_list_type children; yann@402: -} lang_wild_statement_type; yann@402: + yann@402: + walk_wild_section_handler_t walk_wild_section_handler; yann@402: + struct wildcard_list *handler_data[4]; yann@402: +}; yann@402: yann@402: typedef struct lang_address_statement_struct yann@402: {