yann@402: http://gcc.gnu.org/PR20973 yann@402: yann@402: "gcc 4 (about RC1) miscompiles khtml, in fact something in CSS, which basically yann@402: leads to all websites being misrendered. I can't easily reduce the testcase, yann@402: but have applied the whole preprocessed source of css/cssstyleselector.ii. yann@402: yann@402: It is to be compiled with g++ -O2 -fPIC -march=i586 -mtune=i686 yann@402: -fno-exceptions. A more detailed analysis will follow, as we've found out yann@402: some things already." yann@402: yann@402: --- yann@402: yann@402: Subject: Bug 20973 yann@402: yann@402: CVSROOT: /cvs/gcc yann@402: Module name: gcc yann@402: Branch: gcc-4_0-branch yann@402: Changes by: matz@gcc.gnu.org 2005-04-22 17:30:21 yann@402: yann@402: Modified files: yann@402: gcc : ChangeLog reload.c yann@402: yann@402: Log message: yann@402: PR middle-end/20973 yann@402: * reload.c (push_reload, find_dummy_reload): Check for uninitialized yann@402: pseudos. yann@402: yann@402: Patches: yann@402: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=2.7592.2.177&r2=2.7592.2.178 yann@402: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/reload.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.268&r2=1.268.2.1 yann@402: yann@402: --- yann@402: yann@402: =================================================================== yann@402: RCS file: /cvs/gcc/gcc/gcc/reload.c,v yann@402: retrieving revision 1.268 yann@402: retrieving revision 1.268.2.1 yann@402: diff -u -r1.268 -r1.268.2.1 yann@402: --- gcc/gcc/reload.c 2005/02/24 22:06:06 1.268 yann@402: +++ gcc/gcc/reload.c 2005/04/22 17:30:15 1.268.2.1 yann@402: @@ -1520,7 +1520,7 @@ yann@402: But if there is no spilling in this block, that is OK. yann@402: An explicitly used hard reg cannot be a spill reg. */ yann@402: yann@402: - if (rld[i].reg_rtx == 0 && in != 0) yann@402: + if (rld[i].reg_rtx == 0 && in != 0 && hard_regs_live_known) yann@402: { yann@402: rtx note; yann@402: int regno; yann@402: @@ -1534,6 +1534,11 @@ yann@402: && REG_P (XEXP (note, 0)) yann@402: && (regno = REGNO (XEXP (note, 0))) < FIRST_PSEUDO_REGISTER yann@402: && reg_mentioned_p (XEXP (note, 0), in) yann@402: + /* Check that we don't use a hardreg for an uninitialized yann@402: + pseudo. See also find_dummy_reload(). */ yann@402: + && (ORIGINAL_REGNO (XEXP (note, 0)) < FIRST_PSEUDO_REGISTER yann@402: + || ! bitmap_bit_p (ENTRY_BLOCK_PTR->global_live_at_end, yann@402: + ORIGINAL_REGNO (XEXP (note, 0)))) yann@402: && ! refers_to_regno_for_reload_p (regno, yann@402: (regno yann@402: + hard_regno_nregs[regno] yann@402: @@ -1997,7 +2002,17 @@ yann@402: is a subreg, and in that case, out yann@402: has a real mode. */ yann@402: (GET_MODE (out) != VOIDmode yann@402: - ? GET_MODE (out) : outmode))) yann@402: + ? GET_MODE (out) : outmode)) yann@402: + /* But only do all this if we can be sure, that this input yann@402: + operand doesn't correspond with an uninitialized pseudoreg. yann@402: + global can assign some hardreg to it, which is the same as yann@402: + a different pseudo also currently live (as it can ignore the yann@402: + conflict). So we never must introduce writes to such hardregs, yann@402: + as they would clobber the other live pseudo using the same. yann@402: + See also PR20973. */ yann@402: + && (ORIGINAL_REGNO (in) < FIRST_PSEUDO_REGISTER yann@402: + || ! bitmap_bit_p (ENTRY_BLOCK_PTR->global_live_at_end, yann@402: + ORIGINAL_REGNO (in)))) yann@402: { yann@402: unsigned int regno = REGNO (in) + in_offset; yann@402: unsigned int nwords = hard_regno_nregs[regno][inmode];