yann@1: Fixes yann@1: dl-runtime.c:56: error: conflicting types for 'fixup' yann@1: ../sysdeps/i386/dl-machine.h:158: error: previous declaration of 'fixup' was here yann@1: when building with gcc-3.4.0 yann@1: yann@1: First hunk: yann@1: Define ARCH_FIXUP_ATTRIBUTE and use it in the fixup function declarations. yann@1: http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/i386/dl-machine.h.diff?r1=1.124&r2=1.125&cvsroot=glibc yann@1: [rediffed against glibc-2.1.3] yann@1: yann@1: Second hunk: yann@1: If ARCH_FIXUP_ATTRIBUTE is not defined, provide dummy definition. yann@1: Use macro in fixup function definitions. yann@1: http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/elf/dl-runtime.c.diff?r1=1.64&r2=1.65&cvsroot=glibc yann@1: [rediffed against glibc-2.3.2] yann@1: yann@1: =================================================================== yann@1: --- glibc-2.1.3/sysdeps/i386/dl-machine.h.old Sun Apr 11 18:58:45 2004 yann@1: +++ glibc-2.1.3/sysdeps/i386/dl-machine.h Sun Apr 11 18:59:51 2004 yann@1: @@ -70,11 +70,14 @@ yann@1: yann@1: We cannot use this scheme for profiling because the _mcount call yann@1: destroys the passed register information. */ yann@1: + yann@1: +#define ARCH_FIXUP_ATTRIBUTE __attribute__ ((regparm (3), unused)) yann@1: + yann@1: static ElfW(Addr) fixup (struct link_map *l, ElfW(Word) reloc_offset) yann@1: - __attribute__ ((regparm (2), unused)); yann@1: + ARCH_FIXUP_ATTRIBUTE; yann@1: static ElfW(Addr) profile_fixup (struct link_map *l, ElfW(Word) reloc_offset, yann@1: ElfW(Addr) retaddr) yann@1: - __attribute__ ((regparm (3), unused)); yann@1: + ARCH_FIXUP_ATTRIBUTE; yann@1: #endif yann@1: yann@1: /* Set up the loaded object described by L so its unrelocated PLT yann@1: =================================================================== yann@1: --- glibc-2.1.3/elf/dl-runtime.c~ Thu Jul 15 11:32:41 1999 yann@1: +++ glibc-2.1.3/elf/dl-runtime.c Sun Apr 11 19:02:01 2004 yann@1: @@ -31,6 +31,12 @@ yann@1: # define VERSYMIDX(sym) (DT_NUM + DT_PROCNUM + DT_VERSIONTAGIDX (sym)) yann@1: #endif yann@1: yann@1: +/* The fixup functions might have need special attributes. If none yann@1: + are provided define the macro as empty. */ yann@1: +#ifndef ARCH_FIXUP_ATTRIBUTE yann@1: +# define ARCH_FIXUP_ATTRIBUTE yann@1: +#endif yann@1: + yann@1: yann@1: /* This function is called through a special trampoline from the PLT the yann@1: first time each PLT entry is called. We must perform the relocation yann@1: @@ -40,7 +46,7 @@ yann@1: function. */ yann@1: yann@1: #ifndef ELF_MACHINE_NO_PLT yann@1: -static ElfW(Addr) __attribute__ ((unused)) yann@1: +static ElfW(Addr) __attribute__ ((unused)) ARCH_FIXUP_ATTRIBUTE yann@1: fixup ( yann@1: # ifdef ELF_MACHINE_RUNTIME_FIXUP_ARGS yann@1: ELF_MACHINE_RUNTIME_FIXUP_ARGS, yann@1: @@ -105,7 +111,7 @@ yann@1: yann@1: #if !defined PROF && !defined ELF_MACHINE_NO_PLT yann@1: yann@1: -static ElfW(Addr) __attribute__ ((unused)) yann@1: +static ElfW(Addr) __attribute__ ((unused)) ARCH_FIXUP_ATTRIBUTE yann@1: profile_fixup ( yann@1: #ifdef ELF_MACHINE_RUNTIME_FIXUP_ARGS yann@1: ELF_MACHINE_RUNTIME_FIXUP_ARGS,