yann@1: http://sources.redhat.com/ml/libc-hacker/2004-02/msg00005.html yann@1: [Also in CVS, but the original patch is easier to get.] yann@1: yann@1: Fixes errors like yann@1: yann@1: clnt_perr.c: In function `_buf': yann@1: clnt_perr.c:67: error: invalid lvalue in assignment yann@1: yann@1: when building with gcc-3.5. yann@1: yann@1: To: libc-hacker at sources dot redhat dot com yann@1: Subject: Fix cast as lvalue in sunrpc yann@1: From: Andreas Schwab yann@1: X-Yow: SHHHH!! I hear SIX TATTOOED TRUCK-DRIVERS tossing ENGINE BLOCKS yann@1: into empty OIL DRUMS dot dot yann@1: Date: Sun, 08 Feb 2004 17:38:31 +0100 yann@1: Message-ID: yann@1: yann@1: This fixes the uses of casts as lvalue in the sunrpc code. yann@1: yann@1: Andreas. yann@1: yann@1: 2004-02-08 Andreas Schwab yann@1: yann@1: * include/rpc/rpc.h: Declare thread variables with their correct yann@1: type. yann@1: * sunrpc/clnt_perr.c: Don't cast thread variables. yann@1: * sunrpc/clnt_raw.c: Likewise. yann@1: * sunrpc/clnt_simp.c: Likewise. yann@1: * sunrpc/key_call.c: Likewise. yann@1: * sunrpc/svcauth_des.c: Likewise. yann@1: * sunrpc/svc.c: Likewise. yann@1: * sunrpc/svc_raw.c: Likewise. yann@1: * sunrpc/svc_simple.c: Likewise. yann@1: yann@1: Index: include/rpc/rpc.h yann@1: =================================================================== yann@1: RCS file: /cvs/glibc/libc/include/rpc/rpc.h,v yann@1: retrieving revision 1.8 yann@1: diff -u -p -a -r1.8 rpc.h yann@1: --- glibc/include/rpc/rpc.h 5 Aug 2002 22:10:59 -0000 1.8 yann@1: +++ glibc/include/rpc/rpc.h 8 Feb 2004 14:19:14 -0000 yann@1: @@ -17,24 +17,24 @@ struct rpc_thread_variables { yann@1: struct pollfd *svc_pollfd_s; /* Global, rpc_common.c */ yann@1: int svc_max_pollfd_s; /* Global, rpc_common.c */ yann@1: yann@1: - void *clnt_perr_buf_s; /* clnt_perr.c */ yann@1: + char *clnt_perr_buf_s; /* clnt_perr.c */ yann@1: yann@1: - void *clntraw_private_s; /* clnt_raw.c */ yann@1: + struct clntraw_private_s *clntraw_private_s; /* clnt_raw.c */ yann@1: yann@1: - void *callrpc_private_s; /* clnt_simp.c */ yann@1: + struct callrpc_private_s *callrpc_private_s; /* clnt_simp.c */ yann@1: yann@1: - void *key_call_private_s; /* key_call.c */ yann@1: + struct key_call_private *key_call_private_s; /* key_call.c */ yann@1: yann@1: - void *authdes_cache_s; /* svcauth_des.c */ yann@1: - void *authdes_lru_s; /* svcauth_des.c */ yann@1: + struct cache_entry *authdes_cache_s; /* svcauth_des.c */ yann@1: + int *authdes_lru_s; /* svcauth_des.c */ yann@1: yann@1: - void *svc_xports_s; /* svc.c */ yann@1: - void *svc_head_s; /* svc.c */ yann@1: + SVCXPRT **svc_xports_s; /* svc.c */ yann@1: + struct svc_callout *svc_head_s; /* svc.c */ yann@1: yann@1: - void *svcraw_private_s; /* svc_raw.c */ yann@1: + struct svcraw_private_s *svcraw_private_s; /* svc_raw.c */ yann@1: yann@1: - void *svcsimple_proglst_s; /* svc_simple.c */ yann@1: - void *svcsimple_transp_s; /* svc_simple.c */ yann@1: + struct proglst_ *svcsimple_proglst_s; /* svc_simple.c */ yann@1: + SVCXPRT *svcsimple_transp_s; /* svc_simple.c */ yann@1: }; yann@1: yann@1: extern struct rpc_thread_variables *__rpc_thread_variables(void) yann@1: Index: sunrpc/clnt_perr.c yann@1: =================================================================== yann@1: RCS file: /cvs/glibc/libc/sunrpc/clnt_perr.c,v yann@1: retrieving revision 1.19 yann@1: diff -u -p -a -r1.19 clnt_perr.c yann@1: --- glibc/sunrpc/clnt_perr.c 1 Nov 2002 20:43:54 -0000 1.19 yann@1: +++ glibc/sunrpc/clnt_perr.c 8 Feb 2004 14:19:14 -0000 yann@1: @@ -55,7 +55,7 @@ static char *auth_errmsg (enum auth_stat yann@1: * buf variable in a few functions. Overriding a global variable yann@1: * with a local variable of the same name is a bad idea, anyway. yann@1: */ yann@1: -#define buf ((char *)RPC_THREAD_VARIABLE(clnt_perr_buf_s)) yann@1: +#define buf RPC_THREAD_VARIABLE(clnt_perr_buf_s) yann@1: #else yann@1: static char *buf; yann@1: #endif yann@1: Index: sunrpc/clnt_raw.c yann@1: =================================================================== yann@1: RCS file: /cvs/glibc/libc/sunrpc/clnt_raw.c,v yann@1: retrieving revision 1.10 yann@1: diff -u -p -a -r1.10 clnt_raw.c yann@1: --- glibc/sunrpc/clnt_raw.c 15 May 2002 00:21:00 -0000 1.10 yann@1: +++ glibc/sunrpc/clnt_raw.c 8 Feb 2004 14:19:14 -0000 yann@1: @@ -61,7 +61,7 @@ struct clntraw_private_s yann@1: u_int mcnt; yann@1: }; yann@1: #ifdef _RPC_THREAD_SAFE_ yann@1: -#define clntraw_private ((struct clntraw_private_s *)RPC_THREAD_VARIABLE(clntraw_private_s)) yann@1: +#define clntraw_private RPC_THREAD_VARIABLE(clntraw_private_s) yann@1: #else yann@1: static struct clntraw_private_s *clntraw_private; yann@1: #endif yann@1: Index: sunrpc/clnt_simp.c yann@1: =================================================================== yann@1: RCS file: /cvs/glibc/libc/sunrpc/clnt_simp.c,v yann@1: retrieving revision 1.14 yann@1: diff -u -p -a -r1.14 clnt_simp.c yann@1: --- glibc/sunrpc/clnt_simp.c 15 May 2002 00:21:00 -0000 1.14 yann@1: +++ glibc/sunrpc/clnt_simp.c 8 Feb 2004 14:19:14 -0000 yann@1: @@ -55,7 +55,7 @@ struct callrpc_private_s yann@1: char *oldhost; yann@1: }; yann@1: #ifdef _RPC_THREAD_SAFE_ yann@1: -#define callrpc_private ((struct callrpc_private_s *)RPC_THREAD_VARIABLE(callrpc_private_s)) yann@1: +#define callrpc_private RPC_THREAD_VARIABLE(callrpc_private_s) yann@1: #else yann@1: static struct callrpc_private_s *callrpc_private; yann@1: #endif yann@1: Index: sunrpc/key_call.c yann@1: =================================================================== yann@1: RCS file: /cvs/glibc/libc/sunrpc/key_call.c,v yann@1: retrieving revision 1.16 yann@1: diff -u -p -a -r1.16 key_call.c yann@1: --- glibc/sunrpc/key_call.c 6 Aug 2002 06:08:50 -0000 1.16 yann@1: +++ glibc/sunrpc/key_call.c 8 Feb 2004 14:19:14 -0000 yann@1: @@ -370,7 +370,7 @@ struct key_call_private { yann@1: uid_t uid; /* user-id at last authorization */ yann@1: }; yann@1: #ifdef _RPC_THREAD_SAFE_ yann@1: -#define key_call_private_main ((struct key_call_private *)RPC_THREAD_VARIABLE(key_call_private_s)) yann@1: +#define key_call_private_main RPC_THREAD_VARIABLE(key_call_private_s) yann@1: #else yann@1: static struct key_call_private *key_call_private_main; yann@1: #endif yann@1: Index: sunrpc/svc.c yann@1: =================================================================== yann@1: RCS file: /cvs/glibc/libc/sunrpc/svc.c,v yann@1: retrieving revision 1.17 yann@1: diff -u -p -a -r1.17 svc.c yann@1: --- glibc/sunrpc/svc.c 29 Aug 2003 07:45:18 -0000 1.17 yann@1: +++ glibc/sunrpc/svc.c 8 Feb 2004 14:19:14 -0000 yann@1: @@ -44,7 +44,7 @@ yann@1: #include yann@1: yann@1: #ifdef _RPC_THREAD_SAFE_ yann@1: -#define xports ((SVCXPRT **)RPC_THREAD_VARIABLE(svc_xports_s)) yann@1: +#define xports RPC_THREAD_VARIABLE(svc_xports_s) yann@1: #else yann@1: static SVCXPRT **xports; yann@1: #endif yann@1: @@ -63,7 +63,7 @@ struct svc_callout { yann@1: void (*sc_dispatch) (struct svc_req *, SVCXPRT *); yann@1: }; yann@1: #ifdef _RPC_THREAD_SAFE_ yann@1: -#define svc_head ((struct svc_callout *)RPC_THREAD_VARIABLE(svc_head_s)) yann@1: +#define svc_head RPC_THREAD_VARIABLE(svc_head_s) yann@1: #else yann@1: static struct svc_callout *svc_head; yann@1: #endif yann@1: Index: sunrpc/svc_raw.c yann@1: =================================================================== yann@1: RCS file: /cvs/glibc/libc/sunrpc/svc_raw.c,v yann@1: retrieving revision 1.5 yann@1: diff -u -p -a -r1.5 svc_raw.c yann@1: --- glibc/sunrpc/svc_raw.c 26 Feb 2002 01:43:56 -0000 1.5 yann@1: +++ glibc/sunrpc/svc_raw.c 8 Feb 2004 14:19:14 -0000 yann@1: @@ -54,7 +54,7 @@ struct svcraw_private_s yann@1: char verf_body[MAX_AUTH_BYTES]; yann@1: }; yann@1: #ifdef _RPC_THREAD_SAFE_ yann@1: -#define svcraw_private ((struct svcraw_private_s *)RPC_THREAD_VARIABLE(svcraw_private_s)) yann@1: +#define svcraw_private RPC_THREAD_VARIABLE(svcraw_private_s) yann@1: #else yann@1: static struct svcraw_private_s *svcraw_private; yann@1: #endif yann@1: Index: sunrpc/svc_simple.c yann@1: =================================================================== yann@1: RCS file: /cvs/glibc/libc/sunrpc/svc_simple.c,v yann@1: retrieving revision 1.16 yann@1: diff -u -p -a -r1.16 svc_simple.c yann@1: --- glibc/sunrpc/svc_simple.c 6 Aug 2002 05:10:30 -0000 1.16 yann@1: +++ glibc/sunrpc/svc_simple.c 8 Feb 2004 14:19:14 -0000 yann@1: @@ -61,7 +61,7 @@ struct proglst_ yann@1: struct proglst_ *p_nxt; yann@1: }; yann@1: #ifdef _RPC_THREAD_SAFE_ yann@1: -#define proglst ((struct proglst_ *)RPC_THREAD_VARIABLE(svcsimple_proglst_s)) yann@1: +#define proglst RPC_THREAD_VARIABLE(svcsimple_proglst_s) yann@1: #else yann@1: static struct proglst_ *proglst; yann@1: #endif yann@1: @@ -69,7 +69,7 @@ static struct proglst_ *proglst; yann@1: yann@1: static void universal (struct svc_req *rqstp, SVCXPRT *transp_s); yann@1: #ifdef _RPC_THREAD_SAFE_ yann@1: -#define transp ((SVCXPRT *)RPC_THREAD_VARIABLE(svcsimple_transp_s)) yann@1: +#define transp RPC_THREAD_VARIABLE(svcsimple_transp_s) yann@1: #else yann@1: static SVCXPRT *transp; yann@1: #endif yann@1: Index: sunrpc/svcauth_des.c yann@1: =================================================================== yann@1: RCS file: /cvs/glibc/libc/sunrpc/svcauth_des.c,v yann@1: retrieving revision 1.8 yann@1: diff -u -p -a -r1.8 svcauth_des.c yann@1: --- glibc/sunrpc/svcauth_des.c 20 Aug 2001 06:37:09 -0000 1.8 yann@1: +++ glibc/sunrpc/svcauth_des.c 8 Feb 2004 14:19:14 -0000 yann@1: @@ -72,8 +72,8 @@ struct cache_entry yann@1: char *localcred; /* generic local credential */ yann@1: }; yann@1: #ifdef _RPC_THREAD_SAFE_ yann@1: -#define authdes_cache ((struct cache_entry *)RPC_THREAD_VARIABLE(authdes_cache_s)) yann@1: -#define authdes_lru ((int *)RPC_THREAD_VARIABLE(authdes_lru_s)) yann@1: +#define authdes_cache RPC_THREAD_VARIABLE(authdes_cache_s) yann@1: +#define authdes_lru RPC_THREAD_VARIABLE(authdes_lru_s) yann@1: #else yann@1: static struct cache_entry *authdes_cache; yann@1: static int *authdes_lru; yann@1: yann@1: -- yann@1: Andreas Schwab, SuSE Labs, schwab@suse.de yann@1: SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany yann@1: Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 yann@1: "And now for something completely different." yann@1: