# HG changeset patch # User "Yann E. MORIN" # Date 1295732118 -3600 # Node ID 2f0e9d2cfce573467198a7498489783fc348574c # Parent c6d2311442ad860773b5e35aae3cfb83eb918a12 libc/glibc: commonalise assembling the list of addons glibc and eglibc each have two very similar ways of building this list. This can, and should definitetly, be shared. Signed-off-by: "Yann E. MORIN" diff -r c6d2311442ad -r 2f0e9d2cfce5 scripts/build/libc/glibc-eglibc.sh-common --- a/scripts/build/libc/glibc-eglibc.sh-common Sat Jan 22 22:35:02 2011 +0100 +++ b/scripts/build/libc/glibc-eglibc.sh-common Sat Jan 22 22:35:18 2011 +0100 @@ -243,14 +243,16 @@ # Build up the addons list, separated with $1 do_libc_add_ons_list() { local sep="$1" - local addons_list=$(echo "${CT_LIBC_ADDONS_LIST//,/${sep}}" |tr -s ,) + local addons_list="$( echo "${CT_LIBC_ADDONS_LIST}" \ + |sed -r -e "s/[[:space:],]/${sep}/g;" \ + )" case "${CT_THREADS}" in none) ;; *) addons_list="${addons_list}${sep}${CT_THREADS}";; esac [ "${CT_LIBC_GLIBC_USE_PORTS}" = "y" ] && addons_list="${addons_list}${sep}ports" - addons_list="${addons_list%%${sep}}" - echo "${addons_list##${sep}}" + # Remove duplicate, leading and trailing separators + echo "${addons_list}" |sed -r -e "s/${sep}+/${sep}/g; s/^${sep}//; s/${sep}\$//;" } # Compute up the minimum supported Linux kernel version diff -r c6d2311442ad -r 2f0e9d2cfce5 scripts/build/libc/glibc.sh --- a/scripts/build/libc/glibc.sh Sat Jan 22 22:35:02 2011 +0100 +++ b/scripts/build/libc/glibc.sh Sat Jan 22 22:35:18 2011 +0100 @@ -263,16 +263,3 @@ CT_EndStep } - -# Build up the addons list, separated with $1 -do_libc_add_ons_list() { - local sep="$1" - local addons_list=$(echo "${CT_LIBC_ADDONS_LIST}" |sed -r -e "s/[ ,]/${sep}/g;") - case "${CT_THREADS}" in - none) ;; - *) addons_list="${addons_list}${sep}${CT_THREADS}";; - esac - [ "${CT_LIBC_GLIBC_USE_PORTS}" = "y" ] && addons_list="${addons_list}${sep}ports" - # Remove duplicate, leading and trailing separators - echo "${addons_list}" |sed -r -e "s/${sep}+/${sep}/g; s/^${sep}//; s/${sep}\$//;" -}