# HG changeset patch # User "Yann E. MORIN" # Date 1277243363 -7200 # Node ID eebcaff6626f09af4f69b7b06f1246a06769d0af # Parent 1974075aa6413afd78dea3c2dbee21788d30bd9e scripts/wrapper: fix wrong test when checking access to the reall tool In C, the proper syntax for a bit-wise OR is a single '|', not two. It worked so far because all was well: - X_OK == 1 - R_OK||X_OK == 1 - the file we searched for had the x-bit set -> access( file, R_OK||X_OK ) worked - inicidentally, the file we searched for also had the r-bit set, but we were not testing that in fact. diff -r 1974075aa641 -r eebcaff6626f scripts/wrapper.c --- a/scripts/wrapper.c Thu Jun 17 21:26:23 2010 +0200 +++ b/scripts/wrapper.c Tue Jun 22 23:49:23 2010 +0200 @@ -71,7 +71,7 @@ if( stat( testname, &st ) == 0 ) { /* OK, exists. Is it a regular file, or a * symlink, which the current user may execute? */ - if( S_ISREG( st.st_mode ) && ! access( testname, X_OK || R_OK ) ) { + if( S_ISREG( st.st_mode ) && ! access( testname, X_OK | R_OK ) ) { fullname = strdup( testname ); break; }