summaryrefslogtreecommitdiff
path: root/packages/glibc-linaro
diff options
context:
space:
mode:
authorAlexey Neyman <stilor@att.net>2018-05-12 20:00:41 (GMT)
committerAlexey Neyman <stilor@att.net>2018-05-12 20:03:29 (GMT)
commit387c8d8e2c89d94d41c76479ee9571c60e824ac3 (patch)
tree55446e0fad0d390157ab44d8ec5e8007c7f439bc /packages/glibc-linaro
parent7d3d4d9e7484b8e48336f7ba4b934661b1562fb8 (diff)
First batch of fixes
- Incompatible function type for ifunc alias - Multiple statements macro expansion in strftime - if_nametoindex size checking Signed-off-by: Alexey Neyman <stilor@att.net>
Diffstat (limited to 'packages/glibc-linaro')
-rw-r--r--packages/glibc-linaro/2.20-2014.11/0011-strftime-multiple-stmts.patch73
-rw-r--r--packages/glibc-linaro/2.20-2014.11/0012-if_nametoindex-size-check.patch29
2 files changed, 102 insertions, 0 deletions
diff --git a/packages/glibc-linaro/2.20-2014.11/0011-strftime-multiple-stmts.patch b/packages/glibc-linaro/2.20-2014.11/0011-strftime-multiple-stmts.patch
new file mode 100644
index 0000000..0f97e7d
--- /dev/null
+++ b/packages/glibc-linaro/2.20-2014.11/0011-strftime-multiple-stmts.patch
@@ -0,0 +1,73 @@
+commit e4043b84c49e1cf9bcf1e8320233343ecc34f8eb
+Author: Joseph Myers <joseph@codesourcery.com>
+Date: Tue Jun 27 17:12:13 2017 +0000
+
+ Fix strftime build with GCC 8.
+
+ Building with current GCC mainline fails with:
+
+ strftime_l.c: In function '__strftime_internal':
+ strftime_l.c:719:4: error: macro expands to multiple statements [-Werror=multistatement-macros]
+ digits = d > width ? d : width; \
+ ^
+ strftime_l.c:1260:6: note: in expansion of macro 'DO_NUMBER'
+ DO_NUMBER (1, tp->tm_year + TM_YEAR_BASE);
+ ^~~~~~~~~
+ strftime_l.c:1259:4: note: some parts of macro expansion are not guarded by this 'else' clause
+ else
+ ^~~~
+
+ In fact this particular instance is harmless; the code looks like:
+
+ if (modifier == L_('O'))
+ goto bad_format;
+ else
+ DO_NUMBER (1, tp->tm_year + TM_YEAR_BASE);
+
+ and because of the goto, it doesn't matter that part of the expansion
+ isn't under the "else" conditional. But it's also clearly bad style
+ to rely on that. This patch changes DO_NUMBER and DO_NUMBER_SPACEPAD
+ to use do { } while (0) to avoid such problems.
+
+ Tested (full testsuite) for x86_64 (GCC 6), and with
+ build-many-glibcs.py with GCC mainline, in conjunction with my libgcc
+ patch <https://gcc.gnu.org/ml/gcc-patches/2017-06/msg02032.html>.
+
+ * time/strftime_l.c (DO_NUMBER): Define using do { } while (0).
+ (DO_NUMBER_SPACEPAD): Likewise.
+
+---
+ time/strftime_l.c | 22 ++++++++++++++++------
+ 1 file changed, 16 insertions(+), 6 deletions(-)
+
+--- a/time/strftime_l.c
++++ b/time/strftime_l.c
+@@ -738,12 +738,22 @@
+ format_char = *f;
+ switch (format_char)
+ {
+-#define DO_NUMBER(d, v) \
+- digits = d > width ? d : width; \
+- number_value = v; goto do_number
+-#define DO_NUMBER_SPACEPAD(d, v) \
+- digits = d > width ? d : width; \
+- number_value = v; goto do_number_spacepad
++#define DO_NUMBER(d, v) \
++ do \
++ { \
++ digits = d > width ? d : width; \
++ number_value = v; \
++ goto do_number; \
++ } \
++ while (0)
++#define DO_NUMBER_SPACEPAD(d, v) \
++ do \
++ { \
++ digits = d > width ? d : width; \
++ number_value = v; \
++ goto do_number_spacepad; \
++ } \
++ while (0)
+
+ case L_('%'):
+ if (modifier != 0)
diff --git a/packages/glibc-linaro/2.20-2014.11/0012-if_nametoindex-size-check.patch b/packages/glibc-linaro/2.20-2014.11/0012-if_nametoindex-size-check.patch
new file mode 100644
index 0000000..7976fdd
--- /dev/null
+++ b/packages/glibc-linaro/2.20-2014.11/0012-if_nametoindex-size-check.patch
@@ -0,0 +1,29 @@
+commit 2180fee114b778515b3f560e5ff1e795282e60b0
+Author: Steve Ellcey <sellcey@caviumnetworks.com>
+Date: Wed Nov 15 08:58:48 2017 -0800
+
+ Check length of ifname before copying it into to ifreq structure.
+
+ [BZ #22442]
+ * sysdeps/unix/sysv/linux/if_index.c (__if_nametoindex):
+ Check if ifname is too long.
+
+---
+ sysdeps/unix/sysv/linux/if_index.c | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+--- a/sysdeps/unix/sysv/linux/if_index.c
++++ b/sysdeps/unix/sysv/linux/if_index.c
+@@ -43,6 +43,12 @@
+ if (fd < 0)
+ return 0;
+
++ if (strlen (ifname) >= IFNAMSIZ)
++ {
++ __set_errno (ENODEV);
++ return 0;
++ }
++
+ strncpy (ifr.ifr_name, ifname, sizeof (ifr.ifr_name));
+ if (__ioctl (fd, SIOCGIFINDEX, &ifr) < 0)
+ {