scripts/build/libc/glibc.sh
author "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
Thu Jul 28 22:09:31 2011 +0200 (2011-07-28)
changeset 2573 424fa2092ace
parent 2496 cc9b84a83b34
child 2587 7727970d04e9
permissions -rw-r--r--
scripts/libc: do not build add-ons by default

Currently, no --enable-add-ons option is passed to libc configure when
"$(do_libc_add_ons_list ,)" is empty, which makes configure automatically search
for present add-ons. In that case, all present add-ons are built, although
no add-on was selected by the user in the config. Moreover, this can make the
configure fail if some non-standard add-ons like eglibc-localedef are present.

This behavior also leads to an inconsistency from a user point of view between
the following cases:
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS="none" in the config,
which makes "$(do_libc_add_ons_list ,)" return "", so all present add-ons
are built.
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS!="none" in the
config, which makes "$(do_libc_add_ons_list ,)" return the add-on supporting
the chosen threading implementation, e.g. "nptl", so only this add-on is
built.

This patch disables the building of all add-ons in that case.

It is still possible to build all present add-ons by adding --enable-add-ons to
LIBC_GLIBC_EXTRA_CONFIG_ARRAY.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
yann@850
     1
# This file adds functions to build glibc
yann@850
     2
# Copyright 2007 Yann E. MORIN
yann@850
     3
# Licensed under the GPL v2. See COPYING in the root of this package
yann@850
     4
yann@2272
     5
# Add the definitions common to glibc and eglibc
yann@2483
     6
#   do_libc_extract
yann@2272
     7
#   do_libc_start_files
yann@2277
     8
#   do_libc
yann@2277
     9
#   do_libc_finish
yann@2277
    10
#   do_libc_add_ons_list
yann@2277
    11
#   do_libc_min_kernel_config
yann@2272
    12
. "${CT_LIB_DIR}/scripts/build/libc/glibc-eglibc.sh-common"
yann@2272
    13
yann@850
    14
# Download glibc
yann@850
    15
do_libc_get() {
yann@1260
    16
    local date
yann@1260
    17
    local version
yann@1482
    18
    local -a addons_list
yann@1482
    19
yann@1482
    20
    addons_list=($(do_libc_add_ons_list " "))
yann@1114
    21
yann@1759
    22
    # Main source
yann@1759
    23
    CT_GetFile "glibc-${CT_LIBC_VERSION}"               \
yann@1759
    24
               {ftp,http}://ftp.gnu.org/gnu/glibc       \
yann@1759
    25
               ftp://gcc.gnu.org/pub/glibc/releases     \
yann@1759
    26
               ftp://gcc.gnu.org/pub/glibc/snapshots
yann@1759
    27
yann@1759
    28
    # C library addons
yann@1759
    29
    for addon in "${addons_list[@]}"; do
yann@2504
    30
        # Never ever try to download these add-ons,
yann@2504
    31
        # they've always been internal
yann@2504
    32
        case "${addon}" in
yann@2504
    33
            nptl)   continue;;
yann@2504
    34
        esac
yann@2504
    35
yann@2496
    36
        if ! CT_GetFile "glibc-${addon}-${CT_LIBC_VERSION}"     \
yann@2496
    37
                        {ftp,http}://ftp.gnu.org/gnu/glibc      \
yann@2496
    38
                        ftp://gcc.gnu.org/pub/glibc/releases    \
yann@2496
    39
                        ftp://gcc.gnu.org/pub/glibc/snapshots
yann@2496
    40
        then
yann@2496
    41
            # Some add-ons are bundled with glibc, others are
yann@2496
    42
            # bundled in their own tarball. Eg. NPTL is internal,
yann@2496
    43
            # while LinuxThreads was external. Also, for old
yann@2496
    44
            # versions of glibc, the libidn add-on was external,
yann@2496
    45
            # but with version >=2.10, it is internal.
yann@2496
    46
            CT_DoLog DEBUG "Addon '${addon}' could not be downloaded."
yann@2496
    47
            CT_DoLog DEBUG "We'll see later if we can find it in the source tree"
yann@2496
    48
        fi
yann@1759
    49
    done
yann@850
    50
yann@850
    51
    return 0
yann@850
    52
}
yann@850
    53
yann@850
    54
# There is nothing to do for glibc check config
yann@850
    55
do_libc_check_config() {
yann@850
    56
    :
yann@850
    57
}