scripts/build/libc/glibc.sh
author "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
Thu Jul 28 22:09:31 2011 +0200 (2011-07-28)
changeset 2573 424fa2092ace
parent 2496 cc9b84a83b34
child 2587 7727970d04e9
permissions -rw-r--r--
scripts/libc: do not build add-ons by default

Currently, no --enable-add-ons option is passed to libc configure when
"$(do_libc_add_ons_list ,)" is empty, which makes configure automatically search
for present add-ons. In that case, all present add-ons are built, although
no add-on was selected by the user in the config. Moreover, this can make the
configure fail if some non-standard add-ons like eglibc-localedef are present.

This behavior also leads to an inconsistency from a user point of view between
the following cases:
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS="none" in the config,
which makes "$(do_libc_add_ons_list ,)" return "", so all present add-ons
are built.
- LIBC_ADDONS_LIST="", LIBC_GLIBC_USE_PORTS=n and THREADS!="none" in the
config, which makes "$(do_libc_add_ons_list ,)" return the add-on supporting
the chosen threading implementation, e.g. "nptl", so only this add-on is
built.

This patch disables the building of all add-ons in that case.

It is still possible to build all present add-ons by adding --enable-add-ons to
LIBC_GLIBC_EXTRA_CONFIG_ARRAY.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
     1 # This file adds functions to build glibc
     2 # Copyright 2007 Yann E. MORIN
     3 # Licensed under the GPL v2. See COPYING in the root of this package
     4 
     5 # Add the definitions common to glibc and eglibc
     6 #   do_libc_extract
     7 #   do_libc_start_files
     8 #   do_libc
     9 #   do_libc_finish
    10 #   do_libc_add_ons_list
    11 #   do_libc_min_kernel_config
    12 . "${CT_LIB_DIR}/scripts/build/libc/glibc-eglibc.sh-common"
    13 
    14 # Download glibc
    15 do_libc_get() {
    16     local date
    17     local version
    18     local -a addons_list
    19 
    20     addons_list=($(do_libc_add_ons_list " "))
    21 
    22     # Main source
    23     CT_GetFile "glibc-${CT_LIBC_VERSION}"               \
    24                {ftp,http}://ftp.gnu.org/gnu/glibc       \
    25                ftp://gcc.gnu.org/pub/glibc/releases     \
    26                ftp://gcc.gnu.org/pub/glibc/snapshots
    27 
    28     # C library addons
    29     for addon in "${addons_list[@]}"; do
    30         # Never ever try to download these add-ons,
    31         # they've always been internal
    32         case "${addon}" in
    33             nptl)   continue;;
    34         esac
    35 
    36         if ! CT_GetFile "glibc-${addon}-${CT_LIBC_VERSION}"     \
    37                         {ftp,http}://ftp.gnu.org/gnu/glibc      \
    38                         ftp://gcc.gnu.org/pub/glibc/releases    \
    39                         ftp://gcc.gnu.org/pub/glibc/snapshots
    40         then
    41             # Some add-ons are bundled with glibc, others are
    42             # bundled in their own tarball. Eg. NPTL is internal,
    43             # while LinuxThreads was external. Also, for old
    44             # versions of glibc, the libidn add-on was external,
    45             # but with version >=2.10, it is internal.
    46             CT_DoLog DEBUG "Addon '${addon}' could not be downloaded."
    47             CT_DoLog DEBUG "We'll see later if we can find it in the source tree"
    48         fi
    49     done
    50 
    51     return 0
    52 }
    53 
    54 # There is nothing to do for glibc check config
    55 do_libc_check_config() {
    56     :
    57 }